Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
f1df52ce
Commit
f1df52ce
authored
Mar 30, 2020
by
Furkan Ayhan
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove FF runner_job_trace_update_interval_header
parent
a47e7c0e
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
1 addition
and
17 deletions
+1
-17
lib/api/runner.rb
lib/api/runner.rb
+1
-4
spec/requests/api/runner_spec.rb
spec/requests/api/runner_spec.rb
+0
-13
No files found.
lib/api/runner.rb
View file @
f1df52ce
...
...
@@ -207,10 +207,7 @@ module API
status
202
header
'Job-Status'
,
job
.
status
header
'Range'
,
"0-
#{
stream_size
}
"
if
Feature
.
enabled?
(
:runner_job_trace_update_interval_header
,
default_enabled:
true
)
header
'X-GitLab-Trace-Update-Interval'
,
job
.
trace
.
update_interval
.
to_s
end
header
'X-GitLab-Trace-Update-Interval'
,
job
.
trace
.
update_interval
.
to_s
end
desc
'Authorize artifacts uploading for job'
do
...
...
spec/requests/api/runner_spec.rb
View file @
f1df52ce
...
...
@@ -1349,19 +1349,6 @@ describe API::Runner, :clean_gitlab_redis_shared_state do
expect
(
response
.
header
[
'X-GitLab-Trace-Update-Interval'
]).
to
eq
(
'30'
)
end
end
context
'when feature flag runner_job_trace_update_interval_header is disabled'
do
before
do
stub_feature_flags
(
runner_job_trace_update_interval_header:
{
enabled:
false
})
end
it
'does not return X-GitLab-Trace-Update-Interval header'
do
patch_the_trace
expect
(
response
).
to
have_gitlab_http_status
(
:accepted
)
expect
(
response
.
header
).
not_to
have_key
'X-GitLab-Trace-Update-Interval'
end
end
end
context
'when Runner makes a force-patch'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment