Merge branch 'remove_project_id_delegation_from_pipeline' into 'master'

Remove `project_id` delegation from the `Ci::Pipeline` model

See merge request gitlab-org/gitlab!50032

app/models/ci/pipeline.rb

@@ -104,7 +104,6 @@ module Ci
 
     accepts_nested_attributes_for :variables, reject_if: :persisted?
 
-    delegate :id, to: :project, prefix: true
     delegate :full_path, to: :project, prefix: true
 
     validates :sha, presence: { unless: :importing? }

ee/app/models/security/finding.rb

@@ -38,7 +38,7 @@ module Security
                 .where('vulnerability_feedback.project_fingerprint = security_findings.project_fingerprint'))
     end
     scope :ordered, -> { order(severity: :desc, confidence: :desc, id: :asc) }
-    scope :with_pipeline_entities, -> { includes(build: [:job_artifacts, pipeline: :project]) }
+    scope :with_pipeline_entities, -> { includes(build: [:job_artifacts, :pipeline]) }
     scope :with_scan, -> { includes(:scan) }
     scope :with_scanner, -> { includes(:scanner) }
     scope :deduplicated, -> { where(deduplicated: true) }

ee/spec/finders/security/findings_finder_spec.rb

@@ -91,7 +91,7 @@ RSpec.describe Security::FindingsFinder do
         end
 
         it 'does not cause N+1 queries' do
-          expect { finder_result }.not_to exceed_query_limit(9)
+          expect { finder_result }.not_to exceed_query_limit(8)
         end
 
         describe '#current_page' do