Merge branch 'pks-changes-new-commits-fix' into 'master'

checks: Fix mismatch in `#new_commits()` signature

See merge request gitlab-org/gitlab!67581

app/models/repository.rb

@@ -168,8 +168,8 @@ class Repository
   end
 
   # Returns a list of commits that are not present in any reference
-  def new_commits(newrev)
-    commits = raw.new_commits(newrev)
+  def new_commits(newrev, allow_quarantine: false)
+    commits = raw.new_commits(newrev, allow_quarantine: allow_quarantine)
 
     ::Commit.decorate(commits, container)
   end

spec/lib/gitlab/checks/changes_access_spec.rb

@@ -60,7 +60,7 @@ RSpec.describe Gitlab::Checks::ChangesAccess do
 
   describe '#commits' do
     it 'calls #new_commits' do
-      expect(project.repository).to receive(:new_commits).and_return([])
+      expect(project.repository).to receive(:new_commits).and_call_original
 
       expect(subject.commits).to eq([])
     end

spec/models/repository_spec.rb

@@ -398,32 +398,47 @@ RSpec.describe Repository do
   end
 
   describe '#new_commits' do
-    let_it_be(:project) { create(:project, :repository) }
+    shared_examples '#new_commits' do
+      let_it_be(:project) { create(:project, :repository) }
 
-    let(:repository) { project.repository }
+      let(:repository) { project.repository }
 
-    subject { repository.new_commits(rev) }
+      subject { repository.new_commits(rev, allow_quarantine: allow_quarantine) }
 
-    context 'when there are no new commits' do
-      let(:rev) { repository.commit.id }
+      context 'when there are no new commits' do
+        let(:rev) { repository.commit.id }
 
-      it 'returns an empty array' do
-        expect(subject).to eq([])
+        it 'returns an empty array' do
+          expect(subject).to eq([])
+        end
       end
-    end
 
-    context 'when new commits are found' do
-      let(:branch) { 'orphaned-branch' }
-      let!(:rev) { repository.commit(branch).id }
+      context 'when new commits are found' do
+        let(:branch) { 'orphaned-branch' }
+        let!(:rev) { repository.commit(branch).id }
+        let(:allow_quarantine) { false }
 
-      it 'returns the commits' do
-        repository.delete_branch(branch)
+        it 'returns the commits' do
+          repository.delete_branch(branch)
 
-        expect(subject).not_to be_empty
-        expect(subject).to all( be_a(::Commit) )
-        expect(subject.size).to eq(1)
+          expect(subject).not_to be_empty
+          expect(subject).to all( be_a(::Commit) )
+          expect(subject.size).to eq(1)
+        end
       end
     end
+
+    context 'with quarantine' do
+      let(:allow_quarantine) { true }
+
+      it_behaves_like '#new_commits'
+    end
+
+    context 'without quarantine' do
+      let(:allow_quarantine) { false }
+
+      it_behaves_like '#new_commits'
+    end
   end
 
   describe '#commits_by' do