Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
f325ebf2
Commit
f325ebf2
authored
Dec 23, 2020
by
Furkan Ayhan
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Enable FF ci_rules_variables by default
It's ready for production use
parent
281fda79
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
15 additions
and
9 deletions
+15
-9
changelogs/unreleased/289803-enable-ci_rules_variables.yml
changelogs/unreleased/289803-enable-ci_rules_variables.yml
+5
-0
config/feature_flags/development/ci_rules_variables.yml
config/feature_flags/development/ci_rules_variables.yml
+1
-1
doc/ci/yaml/README.md
doc/ci/yaml/README.md
+8
-7
lib/gitlab/ci/features.rb
lib/gitlab/ci/features.rb
+1
-1
No files found.
changelogs/unreleased/289803-enable-ci_rules_variables.yml
0 → 100644
View file @
f325ebf2
---
title
:
Implement variables for pipeline job rules
merge_request
:
50501
author
:
type
:
added
config/feature_flags/development/ci_rules_variables.yml
View file @
f325ebf2
...
...
@@ -5,4 +5,4 @@ rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/289803
milestone
:
'
13.7'
type
:
development
group
:
group::pipeline authoring
default_enabled
:
fals
e
default_enabled
:
tru
e
doc/ci/yaml/README.md
View file @
f325ebf2
...
...
@@ -1437,10 +1437,11 @@ In this example, if the first rule matches, then the job has `when: manual` and
#### `rules:variables`
> - [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/209864) in GitLab 13.7.
> - It's [deployed behind a feature flag](../../user/feature_flags.md), disabled by default.
> - It's disabled on GitLab.com.
> - It's not recommended for production use.
> - To use it in GitLab self-managed instances, ask a GitLab administrator to [enable it](#enable-or-disable-rulesvariables). **(CORE ONLY)**
> - It was [deployed behind a feature flag](../../user/feature_flags.md), disabled by default.
> - [Became enabled by default](https://gitlab.com/gitlab-org/gitlab/-/issues/289803) on GitLab 13.8.
> - It's enabled on GitLab.com.
> - It's recommended for production use.
> - For GitLab self-managed instances, GitLab administrators can opt to [disable it](#enable-or-disable-rulesvariables). **(CORE ONLY)**
WARNING:
This feature might not be available to you. Check the
**version history**
note above for details.
...
...
@@ -1467,10 +1468,10 @@ job:
##### Enable or disable rules:variables **(CORE ONLY)**
rules:variables is under development
and not ready for production use. It is
deployed behind a feature flag that is
**dis
abled by default**
.
rules:variables is under development
but ready for production use.
It is deployed behind a feature flag that is
**en
abled by default**
.
[
GitLab administrators with access to the GitLab Rails console
](
../../administration/feature_flags.md
)
can
en
able it.
can
opt to dis
able it.
To enable it:
...
...
lib/gitlab/ci/features.rb
View file @
f325ebf2
...
...
@@ -72,7 +72,7 @@ module Gitlab
end
def
self
.
rules_variables_enabled?
(
project
)
::
Feature
.
enabled?
(
:ci_rules_variables
,
project
,
default_enabled:
fals
e
)
::
Feature
.
enabled?
(
:ci_rules_variables
,
project
,
default_enabled:
tru
e
)
end
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment