Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
f38d20c8
Commit
f38d20c8
authored
Dec 02, 2020
by
Sanad Liaquat
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Reset instance setting after test
Also retry clicking get started button until it does not exist
parent
3de560ca
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
15 additions
and
8 deletions
+15
-8
qa/qa/flow/sign_up.rb
qa/qa/flow/sign_up.rb
+8
-7
qa/qa/page/registration/welcome.rb
qa/qa/page/registration/welcome.rb
+6
-1
qa/qa/specs/features/browser_ui/1_manage/login/register_spec.rb
...specs/features/browser_ui/1_manage/login/register_spec.rb
+1
-0
No files found.
qa/qa/flow/sign_up.rb
View file @
f38d20c8
...
...
@@ -15,16 +15,17 @@ module QA
sign_up
.
fill_new_user_username_field
(
user
.
username
)
sign_up
.
fill_new_user_email_field
(
user
.
email
)
sign_up
.
fill_new_user_password_field
(
user
.
password
)
# Because invisible_captcha would prevent submitting this form
# within 4 seconds, sleep here. This can be removed once we
# implement invisible_captcha as an application setting instead
# of a feature flag, so we can turn it off while testing.
# Issue: https://gitlab.com/gitlab-org/gitlab/-/issues/284113
sleep
5
sign_up
.
click_new_user_register_button
end
# Because invisible_captcha would prevent submitting this form
# within 4 seconds, sleep here. This can be removed once we
# implement invisible_captcha as an application setting instead
# of a feature flag, so we can turn it off while testing.
# Issue: https://gitlab.com/gitlab-org/gitlab/-/issues/284113
sleep
4
Page
::
Registration
::
Welcome
.
perform
(
&
:click_get_started_button_if_available
)
if
user
.
expect_fabrication_success
...
...
qa/qa/page/registration/welcome.rb
View file @
f38d20c8
...
...
@@ -9,7 +9,12 @@ module QA
end
def
click_get_started_button_if_available
click_element
:get_started_button
if
has_element?
(
:get_started_button
)
if
has_element?
(
:get_started_button
)
Support
::
Retrier
.
retry_until
do
click_element
:get_started_button
has_no_element?
(
:get_started_button
)
end
end
end
end
end
...
...
qa/qa/specs/features/browser_ui/1_manage/login/register_spec.rb
View file @
f38d20c8
...
...
@@ -122,6 +122,7 @@ module QA
end
after
do
set_require_admin_approval_after_user_signup_via_api
(
false
)
@user
.
remove_via_api!
if
@user
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment