Rename apollo client release components

As the original Vuex ones have been removed, the apollo_client suffix
can be removed from the new ones.

There are a few minimal changes within the files to clean up the
ApolloClient within the files as well.

app/assets/javascripts/releases/components/app_index_apollo_client.vue → app/assets/javascripts/releases/components/app_index.vue

 <script>
 import { GlButton } from '@gitlab/ui';
-import allReleasesQuery from 'shared_queries/releases/all_releases.query.graphql';
 import createFlash from '~/flash';
 import { historyPushState } from '~/lib/utils/common_utils';
 import { scrollUp } from '~/lib/utils/scroll_utils';
@@ -8,21 +7,22 @@ import { setUrlParams, getParameterByName } from '~/lib/utils/url_utility';
 import { __ } from '~/locale';
 import { PAGE_SIZE, DEFAULT_SORT } from '~/releases/constants';
 import { convertAllReleasesGraphQLResponse } from '~/releases/util';
+import allReleasesQuery from '../graphql/queries/all_releases.query.graphql';
 import ReleaseBlock from './release_block.vue';
 import ReleaseSkeletonLoader from './release_skeleton_loader.vue';
 import ReleasesEmptyState from './releases_empty_state.vue';
-import ReleasesPaginationApolloClient from './releases_pagination_apollo_client.vue';
-import ReleasesSortApolloClient from './releases_sort_apollo_client.vue';
+import ReleasesPagination from './releases_pagination.vue';
+import ReleasesSort from './releases_sort.vue';
 
 export default {
-  name: 'ReleasesIndexApolloClientApp',
+  name: 'ReleasesIndexApp',
   components: {
     GlButton,
     ReleaseBlock,
     ReleaseSkeletonLoader,
     ReleasesEmptyState,
-    ReleasesPaginationApolloClient,
-    ReleasesSortApolloClient,
+    ReleasesPagination,
+    ReleasesSort,
   },
   inject: {
     projectPath: {
@@ -231,7 +231,7 @@ export default {
 <template>
   <div class="flex flex-column mt-2">
     <div class="gl-align-self-end gl-mb-3">
-      <releases-sort-apollo-client :value="sort" class="gl-mr-2" @input="onSortChanged" />
+      <releases-sort :value="sort" class="gl-mr-2" @input="onSortChanged" />
 
       <gl-button
         v-if="newReleasePath"
@@ -254,7 +254,7 @@ export default {
 
     <release-skeleton-loader v-if="shouldRenderLoadingIndicator" />
 
-    <releases-pagination-apollo-client
+    <releases-pagination
       v-if="shouldRenderPagination"
       :page-info="pageInfo"
       @prev="onPaginationButtonPress"

app/assets/javascripts/releases/components/releases_pagination_apollo_client.vue → app/assets/javascripts/releases/components/releases_pagination.vue

@@ -4,7 +4,7 @@ import { isBoolean } from 'lodash';
 import { historyPushState, buildUrlWithCurrentLocation } from '~/lib/utils/common_utils';
 
 export default {
-  name: 'ReleasesPaginationApolloClient',
+  name: 'ReleasesPagination',
   components: { GlKeysetPagination },
   props: {
     pageInfo: {

app/assets/javascripts/releases/components/releases_sort_apollo_client.vue → app/assets/javascripts/releases/components/releases_sort.vue

@@ -14,7 +14,7 @@ import {
 } from '../constants';
 
 export default {
-  name: 'ReleasesSortApolloclient',
+  name: 'ReleasesSort',
   components: {
     GlSorting,
     GlSortingItem,

app/graphql/queries/releases/all_releases.query.graphql → app/assets/javascripts/releases/graphql/queries/all_releases.query.graphql

-# This query is identical to
-# `app/assets/javascripts/releases/graphql/queries/all_releases.query.graphql`.
-# These two queries should be kept in sync.
 query allReleases(
   $fullPath: ID!
   $first: Int

app/assets/javascripts/releases/mount_index.js

 import Vue from 'vue';
 import VueApollo from 'vue-apollo';
 import createDefaultClient from '~/lib/graphql';
-import ReleaseIndexApolloClientApp from './components/app_index_apollo_client.vue';
+import ReleaseIndexApp from './components/app_index.vue';
 
 export default () => {
   const el = document.getElementById('js-releases-page');
@@ -27,6 +27,6 @@ export default () => {
     el,
     apolloProvider,
     provide: { ...el.dataset },
-    render: (h) => h(ReleaseIndexApolloClientApp),
+    render: (h) => h(ReleaseIndexApp),
   });
 };

spec/frontend/releases/components/app_index_apollo_client_spec.js → spec/frontend/releases/components/app_index_spec.js

@@ -5,15 +5,15 @@ import originalAllReleasesQueryResponse from 'test_fixtures/graphql/releases/gra
 import createMockApollo from 'helpers/mock_apollo_helper';
 import { shallowMountExtended } from 'helpers/vue_test_utils_helper';
 import waitForPromises from 'helpers/wait_for_promises';
-import allReleasesQuery from 'shared_queries/releases/all_releases.query.graphql';
+import allReleasesQuery from '~/releases/graphql/queries/all_releases.query.graphql';
 import createFlash from '~/flash';
 import { historyPushState } from '~/lib/utils/common_utils';
-import ReleasesIndexApolloClientApp from '~/releases/components/app_index_apollo_client.vue';
+import ReleasesIndexApp from '~/releases/components/app_index.vue';
 import ReleaseBlock from '~/releases/components/release_block.vue';
 import ReleaseSkeletonLoader from '~/releases/components/release_skeleton_loader.vue';
 import ReleasesEmptyState from '~/releases/components/releases_empty_state.vue';
-import ReleasesPaginationApolloClient from '~/releases/components/releases_pagination_apollo_client.vue';
-import ReleasesSortApolloClient from '~/releases/components/releases_sort_apollo_client.vue';
+import ReleasesPagination from '~/releases/components/releases_pagination.vue';
+import ReleasesSort from '~/releases/components/releases_sort.vue';
 import { PAGE_SIZE, CREATED_ASC, DEFAULT_SORT } from '~/releases/constants';
 
 Vue.use(VueApollo);
@@ -58,7 +58,7 @@ describe('app_index_apollo_client.vue', () => {
       ],
     ]);
 
-    wrapper = shallowMountExtended(ReleasesIndexApolloClientApp, {
+    wrapper = shallowMountExtended(ReleasesIndexApp, {
       apolloProvider,
       provide: {
         newReleasePath,
@@ -91,11 +91,10 @@ describe('app_index_apollo_client.vue', () => {
   // Finders
   const findLoadingIndicator = () => wrapper.findComponent(ReleaseSkeletonLoader);
   const findEmptyState = () => wrapper.findComponent(ReleasesEmptyState);
-  const findNewReleaseButton = () =>
-    wrapper.findByText(ReleasesIndexApolloClientApp.i18n.newRelease);
+  const findNewReleaseButton = () => wrapper.findByText(ReleasesIndexApp.i18n.newRelease);
   const findAllReleaseBlocks = () => wrapper.findAllComponents(ReleaseBlock);
-  const findPagination = () => wrapper.findComponent(ReleasesPaginationApolloClient);
-  const findSort = () => wrapper.findComponent(ReleasesSortApolloClient);
+  const findPagination = () => wrapper.findComponent(ReleasesPagination);
+  const findSort = () => wrapper.findComponent(ReleasesSort);
 
   // Tests
   describe('component states', () => {
@@ -154,7 +153,7 @@ describe('app_index_apollo_client.vue', () => {
         it(`${toDescription(flashMessage)} show a flash message`, () => {
           if (flashMessage) {
             expect(createFlash).toHaveBeenCalledWith({
-              message: ReleasesIndexApolloClientApp.i18n.errorMessage,
+              message: ReleasesIndexApp.i18n.errorMessage,
               captureError: true,
               error: expect.any(Error),
             });

spec/frontend/releases/components/releases_pagination_apollo_client_spec.js → spec/frontend/releases/components/releases_pagination_spec.js

 import { mountExtended } from 'helpers/vue_test_utils_helper';
 import { historyPushState } from '~/lib/utils/common_utils';
-import ReleasesPaginationApolloClient from '~/releases/components/releases_pagination_apollo_client.vue';
+import ReleasesPagination from '~/releases/components/releases_pagination.vue';
 
 jest.mock('~/lib/utils/common_utils', () => ({
   ...jest.requireActual('~/lib/utils/common_utils'),
   historyPushState: jest.fn(),
 }));
 
-describe('releases_pagination_apollo_client.vue', () => {
+describe('releases_pagination.vue', () => {
   const startCursor = 'startCursor';
   const endCursor = 'endCursor';
   let wrapper;
@@ -18,7 +18,7 @@ describe('releases_pagination_apollo_client.vue', () => {
     onPrev = jest.fn();
     onNext = jest.fn();
 
-    wrapper = mountExtended(ReleasesPaginationApolloClient, {
+    wrapper = mountExtended(ReleasesPagination, {
       propsData: {
         pageInfo,
       },

spec/frontend/releases/components/releases_sort_apollo_client_spec.js → spec/frontend/releases/components/releases_sort_spec.js

 import { GlSorting, GlSortingItem } from '@gitlab/ui';
 import { shallowMountExtended } from 'helpers/vue_test_utils_helper';
-import ReleasesSortApolloClient from '~/releases/components/releases_sort_apollo_client.vue';
+import ReleasesSort from '~/releases/components/releases_sort.vue';
 import { RELEASED_AT_ASC, RELEASED_AT_DESC, CREATED_ASC, CREATED_DESC } from '~/releases/constants';
 
-describe('releases_sort_apollo_client.vue', () => {
+describe('releases_sort.vue', () => {
   let wrapper;
 
   const createComponent = (valueProp = RELEASED_AT_ASC) => {
-    wrapper = shallowMountExtended(ReleasesSortApolloClient, {
+    wrapper = shallowMountExtended(ReleasesSort, {
       propsData: {
         value: valueProp,
       },