Fixed: Warnings from static code analysis

f43cb6e7 · Nermin Vehabovic · ff671366 · f43cb6e7
Commit f43cb6e7 authored Feb 16, 2019 by Nermin Vehabovic
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 5 deletions

lib/api/helpers.rb lib/api/helpers.rb +3 -5

No files found.
--- a/lib/api/helpers.rb
+++ b/lib/api/helpers.rb
@@ -397,13 +397,11 @@ module API
    end
    # rubocop: enable CodeReuse/ActiveRecord
-    # rubocop: disable CodeReuse/ActiveRecord
    def order_options_with_tie_breaker
-      {params[:order_by] => params[:sort]}.tap do |order|
+      order_options = { params[:order_by] => params[:sort] }
-        order['id'] ||= 'desc'
+      order_options['id'] ||= 'desc'
-      end
+      order_options
    end
-    # rubocop: enable CodeReuse/ActiveRecord
    def project_finder_params
      finder_params = { without_deleted: true }