Merge branch 'webpack-epics-bundle' into 'master'

Remove epic show and new epic webpack bundle tag

See merge request gitlab-org/gitlab-ee!4793

config/webpack.config.js

@@ -68,8 +68,6 @@ function generateEntries() {
     // EE-only
     add_gitlab_slack_application: 'ee/add_gitlab_slack_application/index.js',
     burndown_chart:       'ee/burndown_chart/index.js',
-    epic_show:            'ee/epics/epic_show/epic_show_bundle.js',
-    new_epic:             'ee/epics/new_epic/new_epic_bundle.js',
     geo_nodes:            'ee/geo_nodes',
     issuable:             'ee/issuable/issuable_bundle.js',
     issues:               'ee/issues/issues_bundle.js',

ee/app/assets/javascripts/epics/epic_show/epic_show_bundle.js

 import Vue from 'vue';
 import EpicShowApp from './components/epic_show_app.vue';
 
-document.addEventListener('DOMContentLoaded', () => {
+export default () => {
   const el = document.querySelector('#epic-show-app');
   const metaData = JSON.parse(el.dataset.meta);
   const initialData = JSON.parse(el.dataset.initial);
@@ -21,4 +21,4 @@ document.addEventListener('DOMContentLoaded', () => {
       props,
     }),
   });
-});
+};

ee/app/assets/javascripts/epics/new_epic/new_epic_bundle.js

 import Vue from 'vue';
 import NewEpicApp from './components/new_epic.vue';
 
-document.addEventListener('DOMContentLoaded', () => {
+export default () => {
   const el = document.querySelector('#new-epic-app');
-  const props = el.dataset;
 
-  return new Vue({
-    el,
-    components: {
-      'new-epic-app': NewEpicApp,
-    },
-    render: createElement => createElement('new-epic-app', {
-      props,
-    }),
-  });
-});
+  if (el) {
+    const props = el.dataset;
+
+    new Vue({ // eslint-disable-line no-new
+      el,
+      components: {
+        'new-epic-app': NewEpicApp,
+      },
+      render: createElement => createElement('new-epic-app', {
+        props,
+      }),
+    });
+  }
+};

ee/app/assets/javascripts/pages/groups/epics/index/index.js

 import initFilteredSearch from '~/pages/search/init_filtered_search';
 import FilteredSearchTokenKeysEpics from 'ee/filtered_search/filtered_search_token_keys_epics';
+import initNewEpic from 'ee/epics/new_epic/new_epic_bundle';
 
 document.addEventListener('DOMContentLoaded', () => {
   initFilteredSearch({
@@ -7,4 +8,5 @@ document.addEventListener('DOMContentLoaded', () => {
     filteredSearchTokenKeys: FilteredSearchTokenKeysEpics,
     stateFiltersSelector: '.epics-state-filters',
   });
+  initNewEpic();
 });

ee/app/assets/javascripts/pages/groups/epics/show/index.js

 import ZenMode from '~/zen_mode';
+import initEpicShow from 'ee/epics/epic_show/epic_show_bundle';
 
-document.addEventListener('DOMContentLoaded', () => new ZenMode());
+document.addEventListener('DOMContentLoaded', () => {
+  new ZenMode(); // eslint-disable-line no-new
+  initEpicShow();
+});

ee/app/assets/javascripts/pages/groups/roadmap/show/index.js

+import initNewEpic from 'ee/epics/new_epic/new_epic_bundle';
+
+document.addEventListener('DOMContentLoaded', initNewEpic);

ee/app/views/groups/epics/index.html.haml

@@ -4,8 +4,6 @@
   = render 'shared/issuable/epic_nav', type: :epics
   .nav-controls
     - if can?(current_user, :create_epic, @group)
-      - content_for :page_specific_javascripts do
-        = webpack_bundle_tag 'new_epic'
       #new-epic-app{ data: { endpoint: request.url, 'align-right' => true } }
 
 = render 'shared/epic/search_bar', type: :epics

ee/app/views/groups/epics/show.html.haml

@@ -14,6 +14,5 @@
 
 - content_for :page_specific_javascripts do
   = webpack_bundle_tag 'common_vue'
-  = webpack_bundle_tag 'epic_show'
 
 #epic-show-app{ data: { initial: issuable_initial_data(@epic).to_json, meta: epic_meta_data } }

ee/app/views/shared/empty_states/_epics.html.haml

@@ -11,5 +11,4 @@
       - if can?(current_user, :create_epic, @group)
         - content_for :page_specific_javascripts do
           = webpack_bundle_tag 'common_vue'
-          = webpack_bundle_tag 'new_epic'
         #new-epic-app{ data: { endpoint: request.url } }

ee/app/views/shared/empty_states/_roadmap.html.haml

@@ -11,7 +11,6 @@
       - if can?(current_user, :create_epic, @group)
         - content_for :page_specific_javascripts do
           = webpack_bundle_tag 'common_vue'
-          = webpack_bundle_tag 'new_epic'
         #new-epic-app{ data: { endpoint: request.url } }
       = link_to group_epics_path(@group), title: 'List', class: 'btn' do
         %span= _('View epics list')