Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
f7161ddb
Commit
f7161ddb
authored
Apr 14, 2020
by
Sanad Liaquat
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix flaky Jenkins e2e spec javascript error
by retrying on exception Also remove quarantine tag
parent
37576eaa
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
7 additions
and
6 deletions
+7
-6
qa/qa/specs/features/ee/browser_ui/3_create/jenkins/jenkins_build_status_spec.rb
.../browser_ui/3_create/jenkins/jenkins_build_status_spec.rb
+1
-5
qa/qa/vendor/jenkins/page/last_job_console.rb
qa/qa/vendor/jenkins/page/last_job_console.rb
+6
-1
No files found.
qa/qa/specs/features/ee/browser_ui/3_create/jenkins/jenkins_build_status_spec.rb
View file @
f7161ddb
...
@@ -26,11 +26,7 @@ module QA
...
@@ -26,11 +26,7 @@ module QA
setup_jenkins
setup_jenkins
end
end
quarantine
=
{
it
'integrates and displays build status for MR pipeline in GitLab'
do
type: :flaky
,
issue:
'https://gitlab.com/gitlab-org/gitlab/-/issues/213953'
}
it
'integrates and displays build status for MR pipeline in GitLab'
,
quarantine:
quarantine
do
login_to_gitlab
login_to_gitlab
setup_project_integration_with_jenkins
setup_project_integration_with_jenkins
...
...
qa/qa/vendor/jenkins/page/last_job_console.rb
View file @
f7161ddb
...
@@ -14,7 +14,12 @@ module QA
...
@@ -14,7 +14,12 @@ module QA
end
end
def
has_successful_build?
def
has_successful_build?
page
.
has_text?
(
'Finished: SUCCESS'
)
# Retry on errors such as:
# Selenium::WebDriver::Error::JavascriptError:
# javascript error: this.each is not a function
Support
::
Retrier
.
retry_on_exception
(
reload_page:
page
)
do
page
.
has_text?
(
'Finished: SUCCESS'
)
end
end
end
def
no_failed_status_update?
def
no_failed_status_update?
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment