Commit f7161ddb authored by Sanad Liaquat's avatar Sanad Liaquat

Fix flaky Jenkins e2e spec javascript error

by retrying on exception
Also remove quarantine tag
parent 37576eaa
...@@ -26,11 +26,7 @@ module QA ...@@ -26,11 +26,7 @@ module QA
setup_jenkins setup_jenkins
end end
quarantine = { it 'integrates and displays build status for MR pipeline in GitLab' do
type: :flaky,
issue: 'https://gitlab.com/gitlab-org/gitlab/-/issues/213953'
}
it 'integrates and displays build status for MR pipeline in GitLab', quarantine: quarantine do
login_to_gitlab login_to_gitlab
setup_project_integration_with_jenkins setup_project_integration_with_jenkins
......
...@@ -14,7 +14,12 @@ module QA ...@@ -14,7 +14,12 @@ module QA
end end
def has_successful_build? def has_successful_build?
page.has_text?('Finished: SUCCESS') # Retry on errors such as:
# Selenium::WebDriver::Error::JavascriptError:
# javascript error: this.each is not a function
Support::Retrier.retry_on_exception(reload_page: page) do
page.has_text?('Finished: SUCCESS')
end
end end
def no_failed_status_update? def no_failed_status_update?
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment