Merge branch 'mc/bug/remove-reliance-on-branch-context' into 'master'

Resolve project from branch repository

See merge request gitlab-org/gitlab!55694

app/graphql/mutations/branches/create.rb

@@ -30,8 +30,6 @@ module Mutations
       def resolve(project_path:, name:, ref:)
         project = authorized_find!(project_path)
 
-        context.scoped_set!(:branch_project, project)
-
         result = ::Branches::CreateService.new(project, current_user)
                    .execute(name, ref)
 

app/graphql/resolvers/branch_commit_resolver.rb

@@ -10,8 +10,9 @@ module Resolvers
       return unless branch
 
       commit = branch.dereferenced_target
+      project = Project.find_by_full_path(commit.repository.gl_project_path)
 
-      ::Commit.new(commit, context[:branch_project]) if commit
+      ::Commit.new(commit, project) if commit
     end
   end
 end

changelogs/unreleased/mc-bug-remove-reliance-on-branch-context.yml

+---
+title: Resolve project from branch in commit resolver.
+merge_request: 55694
+author:
+type: fixed

lib/gitlab/git/commit.rb

@@ -20,6 +20,7 @@ module Gitlab
       ].freeze
 
       attr_accessor(*SERIALIZE_KEYS)
+      attr_reader :repository
 
       def ==(other)
         return false unless other.is_a?(Gitlab::Git::Commit)

spec/graphql/resolvers/branch_commit_resolver_spec.rb

@@ -15,6 +15,10 @@ RSpec.describe Resolvers::BranchCommitResolver do
       is_expected.to eq(repository.commits('master', limit: 1).last)
     end
 
+    it 'sets project container' do
+      expect(commit.container).to eq(repository.project)
+    end
+
     context 'when branch does not exist' do
       let(:branch) { nil }