Commit fa71f106 authored by Mike Greiling's avatar Mike Greiling

Merge branch 'nfriend-update-reference-to-frontend-leads' into 'master'

Replace reference to frontend lead with foundations member

See merge request gitlab-org/gitlab!45589
parents 75bebd66 8d07d615
...@@ -91,8 +91,14 @@ with [domain expertise](#domain-experts). ...@@ -91,8 +91,14 @@ with [domain expertise](#domain-experts).
**approved by a [frontend maintainer](https://about.gitlab.com/handbook/engineering/projects/#gitlab_maintainers_frontend)**. **approved by a [frontend maintainer](https://about.gitlab.com/handbook/engineering/projects/#gitlab_maintainers_frontend)**.
1. If your merge request includes UX changes (*1*), it must be 1. If your merge request includes UX changes (*1*), it must be
**approved by a [UX team member](https://about.gitlab.com/company/team/)**. **approved by a [UX team member](https://about.gitlab.com/company/team/)**.
1. If your merge request includes adding a new JavaScript library (*1*), it must be 1. If your merge request includes adding a new JavaScript library (*1*)...
**approved by a [frontend lead](https://about.gitlab.com/company/team/)**. - If the library significantly increases the
[bundle size](https://gitlab.com/gitlab-org/frontend/playground/webpack-memory-metrics/-/blob/master/doc/report.md), it must
be **approved by a [frontend foundations member](https://about.gitlab.com/direction/create/ecosystem/frontend-ux-foundations/)**.
- If the license used by the new library hasn't been approved for use in
GitLab, the license must be **approved by a [legal department member](https://about.gitlab.com/handbook/legal/)**.
More information about license compatiblity can be found in our
[GitLab Licensing and Compatibility documentation](./licensing.md).
1. If your merge request includes adding a new UI/UX paradigm (*1*), it must be 1. If your merge request includes adding a new UI/UX paradigm (*1*), it must be
**approved by a [UX lead](https://about.gitlab.com/company/team/)**. **approved by a [UX lead](https://about.gitlab.com/company/team/)**.
1. If your merge request includes a new dependency or a filesystem change, it must be 1. If your merge request includes a new dependency or a filesystem change, it must be
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment