Optimize deployment_variables method

fc02778a · Shinya Maeda · d5c5cbcd · fc02778a
Commit fc02778a authored Dec 05, 2017 by Shinya Maeda
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 3 deletions

app/models/project.rb app/models/project.rb +1 -3

No files found.
--- a/app/models/project.rb
+++ b/app/models/project.rb
@@ -1557,9 +1557,7 @@ class Project < ActiveRecord::Base
  end

  def deployment_variables(environment: nil)
-    return [] unless deployment_platform(environment: environment)
-
-    deployment_platform(environment: environment).predefined_variables
+    deployment_platform(environment: environment)&.predefined_variables || []
  end

  def auto_devops_variables