Update package index/show pages to match UX recommendations

Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>

ee/app/assets/stylesheets/pages/packages.scss

+.table-holder .packages-table {
+  tr {
+    th {
+      border-top: none;
+      background: none;
+      padding: $gl-padding-top 0;
+    }
+
+    td {
+      padding: $gl-padding-top 0;
+    }
+  }
+}

ee/app/views/projects/packages/packages/index.html.haml

@@ -2,32 +2,34 @@
 - can_destroy_package = can?(current_user, :destroy_package, @project)
 
 - if @packages.any?
-  %table.table
-    %thead
-      %tr
-        %th= _('Name')
-        %th= _('Version')
-        %th= _('Type')
-        %th= _('Created')
-        %th
-
-    %tbody
-      - @packages.each do |package|
+  .table-holder
+    %table.table.packages-table
+      %thead
         %tr
-          %td
-            = link_to package.name, project_package_path(@project, package)
-          %td
-            = package.version
-          %td
-            = _('Maven package')
-          %td
-            = time_ago_with_tooltip(package.created_at)
-          %td
-            - if can_destroy_package
-              = link_to project_package_path(@project, package), method: :delete, data: { confirm: _("Are you sure?") }, class: "btn btn-grouped btn-inverted btn-remove", title: _('Delete Package') do
-                = icon('trash')
+          %th= _('Name')
+          %th= _('Version')
+          %th= _('Type')
+          %th= _('Created')
+          %th
+
+      %tbody
+        - @packages.each do |package|
+          %tr
+            %td
+              = link_to package.name, project_package_path(@project, package)
+            %td
+              = package.version
+            %td
+              = _('Maven package')
+            %td
+              = time_ago_with_tooltip(package.created_at)
+            %td
+              - if can_destroy_package
+                .pull-right
+                  = link_to project_package_path(@project, package), method: :delete, data: { confirm: _("Are you sure?") }, class: "btn btn-grouped btn-inverted btn-remove", title: _('Delete Package') do
+                    = icon('trash')
 
-  = paginate @packages, theme: "gitlab"
+    = paginate @packages, theme: "gitlab"
 
 - else
   .nothing-here-block

ee/app/views/projects/packages/packages/show.html.haml

@@ -18,17 +18,17 @@
         %strong= _('Package information')
       %ul.content-list
         %li
-          %span.light
+          %span.text-secondary
             = _('Name')
           %span.pull-right
             = @package.name
         %li
-          %span.light
+          %span.text-secondary
             = _('Version')
           %span.pull-right
             = @package.version
         %li
-          %span.light
+          %span.text-secondary
             = _('Created on')
           %span.pull-right
             = @package.created_at.to_s(:medium)
@@ -39,26 +39,30 @@
           %strong= _('Maven Metadata')
         %ul.content-list
           %li
-            %span.light
+            %span.text-secondary
               = _('Group ID')
             %span.pull-right
               = @maven_metadatum.app_group
           %li
-            %span.light
+            %span.text-secondary
               = _('Artifact ID')
             %span.pull-right
               = @maven_metadatum.app_name
           %li
-            %span.light
+            %span.text-secondary
               = _('Version')
             %span.pull-right
               = @maven_metadatum.app_version
 %table.table
   %thead
     %tr
-      %th Name
-      %th Size
-      %th Created
+      %th
+        = _('Name')
+      %th
+        = _('Size')
+      %th
+        .pull-right
+          = _('Created')
   %tbody
     - @package_files.each do |package_file|
       %tr
@@ -68,4 +72,5 @@
         %td
           = number_to_human_size(package_file.size, precision: 2)
         %td
-          = time_ago_with_tooltip(package_file.created_at)
+          .pull-right
+            = time_ago_with_tooltip(package_file.created_at)

locale/gitlab.pot

@@ -6465,6 +6465,9 @@ msgstr ""
 msgid "Sign-up restrictions"
 msgstr ""
 
+msgid "Size"
+msgstr ""
+
 msgid "Size and domain settings for static websites"
 msgstr ""