Merge branch '320705-move-the-code_review-metrics-out-of-common-yml' into 'master'

Resolve "Move the code_review metrics out of common.yml"

See merge request gitlab-org/gitlab!53566

lib/gitlab/usage_data_counters/known_events/code_review_events.yml

+---
+- name: i_code_review_mr_diffs
+  redis_slot: code_review
+  category: code_review
+  aggregation: weekly
+  feature_flag: usage_data_i_code_review_mr_diffs
+- name: i_code_review_user_single_file_diffs
+  redis_slot: code_review
+  category: code_review
+  aggregation: weekly
+  feature_flag: usage_data_i_code_review_user_single_file_diffs
+- name: i_code_review_mr_single_file_diffs
+  redis_slot: code_review
+  category: code_review
+  aggregation: weekly
+  feature_flag: usage_data_i_code_review_mr_single_file_diffs
+- name: i_code_review_user_create_mr
+  redis_slot: code_review
+  category: code_review
+  aggregation: weekly
+  feature_flag: usage_data_i_code_review_user_create_mr
+- name: i_code_review_user_close_mr
+  redis_slot: code_review
+  category: code_review
+  aggregation: weekly
+  feature_flag: usage_data_i_code_review_user_close_mr
+- name: i_code_review_user_reopen_mr
+  redis_slot: code_review
+  category: code_review
+  aggregation: weekly
+  feature_flag: usage_data_i_code_review_user_reopen_mr
+- name: i_code_review_user_approve_mr
+  redis_slot: code_review
+  category: code_review
+  aggregation: weekly
+  feature_flag: usage_data_i_code_review_user_approve_mr
+- name: i_code_review_user_unapprove_mr
+  redis_slot: code_review
+  category: code_review
+  aggregation: weekly
+  feature_flag: usage_data_i_code_review_user_unapprove_mr
+- name: i_code_review_user_resolve_thread
+  redis_slot: code_review
+  category: code_review
+  aggregation: weekly
+  feature_flag: usage_data_i_code_review_user_resolve_thread
+- name: i_code_review_user_unresolve_thread
+  redis_slot: code_review
+  category: code_review
+  aggregation: weekly
+  feature_flag: usage_data_i_code_review_user_unresolve_thread
+- name: i_code_review_edit_mr_title
+  redis_slot: code_review
+  category: code_review
+  aggregation: weekly
+  feature_flag: usage_data_i_code_review_edit_mr_title
+- name: i_code_review_edit_mr_desc
+  redis_slot: code_review
+  category: code_review
+  aggregation: weekly
+  feature_flag: usage_data_i_code_review_edit_mr_desc
+- name: i_code_review_user_merge_mr
+  redis_slot: code_review
+  category: code_review
+  aggregation: weekly
+  feature_flag: usage_data_i_code_review_user_merge_mr
+- name: i_code_review_user_create_mr_comment
+  redis_slot: code_review
+  category: code_review
+  aggregation: weekly
+  feature_flag: usage_data_i_code_review_user_create_mr_comment
+- name: i_code_review_user_edit_mr_comment
+  redis_slot: code_review
+  category: code_review
+  aggregation: weekly
+  feature_flag: usage_data_i_code_review_user_edit_mr_comment
+- name: i_code_review_user_remove_mr_comment
+  redis_slot: code_review
+  category: code_review
+  aggregation: weekly
+  feature_flag: usage_data_i_code_review_user_remove_mr_comment
+- name: i_code_review_user_create_review_note
+  redis_slot: code_review
+  category: code_review
+  aggregation: weekly
+  feature_flag: usage_data_i_code_review_user_create_review_note
+- name: i_code_review_user_publish_review
+  redis_slot: code_review
+  category: code_review
+  aggregation: weekly
+  feature_flag: usage_data_i_code_review_user_publish_review
+- name: i_code_review_user_create_multiline_mr_comment
+  redis_slot: code_review
+  category: code_review
+  aggregation: weekly
+  feature_flag: usage_data_i_code_review_user_create_multiline_mr_comment
+- name: i_code_review_user_edit_multiline_mr_comment
+  redis_slot: code_review
+  category: code_review
+  aggregation: weekly
+  feature_flag: usage_data_i_code_review_user_edit_multiline_mr_comment
+- name: i_code_review_user_remove_multiline_mr_comment
+  redis_slot: code_review
+  category: code_review
+  aggregation: weekly
+  feature_flag: usage_data_i_code_review_user_remove_multiline_mr_comment
+- name: i_code_review_user_add_suggestion
+  redis_slot: code_review
+  category: code_review
+  aggregation: weekly
+  feature_flag: usage_data_i_code_review_user_add_suggestion
+- name: i_code_review_user_apply_suggestion
+  redis_slot: code_review
+  category: code_review
+  aggregation: weekly
+  feature_flag: usage_data_i_code_review_user_apply_suggestion
+- name: i_code_review_user_assigned
+  redis_slot: code_review
+  category: code_review
+  aggregation: weekly
+  feature_flag: usage_data_i_code_review_user_assigned
+- name: i_code_review_user_review_requested
+  redis_slot: code_review
+  category: code_review
+  aggregation: weekly
+  feature_flag: usage_data_i_code_review_user_review_requested

lib/gitlab/usage_data_counters/known_events/common.yml

@@ -455,132 +455,6 @@
   redis_slot: snippets
   aggregation: weekly
   feature_flag: usage_data_i_snippets_show
-# Merge request counters
-- name: i_code_review_mr_diffs
-  redis_slot: code_review
-  category: code_review
-  aggregation: weekly
-  feature_flag: usage_data_i_code_review_mr_diffs
-- name: i_code_review_user_single_file_diffs
-  redis_slot: code_review
-  category: code_review
-  aggregation: weekly
-  feature_flag: usage_data_i_code_review_user_single_file_diffs
-- name: i_code_review_mr_single_file_diffs
-  redis_slot: code_review
-  category: code_review
-  aggregation: weekly
-  feature_flag: usage_data_i_code_review_mr_single_file_diffs
-- name: i_code_review_user_create_mr
-  redis_slot: code_review
-  category: code_review
-  aggregation: weekly
-  feature_flag: usage_data_i_code_review_user_create_mr
-- name: i_code_review_user_close_mr
-  redis_slot: code_review
-  category: code_review
-  aggregation: weekly
-  feature_flag: usage_data_i_code_review_user_close_mr
-- name: i_code_review_user_reopen_mr
-  redis_slot: code_review
-  category: code_review
-  aggregation: weekly
-  feature_flag: usage_data_i_code_review_user_reopen_mr
-- name: i_code_review_user_approve_mr
-  redis_slot: code_review
-  category: code_review
-  aggregation: weekly
-  feature_flag: usage_data_i_code_review_user_approve_mr
-- name: i_code_review_user_unapprove_mr
-  redis_slot: code_review
-  category: code_review
-  aggregation: weekly
-  feature_flag: usage_data_i_code_review_user_unapprove_mr
-- name: i_code_review_user_resolve_thread
-  redis_slot: code_review
-  category: code_review
-  aggregation: weekly
-  feature_flag: usage_data_i_code_review_user_resolve_thread
-- name: i_code_review_user_unresolve_thread
-  redis_slot: code_review
-  category: code_review
-  aggregation: weekly
-  feature_flag: usage_data_i_code_review_user_unresolve_thread
-- name: i_code_review_edit_mr_title
-  redis_slot: code_review
-  category: code_review
-  aggregation: weekly
-  feature_flag: usage_data_i_code_review_edit_mr_title
-- name: i_code_review_edit_mr_desc
-  redis_slot: code_review
-  category: code_review
-  aggregation: weekly
-  feature_flag: usage_data_i_code_review_edit_mr_desc
-- name: i_code_review_user_merge_mr
-  redis_slot: code_review
-  category: code_review
-  aggregation: weekly
-  feature_flag: usage_data_i_code_review_user_merge_mr
-- name: i_code_review_user_create_mr_comment
-  redis_slot: code_review
-  category: code_review
-  aggregation: weekly
-  feature_flag: usage_data_i_code_review_user_create_mr_comment
-- name: i_code_review_user_edit_mr_comment
-  redis_slot: code_review
-  category: code_review
-  aggregation: weekly
-  feature_flag: usage_data_i_code_review_user_edit_mr_comment
-- name: i_code_review_user_remove_mr_comment
-  redis_slot: code_review
-  category: code_review
-  aggregation: weekly
-  feature_flag: usage_data_i_code_review_user_remove_mr_comment
-- name: i_code_review_user_create_review_note
-  redis_slot: code_review
-  category: code_review
-  aggregation: weekly
-  feature_flag: usage_data_i_code_review_user_create_review_note
-- name: i_code_review_user_publish_review
-  redis_slot: code_review
-  category: code_review
-  aggregation: weekly
-  feature_flag: usage_data_i_code_review_user_publish_review
-- name: i_code_review_user_create_multiline_mr_comment
-  redis_slot: code_review
-  category: code_review
-  aggregation: weekly
-  feature_flag: usage_data_i_code_review_user_create_multiline_mr_comment
-- name: i_code_review_user_edit_multiline_mr_comment
-  redis_slot: code_review
-  category: code_review
-  aggregation: weekly
-  feature_flag: usage_data_i_code_review_user_edit_multiline_mr_comment
-- name: i_code_review_user_remove_multiline_mr_comment
-  redis_slot: code_review
-  category: code_review
-  aggregation: weekly
-  feature_flag: usage_data_i_code_review_user_remove_multiline_mr_comment
-- name: i_code_review_user_add_suggestion
-  redis_slot: code_review
-  category: code_review
-  aggregation: weekly
-  feature_flag: usage_data_i_code_review_user_add_suggestion
-- name: i_code_review_user_apply_suggestion
-  redis_slot: code_review
-  category: code_review
-  aggregation: weekly
-  feature_flag: usage_data_i_code_review_user_apply_suggestion
-- name: i_code_review_user_assigned
-  redis_slot: code_review
-  category: code_review
-  aggregation: weekly
-  feature_flag: usage_data_i_code_review_user_assigned
-- name: i_code_review_user_review_requested
-  redis_slot: code_review
-  category: code_review
-  aggregation: weekly
-  feature_flag: usage_data_i_code_review_user_review_requested
 # Terraform
 - name: p_terraform_state_api_unique_users
   category: terraform