Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
fef06e63
Commit
fef06e63
authored
Mar 23, 2022
by
John Mason
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove block_namespace_serialization feature flag
Changelog: changed
parent
098b5523
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
0 additions
and
20 deletions
+0
-20
app/models/namespace.rb
app/models/namespace.rb
+0
-4
config/feature_flags/development/block_namespace_serialization.yml
...ature_flags/development/block_namespace_serialization.yml
+0
-8
spec/models/namespace_spec.rb
spec/models/namespace_spec.rb
+0
-8
No files found.
app/models/namespace.rb
View file @
fef06e63
...
...
@@ -661,10 +661,6 @@ class Namespace < ApplicationRecord
# Use SHA2 of `traversal_ids` to account for moving a namespace within the same root ancestor hierarchy.
"namespaces:{
#{
traversal_ids
.
first
}
}:first_auto_devops_config:
#{
group_id
}
:
#{
Digest
::
SHA2
.
hexdigest
(
traversal_ids
.
join
(
' '
))
}
"
end
def
allow_serialization?
(
options
=
nil
)
Feature
.
disabled?
(
:block_namespace_serialization
,
self
,
default_enabled: :yaml
)
||
super
end
end
Namespace
.
prepend_mod_with
(
'Namespace'
)
config/feature_flags/development/block_namespace_serialization.yml
deleted
100644 → 0
View file @
098b5523
---
name
:
block_namespace_serialization
introduced_by_url
:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/82661
rollout_issue_url
:
https://gitlab.com/gitlab-org/gitlab/-/issues/355553
milestone
:
'
14.9'
type
:
development
group
:
group::global search
default_enabled
:
false
spec/models/namespace_spec.rb
View file @
fef06e63
...
...
@@ -2235,13 +2235,5 @@ RSpec.describe Namespace do
let
(
:object
)
{
build
(
:namespace
)
}
it_behaves_like
'blocks unsafe serialization'
context
'when feature flag block_namespace_serialization is disabled'
do
before
do
stub_feature_flags
(
block_namespace_serialization:
false
)
end
it_behaves_like
'allows unsafe serialization'
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment