Remove trasnaction when update_column_in_batches is used

Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>

db/migrate/20170118194941_convert_application_settings_repository_size_limit_to_bytes.rb

@@ -19,13 +19,11 @@ class ConvertApplicationSettingsRepositorySizeLimitToBytes < ActiveRecord::Migra
 
     sql_expression = Arel::Nodes::SqlLiteral.new(bigint_string)
 
-    connection.transaction do
-      update_column_in_batches(:application_settings, :repository_size_limit, sql_expression) do |t, query|
-        query.where(t[:repository_size_limit_mb].not_eq(nil))
-      end
-
-      remove_column :application_settings, :repository_size_limit_mb
+    update_column_in_batches(:application_settings, :repository_size_limit, sql_expression) do |t, query|
+      query.where(t[:repository_size_limit_mb].not_eq(nil))
     end
+
+    remove_column :application_settings, :repository_size_limit_mb
   end
 
   def down
@@ -36,12 +34,10 @@ class ConvertApplicationSettingsRepositorySizeLimitToBytes < ActiveRecord::Migra
 
     sql_expression = Arel::Nodes::SqlLiteral.new('repository_size_limit_bytes / 1024 / 1024')
 
-    connection.transaction do
-      update_column_in_batches(:application_settings, :repository_size_limit, sql_expression) do |t, query|
-        query.where(t[:repository_size_limit_bytes].not_eq(nil))
-      end
-
-      remove_column :application_settings, :repository_size_limit_bytes
+    update_column_in_batches(:application_settings, :repository_size_limit, sql_expression) do |t, query|
+      query.where(t[:repository_size_limit_bytes].not_eq(nil))
     end
+
+    remove_column :application_settings, :repository_size_limit_bytes
   end
 end

db/migrate/20170118200338_convert_projects_repository_size_limit_to_bytes.rb

@@ -19,13 +19,11 @@ class ConvertProjectsRepositorySizeLimitToBytes < ActiveRecord::Migration
 
     sql_expression = Arel::Nodes::SqlLiteral.new(bigint_string)
 
-    connection.transaction do
-      update_column_in_batches(:projects, :repository_size_limit, sql_expression) do |t, query|
-        query.where(t[:repository_size_limit_mb].not_eq(nil))
-      end
-
-      remove_column :projects, :repository_size_limit_mb
+    update_column_in_batches(:projects, :repository_size_limit, sql_expression) do |t, query|
+      query.where(t[:repository_size_limit_mb].not_eq(nil))
     end
+
+    remove_column :projects, :repository_size_limit_mb
   end
 
   def down
@@ -36,12 +34,10 @@ class ConvertProjectsRepositorySizeLimitToBytes < ActiveRecord::Migration
 
     sql_expression = Arel::Nodes::SqlLiteral.new('repository_size_limit_bytes / 1024 / 1024')
 
-    connection.transaction do
-      update_column_in_batches(:projects, :repository_size_limit, sql_expression) do |t, query|
-        query.where(t[:repository_size_limit_bytes].not_eq(nil))
-      end
-
-      remove_column :projects, :repository_size_limit_bytes
+    update_column_in_batches(:projects, :repository_size_limit, sql_expression) do |t, query|
+      query.where(t[:repository_size_limit_bytes].not_eq(nil))
     end
+
+    remove_column :projects, :repository_size_limit_bytes
   end
 end

db/migrate/20170118200412_convert_namespaces_repository_size_limit_to_bytes.rb

@@ -19,13 +19,11 @@ class ConvertNamespacesRepositorySizeLimitToBytes < ActiveRecord::Migration
 
     sql_expression = Arel::Nodes::SqlLiteral.new(bigint_string)
 
-    connection.transaction do
-      update_column_in_batches(:namespaces, :repository_size_limit, sql_expression) do |t, query|
-        query.where(t[:repository_size_limit_mb].not_eq(nil))
-      end
-
-      remove_column :namespaces, :repository_size_limit_mb
+    update_column_in_batches(:namespaces, :repository_size_limit, sql_expression) do |t, query|
+      query.where(t[:repository_size_limit_mb].not_eq(nil))
     end
+
+    remove_column :namespaces, :repository_size_limit_mb
   end
 
   def down
@@ -36,12 +34,10 @@ class ConvertNamespacesRepositorySizeLimitToBytes < ActiveRecord::Migration
 
     sql_expression = Arel::Nodes::SqlLiteral.new('repository_size_limit_bytes / 1024 / 1024')
 
-    connection.transaction do
-      update_column_in_batches(:namespaces, :repository_size_limit, sql_expression) do |t, query|
-        query.where(t[:repository_size_limit_bytes].not_eq(nil))
-      end
-
-      remove_column :namespaces, :repository_size_limit_bytes
+    update_column_in_batches(:namespaces, :repository_size_limit, sql_expression) do |t, query|
+      query.where(t[:repository_size_limit_bytes].not_eq(nil))
     end
+
+    remove_column :namespaces, :repository_size_limit_bytes
   end
 end