Merge branch '290117-feature-flag-rollout-visualization-tab-in-pa-home' into 'master'

Remove Feature Flag for visualization tab in PA home" [RUN ALL RSPEC] [RUN AS-IF-FOSS]

See merge request gitlab-org/gitlab!60273

app/assets/javascripts/pipeline_editor/components/pipeline_editor_tabs.vue

@@ -110,7 +110,6 @@ export default {
       <text-editor :value="ciFileContent" v-on="$listeners" />
     </editor-tab>
     <editor-tab
-      v-if="glFeatures.ciConfigVisualizationTab"
       class="gl-mb-3"
       :empty-message="$options.i18n.empty.visualization"
       :is-empty="isEmpty"

app/controllers/projects/ci/pipeline_editor_controller.rb

@@ -3,7 +3,6 @@
 class Projects::Ci::PipelineEditorController < Projects::ApplicationController
   before_action :check_can_collaborate!
   before_action do
-    push_frontend_feature_flag(:ci_config_visualization_tab, @project, default_enabled: :yaml)
     push_frontend_feature_flag(:ci_config_merged_tab, @project, default_enabled: :yaml)
     push_frontend_feature_flag(:pipeline_status_for_pipeline_editor, @project, default_enabled: :yaml)
     push_frontend_feature_flag(:pipeline_editor_empty_state_action, @project, default_enabled: :yaml)

changelogs/unreleased/290117-feature-flag-rollout-visualization-tab-in-pa-home.yml

+---
+title: Remove visualization feature flag in pipeline editor
+merge_request: 60273
+author:
+type: changed

config/feature_flags/development/ci_config_visualization_tab.yml

----
-name: ci_config_visualization_tab
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/48793
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/290117
-milestone: '13.7'
-type: development
-group: group::pipeline authoring
-default_enabled: true

doc/ci/pipeline_editor/index.md

@@ -53,14 +53,7 @@ reflected in the CI lint. It displays the same results as the existing [CI Lint
 
 > - [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/241722) in GitLab 13.5.
 > - [Moved to **CI/CD > Editor**](https://gitlab.com/gitlab-org/gitlab/-/issues/263141) in GitLab 13.7.
-> - It was [deployed behind a feature flag](../../user/feature_flags.md), disabled by default.
-> - [Became enabled by default](https://gitlab.com/gitlab-org/gitlab/-/issues/290117) in GitLab 13.8.
-> - It's enabled on GitLab.com.
-> - It's recommended for production use.
-> - To use it in GitLab self-managed instances, ask a GitLab administrator to [enable it](#enable-or-disable-cicd-configuration-visualization). **(FREE SELF)**
-
-WARNING:
-This feature might not be available to you. Check the **version history** note above for details.
+> - [Feature flag removed](https://gitlab.com/gitlab-org/gitlab/-/issues/290117) in GitLab 13.12.
 
 To view a visualization of your `gitlab-ci.yml` configuration, in your project,
 go to **CI/CD > Editor**, and then select the **Visualize** tab. The
@@ -77,25 +70,6 @@ Hover over a job to highlight its `needs` relationships:
 If the configuration does not have any `needs` relationships, then no lines are drawn because
 each job depends only on the previous stage being completed successfully.
 
-### Enable or disable CI/CD configuration visualization **(FREE SELF)**
-
-CI/CD configuration visualization is under development but ready for production use.
-It is deployed behind a feature flag that is **enabled by default**.
-[GitLab administrators with access to the GitLab Rails console](../../administration/feature_flags.md)
-can opt to disable it.
-
-To disable it:
-
-```ruby
-Feature.disable(:ci_config_visualization_tab)
-```
-
-To enable it:
-
-```ruby
-Feature.enable(:ci_config_visualization_tab)
-```
-
 ## View expanded configuration
 
 > - [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/246801) in GitLab 13.9.

spec/frontend/pipeline_editor/components/pipeline_editor_tabs_spec.js

@@ -22,7 +22,6 @@ describe('Pipeline editor tabs component', () => {
   };
   const mockProvide = {
     glFeatures: {
-      ciConfigVisualizationTab: true,
       ciConfigMergedTab: true,
     },
   };
@@ -104,21 +103,6 @@ describe('Pipeline editor tabs component', () => {
         });
       });
     });
-
-    describe('with feature flag off', () => {
-      beforeEach(() => {
-        createComponent({
-          provide: {
-            glFeatures: { ciConfigVisualizationTab: false },
-          },
-        });
-      });
-
-      it('does not display the tab or component', () => {
-        expect(findVisualizationTab().exists()).toBe(false);
-        expect(findPipelineGraph().exists()).toBe(false);
-      });
-    });
   });
 
   describe('lint tab', () => {