Commit ff44e0e9 authored by Kamil Trzciński's avatar Kamil Trzciński

Fix all code offences

parent bddd1961
......@@ -31,7 +31,7 @@ module EE
nav_tabs
end
override :tab_ability_map
def tab_ability_map
tab_ability_map = super
......
- @breadcrumb_link = new_project_feature_flag_path(@project)
- add_to_breadcrumbs "Feature Flags", project_feature_flags_path(@project)
- breadcrumb_title s_('FeatureFlags|New')
- page_title s_('FeatureFlags|New Feature Flag')
......
......@@ -67,7 +67,7 @@ describe Projects::FeatureFlagsController do
it 'renders the form' do
subject
expect(response).to be_ok
expect(response).to render_template('new')
expect(response).to render_template('_form')
......@@ -151,4 +151,3 @@ describe Projects::FeatureFlagsController do
{ namespace_id: project.namespace, project_id: project }
end
end
......@@ -14,6 +14,7 @@ describe 'Feature Flags', :js do
let(:project) {create(:project, namespace: user.namespace)}
before do
stub_licensed_features(feature_flags: true)
sign_in(user)
end
......@@ -47,7 +48,7 @@ describe 'Feature Flags', :js do
it 'displays an error message' do
add_feature_flag(name, description, false)
expect(current_path).to eq project_feature_flags_path(project)
expect(current_path).to eq project_feature_flag_path(project)
expect(page).to have_selector '.alert-danger', text: error_message
end
end
......@@ -78,7 +79,7 @@ describe 'Feature Flags', :js do
it 'displays an error message' do
edit_feature_flag('feature-flag-to-edit', name, description, false)
expect(current_path).to eq project_feature_flags_path(project)
expect(current_path).to eq project_feature_flag_path(project)
expect(page).to have_selector '.alert-danger', text: error_message
end
end
......
......@@ -57,7 +57,7 @@ project:
- vulnerability_identifiers
- vulnerability_scanners
- operations_feature_flags
- operations_feature_flags_instance
- operations_feature_flags_client
- prometheus_alerts
- prometheus_alert_events
- software_license_policies
......
......@@ -88,7 +88,7 @@ describe API::Unleash do
it 'matches json schema' do
subject
expect(response).to have_gitlab_http_status(:ok)
expect(response).to match_response_schema('unleash/unleash', dir: 'ee')
end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment