- 11 May, 2018 17 commits
-
-
Douwe Maan authored
Resolve "[Rails5] Fix `NoMethodError: undefined method `-' for "3":String`" Closes #46233 See merge request gitlab-org/gitlab-ce!18892
-
Douwe Maan authored
Resolve "[Rails5] Fix `Route source can't be blank`" Closes #46228 See merge request gitlab-org/gitlab-ce!18890
-
Douwe Maan authored
Resolve "[Rails5] Fix app/views/groups/issues.html.haml" Closes #46225 See merge request gitlab-org/gitlab-ce!18889
-
Tim Zallmann authored
Support `js-close` as a removal class in UserCallout See merge request gitlab-org/gitlab-ce!18790
-
Lukas Eipert authored
-
Filipa Lacerda authored
Fixed none merge request files not being openable in the web IDE See merge request gitlab-org/gitlab-ce!18881
-
Kamil Trzciński authored
Backport EE specific cluster spec changes to CE See merge request gitlab-org/gitlab-ce!18866
-
Kamil Trzciński authored
Add missing tooltip to creation date on container registry overview Closes #34229 See merge request gitlab-org/gitlab-ce!18767
-
Kamil Trzciński authored
Remove method call to deprecated method See merge request gitlab-org/gitlab-ce!18815
-
Kamil Trzciński authored
Ensure runner_type is updated correctly when assigning shared runner to project See merge request gitlab-org/gitlab-ce!18874
-
Tim Zallmann authored
Resolve "Terms acceptance dropdown menu" Closes #46210 See merge request gitlab-org/gitlab-ce!18862
-
Phil Hughes authored
Resolve "Move external link icon to end of link instead of front" Closes #40725 See merge request gitlab-org/gitlab-ce!18828
-
Achilleas Pipinellis authored
Add documentation for Runner Registration API Closes #42067 See merge request gitlab-org/gitlab-ce!16484
-
Achilleas Pipinellis authored
CE: Helm init before helm repo add See merge request gitlab-org/gitlab-ce!18882
-
Zeger-Jan van de Weg authored
Given the settings initializer creates Gitaly Storage Settings objects already, the calls to path can be moved to that initializer.
-
blackst0ne authored
In Rails 5 the `per_page` argument came from `params` is String but an Integer is expected. This commit explicitly converts `per_page` to an Integer. It fixes the errors like: ``` 1) Groups::ChildrenController GET #index for subgroups filtering children succeeds if multiple pages contain matching subgroups Failure/Error: hash[page] = second_collection.page(second_collection_page) .per(per_page - paginated_first_collection(page).size) .padding(offset) NoMethodError: undefined method `-' for "3":String Did you mean? -@ # ./lib/gitlab/multi_collection_paginator.rb:42:in `block in paginated_second_collection' # ./lib/gitlab/multi_collection_paginator.rb:46:in `paginated_second_collection' # ./lib/gitlab/multi_collection_paginator.rb:14:in `paginate' # ./app/finders/group_descendants_finder.rb:52:in `children' # ./app/finders/group_descendants_finder.rb:34:in `execute' # ./app/controllers/groups/children_controller.rb:36:in `setup_children' # ./app/controllers/groups/children_controller.rb:18:in `index' # ./lib/gitlab/i18n.rb:50:in `with_locale' # ./lib/gitlab/i18n.rb:56:in `with_user_locale' # ./app/controllers/application_controller.rb:351:in `set_locale' # ./spec/controllers/groups/children_controller_spec.rb:182:in `block (5 levels) in <top (required)>' # ./spec/spec_helper.rb:198:in `block (2 levels) in <top (required)>' ```
-
blackst0ne authored
In Rails 5.0 automatic inverse does not work for polymorphic relathionships. It was fixed in Rails 5.2: https://github.com/rails/rails/pull/28808 Until that the `inverse_of: :source` argument should be set explicitly.
-
- 10 May, 2018 23 commits
-
-
blackst0ne authored
Fixes the errors like: ``` ActionView::Template::Error: Attempting to generate a URL from non-sanitized request parameters! An attacker can inject malicious data into the generated URL, such as changing the host. Whitelist and sanitize passed parameters to be secure. ```
-
Clement Ho authored
Resolve "Wiki headings no longer show anchor link" Closes #44956 See merge request gitlab-org/gitlab-ce!18591
-
Stan Hu authored
ShaAttribute crashes with ArgumentError if column doesn't exist See merge request gitlab-org/gitlab-ce!18880
-
Maxime authored
-
Robert Speicher authored
Update gon ~> 6.1.0 to ~> 6.2 See merge request gitlab-org/gitlab-ce!18764
-
Phil Hughes authored
-
Brett Walker authored
-
Mark Fletcher authored
- Document Registation - POST `/runners/` - Document Deletion - DELETE `/runners/` - Document Verification - POST `/runners/verify/
-
Robert Speicher authored
Fix finding wiki pages when they have invalidly-encoded content Closes #43715 See merge request gitlab-org/gitlab-ce!18856
-
Filipa Lacerda authored
Hide merge request option in IDE when merge requests are disabled Closes #45698 See merge request gitlab-org/gitlab-ce!18857
-
Tim Zallmann authored
Fix outdated web ide copy See merge request gitlab-org/gitlab-ce!18861
-
Nick Thomas authored
Merge branch '41229-include-the-human-repo-name-in-gitlab-shell-log-when-hashed-storage-is-in-use' into 'master' Resolve "Include the human repo name in gitlab-shell.log when hashed storage is in use" Closes #41229 See merge request gitlab-org/gitlab-ce!18870
-
James Ramsay authored
-
Nick Thomas authored
Support resetting of Prometheus metrics between test runs Closes #39968 See merge request gitlab-org/gitlab-ce!18836
-
Dmitriy Zaporozhets authored
Remove accidental EE additions in CE See merge request gitlab-org/gitlab-ce!18877
-
Phil Hughes authored
-
Grzegorz Bizon authored
Improve fix for intermittent QA failure in "cloning code using a deploy key" Closes charts/gitlab#396 See merge request gitlab-org/gitlab-ce!18608
-
Dylan Griffith authored
-
Dylan Griffith authored
-
James Edwards-Jones authored
-
Douwe Maan authored
Resolve "Update `updated_at` on an issue when label or time spent was added" Closes #45442 See merge request gitlab-org/gitlab-ce!18757
-
Douwe Maan authored
[CE] Backport with_forgery_protection spec helper See merge request gitlab-org/gitlab-ce!18833
-
Douwe Maan authored
Backport some changes from gitlab-ee!5476 See merge request gitlab-org/gitlab-ce!18760
-