- 08 Oct, 2018 40 commits
-
-
Mark Lapierre authored
If SIGNUP_DISABLED is true skip any tests with a context :skip_signup_disabled. The context is set for the registration tests. This allows the tests to be skipped when run on the staging, which doesn't allow registration
-
Clement Ho authored
Remove duplicate button from the markdown header toolbar See merge request gitlab-org/gitlab-ce!22192
-
George Tsiolis authored
-
Filipa Lacerda authored
Resolve "Pipeline graph is not vertically aligned in commit page" Closes #52193 See merge request gitlab-org/gitlab-ce!22173
-
Robert Speicher authored
Fix comments in app/models/note.rb See merge request gitlab-org/gitlab-ce!22171
-
Johann Hubert Sonntagbauer authored
-
Achilleas Pipinellis authored
Update installation and update docs for 11 4 See merge request gitlab-org/gitlab-ce!22030
-
Thiago Presa authored
-
Dmitriy Zaporozhets authored
Clean up ActiveRecord code in TodosFinder and TodoService See merge request gitlab-org/gitlab-ce!21838
-
Achilleas Pipinellis authored
Add note in docs for docker executor for interactive web terminal See merge request gitlab-org/gitlab-ce!21880
-
Achilleas Pipinellis authored
Fix links to auth resources external to docs See merge request gitlab-org/gitlab-ce!22180
-
Yorick Peterse authored
This refactors the TodoService class according to our code reuse guidelines. The resulting code is a wee bit more verbose, but it allows us to decouple the column names from the input, resulting in fewer changes being necessary when we change the schema. One particular noteworthy line in TodoService is the following: todos_ids = todos.update_state(state) Technically this is a violation of the guidelines, because `update_state` is a class method, which services are not supposed to use (safe for a few allowed ones). I decided to keep this, since there is no alternative. `update_state` doesn't produce a relation so it doesn't belong in a Finder, and we can't move it to another Service either. As such I opted to just use the method directly. Cases like this may happen more frequently, at which point we should update our documentation with some sort of recommendation. For now, I want to refrain from doing so until we have a few more examples.
-
Yorick Peterse authored
This refactors the TodosFinder finder according to the new code reuse rules, as enforced by the CodeReuse cops. I also changed some of the methods to use regular if statements, instead of assignments and/or early returns. This results in a more natural flow when reading the code, and it makes it harder to accidentally return the wrong result.
-
Rémy Coutable authored
docs: cleanup term settings wording See merge request gitlab-org/gitlab-ce!22162
-
Achilleas Pipinellis authored
Replace old "secret variables" image for variables with new "variables" image See merge request gitlab-org/gitlab-ce!22184
-
Grzegorz Bizon authored
Redirect to the pipeline builds page when a build is canceled Closes #39161 See merge request gitlab-org/gitlab-ce!21595
-
Fatih Acet authored
Resolve "Merge request buttons spacing incorrect" Closes #48494 See merge request gitlab-org/gitlab-ce!22135
-
Jacques Erasmus authored
-
Achilleas Pipinellis authored
Docs - Prefilled fields for new issue link See merge request gitlab-org/gitlab-ce!22082
-
Victor Wu authored
-
Achilleas Pipinellis authored
Added note to clarify values for hook-name.d See merge request gitlab-org/gitlab-ce!22165
-
Grzegorz Bizon authored
Improve QA page README See merge request gitlab-org/gitlab-ce!22176
-
Achilleas Pipinellis authored
-
Achilleas Pipinellis authored
Update explanation about the `extends` feature See merge request gitlab-org/gitlab-ce!22043
-
Ronald van Zon authored
-
Achilleas Pipinellis authored
Add note about hostname *and* port needing to match for `DOCKER_AUTH_CONFIG` See merge request gitlab-org/gitlab-ce!22064
-
Achilleas Pipinellis authored
Fix link to EE-only doc and fix lint issues See merge request gitlab-org/gitlab-ce!22178
-
Achilleas Pipinellis authored
Fix link to MR-template and other improvements See merge request gitlab-org/gitlab-ce!22179
-
Achilleas Pipinellis authored
Fix indentation in GPG documentation See merge request gitlab-org/gitlab-ce!22132
-
Rémy Coutable authored
Enable more frozen string in lib/**/*.rb See merge request gitlab-org/gitlab-ce!22174
-
Douwe Maan authored
Rails 5: fix mysql milliseconds problems in scheduled build specs See merge request gitlab-org/gitlab-ce!22170
-
Kamil Trzciński authored
Update templates for 11.4 See merge request gitlab-org/gitlab-ce!22188
-
Douwe Maan authored
Prune events older than 2 years instead of 12 months See merge request gitlab-org/gitlab-ce!22145
-
Douwe Maan authored
Remove duplicate Sentry logging for GRPC exceptions See merge request gitlab-org/gitlab-ce!22187
-
Sean McGivern authored
Update licenses for 11.4 See merge request gitlab-org/gitlab-ce!22189
-
Rémy Coutable authored
Fix issues controller N+1 failure See merge request gitlab-org/gitlab-ce!22141
-
Kamil Trzciński authored
Updates Laravel.gitlab-ci.yml template See merge request gitlab-org/gitlab-ce!22167
-
Kamil Trzciński authored
Render log artifact files in GitLab See merge request gitlab-org/gitlab-ce!22112
-
Zeger-Jan van de Weg authored
-
Jan Provaznik authored
-