- 26 Jun, 2020 19 commits
-
-
Igor Drozdov authored
Allow overriding of project approvers in merge request See merge request gitlab-org/gitlab!34026
-
Stan Hu authored
Previously specifying blank `user_ids` and `group_ids` during the creation of a merge request approver rule would cause the merge request to inherit from the project rule. However, that prevents users from setting the merge request approvers to "any approver". To fix this, we only set the "any approver" type if `user_ids` and `group_ids` is not specified and no project approvers are present. In addition, this commit also fixes the approval rule type when project rule has users/groups. Suppose a project has an approval rule that includes specific users or groups as approvers. If a user attempts to create a merge request approval rule based on this project rule but omits `user_ids` and `group_ids`, previously this rule would be erroneously assigned "any approver". However, the project approvers should be inherited. To fix this, we: 1. First copy the project approval rules. 2. If the newly-modified params indicate specific users or groups, don't assign the merge request rule the "any approver" type. Found while investigating failures in upgrading Grape v1.3.3 in https://gitlab.com/gitlab-org/gitlab/-/merge_requests/33450.
-
Ash McKenzie authored
Resolve "Ensure unit tests are run as part of backend changes to specs" Closes #224641 See merge request gitlab-org/gitlab!35408
-
Heinrich Lee Yu authored
Revert "Merge branch '221259-improve-package-factories' into 'master'" See merge request gitlab-org/gitlab!35407
-
Achilleas Pipinellis authored
Cosmetic markdown fixes on policy/maintenance.html See merge request gitlab-org/gitlab!34019
-
Albert Salim authored
-
Martin Wortschack authored
Remove prepend-top-default CSS class See merge request gitlab-org/gitlab!35263
-
Ash McKenzie authored
This reverts merge request !35128
-
Evan Read authored
Update docs for Helm app for local Tiller See merge request gitlab-org/gitlab!30671
-
Hordur Freyr Yngvason authored
-
Marcel Amirault authored
Docs: Fixed broken links Closes #223269 See merge request gitlab-org/gitlab!35386
-
Suzanne Selhorn authored
There is a job that reports broken external links. This MR fixes several of them.
-
Evan Read authored
Docs: Added fake URL guidance See merge request gitlab-org/gitlab!35267
-
Suzanne Selhorn authored
Because we don't formally call out the fake domain names we use
-
Paul Slaughter authored
Resolve "Merge request approval button style inadvertently changed" Closes #29151 and #224139 See merge request gitlab-org/gitlab!35213
-
-
Evan Read authored
Include link to blockquotes section from Alerts Closes #216615 See merge request gitlab-org/gitlab!35339
-
Mike Jang authored
-
Ash McKenzie authored
Improve package factories See merge request gitlab-org/gitlab!35128
-
- 25 Jun, 2020 21 commits
-
-
Evan Read authored
Docs: Redo of Releases page Closes #220842 See merge request gitlab-org/gitlab!34967
-
Suzanne Selhorn authored
Removed several screenshots, changed capitalization, Changed topics to be task-based, and added to intro. Related to: https://gitlab.com/gitlab-org/gitlab/-/issues/220842
-
Marcel Amirault authored
JenkinsFile Wrapper: fix incomplete sentence on public testing See merge request gitlab-org/gitlab!35326
-
Thao Yeager authored
-
Robert Speicher authored
Merge branch '220944-docs-product-feedback-example-for-set-a-deploy-freeze-seems-wrong' into 'master' Move CI_DEPLOY_FREEZE variable calculation to pipeline Closes #220944 See merge request gitlab-org/gitlab!35226
-
Sean Carroll authored
Closes https://gitlab.com/gitlab-org/gitlab/issues/220944 See merge request https://gitlab.com/gitlab-org/gitlab/merge_requests/35226
-
Bob Van Landuyt authored
Move API::Runner and API::Runners to Ci namespace See merge request gitlab-org/gitlab!35191
-
Allison Browne authored
API::Runners => API::Ci::Runners
-
Douglas Barbosa Alexandre authored
Optimize issues_with_health_status usage ping counter Closes #223709 See merge request gitlab-org/gitlab!35298
-
Mayra Cabrera authored
Fix off-by-one expectation and simplify partitioning specs a little See merge request gitlab-org/gitlab!35322
-
Andreas Brandl authored
-
Mike Greiling authored
Merge branch '213154-re-submitting-an-epic-filter-on-the-issues-search-bar-prepends-an-before-the-id' into 'master' Fix failing filtered search when re-submitting epic tokens Closes #213154 See merge request gitlab-org/gitlab!35205
-
Axel Garcia authored
Fixes https://gitlab.com/gitlab-org/gitlab/-/issues/213154. This adds the & token to the prefixed-tokens regex/array so the symbol gets stripped when processed. Involves a bit of refactoring to improve readability.
-
Paul Slaughter authored
Fix styling bug for disabled merge button See merge request gitlab-org/gitlab!35365
-
Wayne Haber authored
Update title to include readability See merge request gitlab-org/gitlab!35354
-
Wayne Haber authored
-
Bob Van Landuyt authored
Add storage_size_limit to plan_limits table See merge request gitlab-org/gitlab!35219
-
Shreyas Agarwal authored
-
Suzanne Selhorn authored
Add note for expired image garbage collection See merge request gitlab-org/gitlab!35039
-
Tim Poffenbarger authored
-
Suzanne Selhorn authored
Remove variables that are not predefined Closes #214764 See merge request gitlab-org/gitlab!35307
-