So that we could limit the access to Repository#fetch_ref
See: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/13416#note_37487433

* 36089-handle-ref-failure-better:
  Skip creating the merge request if repo is empty
  Just use repository would fix the test
  Since now fetch_ref is reliable, we could just rely on it
  Just use the repo. Not sure why master could pass
  Fix more tests
  Don't try to create diffs if one of the branch is missing
  Try to show exception information in the test
  Introduce MergeRequest#write_ref and Repository#write_ref
  Avoid ambiguity, which happened in a single test run
  Just detect exit status rather than check ref
  Fix some tests and report the error message
  Fake out Repository#fetch_ref for merge request if
  Detect if we didn't create the ref sooner

Fix: When MR approvals are disabled, but approvers were previously assigned

Closes #3104

See merge request !2647

[EE] Detect and keep track of flaky specs

See merge request !2626

Fix: When MR approvals are disabled, but approvers were previously assigned, all approvers receive a notification on every MR

Signed-off-by: Rémy Coutable <remy@rymai.me>

[EE] Enable the RSpec/HookArgument cop and auto-correct offenses

See merge request !2656

Fix typo for `required` attribute for Integration settings password fields

Closes #2955

See merge request !2659

Future proof migration spec from irrelevant failures

Closes #3102

See merge request !2635

CE Upstream: Friday

See merge request !2658

* upstream/master: (22 commits)
  Docs: update user docs index
  Fix minor typos in views
  Fix Layout/SpaceBeforeBlockBraces violation in bin/changelog_spec
  Merge branch 'rs-alphanumeric-ssh-params' into 'security-9-4'
  Merge branch 'import-symlinks-9-3' into 'security-9-3'
  Fix wrong method call on prometheus histogram
  Document new all-in-one Helm chart - docs
  removed global use of breakpoint checker
  Increase performance of the breakpoint size checker
  Filter sensitive query string parameters from NGINX access logs
  Fix and improve spec/controllers/autocomplete_controller_spec.rb
  Improve the Project factory to make `creator` defaults to namespace.owner
  Update CHANGELOG.md for 9.2.10
  Update CHANGELOG.md for 8.17.8
  Update CHANGELOG.md for 9.0.13
  Update CHANGELOG.md for 9.1.10
  Update CHANGELOG.md for 9.3.10
  Update CHANGELOG.md for 9.4.4
  Update nfs.md with information on AWS EFS and Burst Credit usage and how to increase Burst Credit limits and also limit the need for AWS to access EFS by using FS Cache.
  Manually assign `notification_email` in the User factory when stubbed
  ...

Fix minor typos in views

Closes #36317

See merge request !13487

Docs: update user docs index

See merge request !13471

Closes #36317.

Resolve "Change HA docs to update using EFS as NFS"

Closes #36192

See merge request !13400

Security release 2017-08-10 patch

See merge request !13477

RuboCop is _living_ documentation! ✨

[ci skip]

Filter sensitive query string parameters from NGINX access logs

Closes #19203

See merge request !13453

Let's start labeling our CHANGELOG entries

Closes #21949

See merge request !11579

[EE] Improve the Project factory to make `creator` defaults to `namespace.owner`

See merge request !2651

Improve the Project factory to make `creator` defaults to `namespace.owner`

See merge request !13412

Fix alignment of deploy board toggle; hide deploy boards on mobile

Closes #2802

See merge request !2646

Increase performance of the breakpoint size checker

See merge request !13454

Fix wrong method call on prometheus histogram

See merge request !13470

Ensure user and hostnames begin with an alnum character in UrlBlocker

See merge request !2138

Fix file disclosure via hidden symlinks using the project import (9.3)

See merge request !2164

Manually assign `notification_email` in the User factory when stubbed

See merge request !13395

…to take advantage of `reset_column_in_migration_models` in `spec/support/migrations_helpers.rb` to ensure surrounding specs can’t break this one.

CE upstream: Thursday

See merge request !2654

Document new all-in-one Helm chart - docs

Closes #36039

See merge request !13333