- 30 Dec, 2020 10 commits
-
-
Sean McGivern authored
Previously, requests using a token that only had read_api access would be treated as unauthenticated by the rate limiter. This ensures that they are (correctly) treated as authenticated. This does point to a general problem with the rate limiting code: because it happens in a middleware before any application code, it's hard to keep in sync with the different authentication methods the application may allow. This applies to things like: 1. How the credentials are sent (Private-Token header, Authorization header, basic auth, etc.). 2. What credentials we accept (a personal access token, a personal access token with read_api scope, a job token, a deploy token, etc.). 3. Which endpoints those apply to. The last one is mostly a concern for performance: we might pre-emptively try authenticating using a method that isn't valid for a particular endpoint. From a rate limiting perspective it doesn't matter so much, as we're treating a request with valid credentials for a different endpoint as authenticated for the current endpoint, which is wrong but not a significant problem.
-
Alper Akgun authored
Introduce dismissal reason for vulnerability feedback See merge request gitlab-org/gitlab!50632
-
Mehmet Emin INAC authored
-
Ramya Authappan authored
Stablize register spec See merge request gitlab-org/gitlab!50675
-
Olena Horal-Koretska authored
Migrate to native window scrolling See merge request gitlab-org/gitlab!43167
-
Lukas 'Eipi' Eipert authored
We can replace jquery.scrollTo.js with commonUtils scrollToElement or native browser scrolling.
-
Sanad Liaquat (Personal) authored
-
Ramya Authappan authored
Quarantine flaky default branch name setting spec See merge request gitlab-org/gitlab!50645
-
Ramya Authappan authored
Fix project export audit log spec See merge request gitlab-org/gitlab!50644
-
Sanad Liaquat authored
-
- 29 Dec, 2020 30 commits
-
-
Ash McKenzie authored
Add Packages::Debian::GetOrCreateIncomingService See merge request gitlab-org/gitlab!50431
-
Russell Dickenson authored
Minor API readme style updates See merge request gitlab-org/gitlab!50670
-
Thong Kuah authored
[RUN ALL RSPEC] Deprecations job See merge request gitlab-org/gitlab!49792
-
Russell Dickenson authored
Update Cohorts page to improve style See merge request gitlab-org/gitlab!50668
-
Craig Norris authored
Fixes several style and wording items.
-
Craig Norris authored
Incorporated several style updates to page.
-
Achilleas Pipinellis authored
Change CE to EE See merge request gitlab-org/gitlab!50656
-
Achilleas Pipinellis authored
Additional style and wording updates from recent Install change See merge request gitlab-org/gitlab!50620
-
Achilleas Pipinellis authored
Improve GraphQL style guide docs See merge request gitlab-org/gitlab!50641
-
Achilleas Pipinellis authored
Remove tier badging from doc links on index page See merge request gitlab-org/gitlab!50637
-
Joshua Lambert authored
-
Sean McGivern authored
Configure sampler intervals via environment variables See merge request gitlab-org/gitlab!50625
-
Matthias Käppler authored
This is useful for development but also to more easily change these values in production.
-
Christopher Lefelhocz authored
Update language re. docs for disabled FFs See merge request gitlab-org/gitlab!47917
-
John Hope authored
-
Igor Drozdov authored
Increase the diff limit See merge request gitlab-org/gitlab!50572
-
Dmytro Zaporozhets (DZ) authored
Minor typo on the "Renaming queues" See merge request gitlab-org/gitlab!50643
-
Mathieu Parent authored
-
Sean McGivern authored
Creates new on-demand scans routes See merge request gitlab-org/gitlab!50469
-
Sean McGivern authored
Add a quick action for /rebase See merge request gitlab-org/gitlab!49800
-
Sean McGivern authored
Add the NuGet group level API See merge request gitlab-org/gitlab!48356
-
David Fernandez authored
Re using the shareable nuget endpoint Add related specs
-
Sean McGivern authored
Resolve "OnboardingUserAddedWorker fails frequently" See merge request gitlab-org/gitlab!50622
-
Sean McGivern authored
Remove users#show.json completely See merge request gitlab-org/gitlab!49670
-
Alper Akgun authored
Refactor coverage report service See merge request gitlab-org/gitlab!50424
-
Maxime Orefice authored
This commit refators our coverage report service to prepare our new codequality service which will be introduced in a follow up.
-
Sanad Liaquat (Personal) authored
-
Alper Akgun authored
-
Russell Dickenson authored
Copy vulnerability level details from handbook page to docs See merge request gitlab-org/gitlab!49581
-
Sam Kerr authored
-