An error occurred fetching the project authors.
- 19 Mar, 2019 2 commits
-
-
Mario de la Ossa authored
-
Mario de la Ossa authored
We avoid a Gitaly N+1 by passing a hash to Gitlab::Git::Commit instead of loading the commits via Gitaly. We also change Gitlab::Git::Commit to have a lazy_load_parents option that allows us not to load parent_ids unless necessary
-
- 18 Mar, 2019 1 commit
-
-
Luke Duncalfe authored
Allow incomplete commit records to load their full data from gitaly. Commits can be based on a Hash of data retrieved from PostgreSQL, and this data can be intentionally incomplete in order to save space. A new method #gitaly? has been added to Gitlab::Git::Commit, which returns true if the underlying data source of the Commit is a Gitaly::GitCommit. CommitCollection now has a method #enrich which replaces non-gitaly commits in place with commits from gitaly. CommitCollection#without_merge_commits has been updated to call this method, as in order to determine a merge commit we need to have parent data. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/58805
-
- 09 Mar, 2019 1 commit
-
-
Stan Hu authored
This brings back some of the changes in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/20176/diffs. We discovered another N+1 that hits Gitaly `TreeEntry` via the `RelativeLinkFilter`: https://gitlab.com/gitlab-org/gitlab-ce/issues/58657. When a blob is loaded with many relative links, `TreeEntry` is called for each link to scan the URI type. There are multiple paths that hit Gitaly `TreeEntry`, and https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/25706 did not cover all cases. This commit covers another common use case. For users using Gitaly on top of NFS, accessing the Git data directly via Rugged may be faster than going through than Gitaly. This merge request introduces the feature flag `rugged_commit_tree_entry` to activate the Rugged method.
-
- 06 Mar, 2019 2 commits
-
-
Andrew Newdigate authored
This style change enforces `return if ...` instead of `return nil if ...` to save maintainers a few minor review points. Style change discussed in https://gitlab.com/gitlab-org/gitlab-ce/issues/57454
-
Andrew Newdigate authored
This style change enforces `return if ...` instead of `return nil if ...` to save maintainers a few minor review points
-
- 01 Mar, 2019 1 commit
-
-
Stan Hu authored
This brings back some of the changes in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/20339. For users using Gitaly on top of NFS, accessing the Git data directly via Rugged is more performant than Gitaly. This merge request introduces the feature flag `rugged_find_commit` to activate Rugged paths. There are also Rake tasks `gitlab:features:enable_rugged` and `gitlab:features:disable_rugged` to enable/disable these feature flags altogether. Part of four Rugged changes identified in https://gitlab.com/gitlab-org/gitlab-ce/issues/57317.
-
- 26 Nov, 2018 1 commit
-
-
Douwe Maan authored
By specifying `key`, we get a different lazy batch loader for each repository, which means that accessing a lazy object from one repository will only result in that repository's objects being fetched, not those of other repositories, saving us some unnecessary Gitaly lookups.
-
- 13 Nov, 2018 1 commit
-
-
gfyoung authored
Enables frozen string for the following: * lib/gitlab/fogbugz_import/**/*.rb * lib/gitlab/gfm/**/*.rb * lib/gitlab/git/**/*.rb * lib/gitlab/gitaly_client/**/*.rb * lib/gitlab/gitlab_import/**/*.rb * lib/gitlab/google_code_import/**/*.rb * lib/gitlab/gpg/**/*.rb * lib/gitlab/grape_logging/**/*.rb * lib/gitlab/graphql/**/*.rb * lib/gitlab/graphs/**/*.rb * lib/gitlab/hashed_storage/**/*.rb * lib/gitlab/health_checks/**/*.rb Partially address gitlab-org/gitlab-ce#47424.
-
- 30 Oct, 2018 1 commit
-
-
Bob Van Landuyt authored
Having this in a concern allows us to reuse it for different single purpose classes that call out to git without going through the repository every time.
-
- 02 Oct, 2018 2 commits
-
-
Alejandro Rodríguez authored
Cleanup code, and refactor tests that still use Rugged. After this, there should be no Rugged code that access the instance's repositories on non-test environments. There is still some rugged code for other tasks like the repository import task, but since it doesn't access any repository storage path it can stay.
-
Alejandro Rodríguez authored
Cleanup code, and refactor tests that still use Rugged. After this, there should be no Rugged code that access the instance's repositories on non-test environments. There is still some rugged code for other tasks like the repository import task, but since it doesn't access any repository storage path it can stay.
-
- 18 Jul, 2018 2 commits
-
-
Jacob Vosmaer (GitLab) authored
-
Jacob Vosmaer (GitLab) authored
-
- 06 Jul, 2018 2 commits
-
-
Jacob Vosmaer authored
-
Jacob Vosmaer authored
This partially reverts commit 64dfe2cb.
-
- 05 Jul, 2018 2 commits
-
-
Jacob Vosmaer (GitLab) authored
This reverts merge request !20339
-
Jacob Vosmaer (GitLab) authored
This reverts merge request !20339
-
- 04 Jul, 2018 1 commit
-
-
Jacob Vosmaer (GitLab) authored
-
- 28 Jun, 2018 2 commits
-
-
Zeger-Jan van de Weg authored
Closes https://gitlab.com/gitlab-org/gitaly/issues/326
-
Zeger-Jan van de Weg authored
Prior to this change, most the commits counted were done through Gitaly. This removes the last point where this wasn't the case. This makes the `rugged_count_commits` method obsolete, with its tests. Closes https://gitlab.com/gitlab-org/gitaly/issues/315
-
- 27 Jun, 2018 2 commits
-
-
Jacob Vosmaer authored
-
Jacob Vosmaer authored
-
- 26 Jun, 2018 1 commit
-
-
Jacob Vosmaer authored
-
- 22 Jun, 2018 1 commit
-
-
Zeger-Jan van de Weg authored
Closes https://gitlab.com/gitlab-org/gitaly/issues/222
-
- 06 Jun, 2018 2 commits
-
-
Jacob Vosmaer authored
-
Zeger-Jan van de Weg authored
Gitaly itself hold very little state, other than the data on disk. This limits the interfaces to set feature flags. Gitaly now has the ability to interpret the request metadata to check for feature flags. https://gitlab.com/gitlab-org/gitaly/merge_requests/704 This allows clients control on the Gitaly server, and given that Rails has an internal chatops interface to set these values this was chosen as solution. Known limitation right now, is that this package doesn't support the opt out that other Gitaly features do.
-
- 18 May, 2018 1 commit
-
-
Ahmad Sherif authored
-
- 16 May, 2018 1 commit
-
-
Zeger-Jan van de Weg authored
Prior to this change, this was done through unicorn. In theory this could time out. Workhorse has been sending these raw patches and diffs for a long time and is stable in doing so. Added bonus is the fact that `Commit#to_patch` can be removed. `Commit#to_diff` too, which closes https://gitlab.com/gitlab-org/gitaly/issues/324 Closes https://gitlab.com/gitlab-org/gitaly/issues/1196
-
- 17 Apr, 2018 1 commit
-
-
Zeger-Jan van de Weg authored
The execution path wasn't clear from the error, but either way this is a fix. Closes gitlab-org/gitaly#1115
-
- 04 Apr, 2018 1 commit
-
-
Zeger-Jan van de Weg authored
Acceptence testing was successfull in [#844](https://gitlab.com/gitlab-org/gitaly/issues/844) Part of gitlab-org/gitaly#670
-
- 07 Mar, 2018 1 commit
-
-
Zeger-Jan van de Weg authored
Part of gitlab-org/gitaly#324
-
- 01 Mar, 2018 1 commit
-
-
Ahmad Sherif authored
Closes gitaly#1046
-
- 19 Feb, 2018 1 commit
-
-
Sean McGivern authored
The tracking issue if this causes problems is https://gitlab.com/gitlab-org/gitaly/issues/1028
-
- 16 Feb, 2018 2 commits
-
-
Micaël Bergeron authored
# modified: lib/gitlab/git/commit.rb
-
Micaël Bergeron authored
-
- 07 Feb, 2018 1 commit
-
-
Zeger-Jan van de Weg authored
The refs hash is used to determine what branches and tags have a commit as head in the network graph. The previous implementation depended on Rugged#references. The problem with this implementation was that it depended on rugged, but also that it iterated over all references and thus loading more data than needed if for example the project uses CI/CD environments, Pipelines, or Merge Requests. Given only refs are checked the network cares about the GraphHelper#refs method has no need to reject those, simplifying the method. Closes gitlab-org/gitaly#880
-
- 18 Jan, 2018 1 commit
-
-
Jacob Vosmaer (GitLab) authored
-
- 15 Jan, 2018 1 commit
-
-
Ahmad Sherif authored
Closes gitaly#915
-
- 04 Jan, 2018 1 commit
-
-
Jacob Vosmaer authored
-