Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/10156#note_26812609

reduce variables definitions. Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/10156#note_26811996

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/10156#note_26812377

* upstream/master: (238 commits)
  Periodically clean up temporary upload files to recover storage space
  Add a name field to the group edit form
  Remove the User#is_admin? method
  Fix specs
  Enable RSpec/DescribeSymbol; update .rubocop_todo.yml
  Update rubocop-rspec 1.12.0 -> 1.15.0
  Rename displaying_blame to blame
  Actually include WaitForAjax!
  Don't show Copy contents button on Blame page
  alfredo review changes
  Give explicit height to SVG icons for Safari
  Update MR title change icon
  Put back usernames in activity and profile feed
  Wait for AJAX requests to complete so they don't blow up if they are only handled after DatabaseCleaner has already run
  Revert yarn.lock changes
  add CHANGELOG.md entry for !10522
  upgrade webpack-dev-server to fix issues with SockJS causing odd reload behavior in firefox
  upgrade webpack to v2.3.3 to resolve sourcemap issues
  Rever yarn.lock changes
  Revert yarn.lock file changes
  ...

Clean carrierwave tempfiles

Closes #28540

See merge request !9466

Refactor javascript behaviors directory

See merge request !10439

Remove the `User#is_admin?` method

Closes #30584

See merge request !10520

Add a name field to the group edit form

See merge request !10502

Enables user specification of group name vs. name inferred from group path.

Cause new group form to copy name from path

Adds some new page-specific javascript that copies entry from the
group path field to the group name field when the group name field
is initially empty.

Remove duplicate group name entry field on group edit form

This corrects the duplicated name entry field and tests that the
JavaScript does not update the group name field if the user
edits the group path.  (Editing the group path is not recommended
in any case, but it is possible.)

Address eslint errors in group.js

Enable group name copy with dispatch and explore group creation

The dispatch and explore group creation forms require the group.js
asset, and their tests now require testing against poltergeist

Update workflow new group instruction

Update the gitlab basics group creation document

Add a change log entry

Remove unused variable for eslint

Add option to start a new resolvable discussion in an MR

Closes #24378

See merge request !7527

Update rubocop-rspec 1.12.0 -> 1.15.0

See merge request !10561

Don't show Copy contents button on Blame page

See merge request !10560

Clarify what an MR needs to be 'with' a maintainer

See merge request !10544

Give explicit height to SVG icons for Safari

See merge request !10550

Wait for AJAX requests to complete so they don't blow up if they are only handle…

Closes #30633

See merge request !10559

Add indication for closed or merged issuables in GFM

Closes #1369

See merge request !9462

Put back usernames in activity and profile feed

See merge request !10539

Add rake task that prints TOML storage configuration

Closes gitaly#173

See merge request !10448

Upgrade webpack and webpack-dev-server to latest

Closes #30588 and #28438

See merge request !10552

Update MR title change icon

See merge request !10540

Wait for AJAX requests to complete so they don't blow up if they are only handled after DatabaseCleaner has already run

Revert yarn.lock file changes

Closes #30627

See merge request !10558

https://github.com/webpack/webpack-dev-server/issues/762