An error occurred fetching the project authors.
- 25 Aug, 2021 1 commit
-
-
Peter Leitzen authored
`StatusPage::PublishedIncident#track` used `safe_find_or_create_by` to circumvent a potential race condition in case of a duplicate published issue. This, however, uses subtransactions under the hood which is problematic in nested transactions. See https://gitlab.com/groups/gitlab-org/-/epics/6540 for more context. In the rare event of `ActiveRecord::RecordNotUnique` users end up seeing a meaningful error message. This behaviour is acceptable and that's why switched to unsafe method `find_or_create_by`.
-
- 03 Jun, 2020 1 commit
-
-
Arturo Herrero authored
The plan for RSpec 4.0 is to disable monkey patching: https://rspec.info/blog/2013/07/the-plan-for-rspec-3/#zero-monkey-patching-mode This commit stops using RSpec monkey patching: https://relishapp.com/rspec/rspec-core/docs/configuration/zero-monkey-patching-mode
-
- 05 May, 2020 1 commit
-
-
syasonik authored
-
- 24 Apr, 2020 1 commit
-
-
syasonik authored
To support an ability to publish status page issues at a user's discretion, we want to store whether an issue has been published. This adds a table and model to represent a published incident.
-