- 21 Mar, 2019 3 commits
-
-
Luke Duncalfe authored
A project is needed in order to fetch data from gitaly. Projects can be absent from commits in certain rare situations (like when viewing a MR of a deleted fork). In these cases, assume that the enriched data is not needed. See this comment: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/26144#note_152191106 "It's led to a dilemma about where to "fix" this in code. I'm going to fix it by allowing CommitCollection#enrich! to just return unenriched commits when a project is missing, essentially "silently failing". I hope this is the right decision. It's going with the assumption that calls in these situations in the future are not needing the full data. The alternative would be to allow CommitCollection#enrich! to still error, but handle it in the methods that call #enrich!, however that might lead to brittleness in future when working with project-less MRs."
-
Luke Duncalfe authored
Previously the code for excluding merge commits from the commit collection (CommitCollection#without_merge_commits) was not working when the commits had come from a merge request. Now that this has been fixed, these tests fails. They should always have been written to exclude merge commits when comparing.
-
Luke Duncalfe authored
Allow incomplete commit records to load their full data from gitaly. Commits can be based on a Hash of data retrieved from PostgreSQL, and this data can be intentionally incomplete in order to save space. A new method #gitaly? has been added to Gitlab::Git::Commit, which returns true if the underlying data source of the Commit is a Gitaly::GitCommit. CommitCollection now has a method #enrich which replaces non-gitaly commits in place with commits from gitaly. CommitCollection#without_merge_commits has been updated to call this method, as in order to determine a merge commit we need to have parent data. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/58805
-
- 19 Mar, 2019 37 commits
-
-
Evan Read authored
Add documentation about Auto DevOps at group level Closes #58810 See merge request gitlab-org/gitlab-ce!26061
-
Mayra Cabrera authored
Includes a new section on our Auto Devops documentation about enabling or disabling Auto DevOps at group level. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/58810
-
Mike Greiling authored
Remove static JavaScript HAML fixtures Closes #24753 See merge request gitlab-org/gitlab-ce!26019
-
Kamil Trzciński authored
Only count active milestones as started Closes #58782 See merge request gitlab-org/gitlab-ce!25969
-
Evan Read authored
Docs: note some apps not installable in group level cluster See merge request gitlab-org/gitlab-ce!26249
-
Thong Kuah authored
As that is indeed available for group clusters.
-
Douglas Barbosa Alexandre authored
GitHub import: Create new branches as project owner See merge request gitlab-org/gitlab-ce!26335
-
Douglas Barbosa Alexandre authored
Reject HEAD requests to info/refs endpoint Closes #54579 See merge request gitlab-org/gitlab-ce!26334
-
Kamil Trzciński authored
Update pipeline detail view to accommodate post-merge pipelines See merge request gitlab-org/gitlab-ce!25775
-
Stan Hu authored
Send schema cache to Sentry on MissingAttributeError See merge request gitlab-org/gitlab-ce!26331
-
Stan Hu authored
In production, we see high error rates due to clients attempting to use the dumb Git HTTP protocol with HEAD /foo/bar.git/info/refs endpoint. This isn't supported and causes Error 500s because Workhorse doesn't send along its secret because it's not proxying this request. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/54579
-
Stan Hu authored
This avoids permission errors when importing merge requests whose authors don't have direct access to push to the main repository.
-
Phil Hughes authored
Removes EE differences for clusters/show Closes gitlab-ee#6354 See merge request gitlab-org/gitlab-ce!26324
-
Shinya Maeda authored
Commit changes Add spec Add changelog fix fix Fix Fix spec Finish spec ok nice ok ok ok fix
-
Winnie Hellmann authored
-
Winnie Hellmann authored
-
Winnie Hellmann authored
Replace all HAML fixtures with the generated HTML files.
-
Clement Ho authored
Update dependency @gitlab/ui to ^2.3.0 See merge request gitlab-org/gitlab-ce!26181
-
Lin Jen-Shin authored
Merge branch '58844-follow-up-from-don-t-create-ee-specific-files-when-creating-emojis-fixture-files' into 'master' Simplify JavaScriptFixturesHelpers Closes gitlab-ee#10386, #58898, and #58844 See merge request gitlab-org/gitlab-ce!26045
-
Sean McGivern authored
The Upcoming milestone filter only considers active milestones, but the Started one included closed milestones, too. This was inconsistent.
-
Nick Thomas authored
Backport EE JavaScript changes for SSH pull mirrors Closes #56340 See merge request gitlab-org/gitlab-ce!26308
-
Nick Thomas authored
Merge branch '59113-review-apps-initial-seeding-is-broken-due-to-runners_registration_token-openssl-cipher-ciphererror-error-somehow' into 'master' Fix the .review-deploy-base job so that env variables are passed Closes #59113 See merge request gitlab-org/gitlab-ce!26275
-
Sean McGivern authored
We don't know why this happens, so this is an attempt to debug the issue by sending a full list of all columns ActiveRecord knows about when the error is raised.
-
Dmitriy Zaporozhets authored
Add support for deleting images in registry 2.7 See merge request gitlab-org/gitlab-ce!25862
-
Achilleas Pipinellis authored
Document how Git object deduplication works in GitLab See merge request gitlab-org/gitlab-ce!25770
-
Jacob Vosmaer authored
-
Marcia Ramos authored
Docs: Bring HTML Style Guide in line with docs standards See merge request gitlab-org/gitlab-ce!26252
-
Marcel Amirault authored
-
Filipa Lacerda authored
Collapse diff tree is only one file is present Closes #53139 See merge request gitlab-org/gitlab-ce!26280
-
Phil Hughes authored
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/53139
-
Nick Thomas authored
Merge the gitlab-shell "gitlab-keys" functionality into GitLab CE Closes #56089 See merge request gitlab-org/gitlab-ce!25598
-
Patrick Bajao authored
In this commit, some methods that aren't being used are removed from `Gitlab::Shell`. They are the ff: - `#remove_keys_not_found_in_db` - `#batch_read_key_ids` - `#list_key_ids` The corresponding methods in `Gitlab::Keys` have been removed as well.
-
Filipa Lacerda authored
-
Lin Jen-Shin authored
Revert "New Repository#insights_config method" See merge request gitlab-org/gitlab-ce!26315
-
Sean McGivern authored
Add users search results to global search Closes #25973 See merge request gitlab-org/gitlab-ce!21197
-
Filipa Lacerda authored
Remove diff tree filtering feature flag See merge request gitlab-org/gitlab-ce!26273
-
Grzegorz Bizon authored
Make runners token encryption to be optional See merge request gitlab-org/gitlab-ce!26223
-