1. 26 May, 2016 6 commits
    • Jacob Schatz's avatar
      Merge branch 'discussion-outdated-form' into 'master' · 24b24aff
      Jacob Schatz authored
      Fixed JS error when trying to remove discussion form
      
      ## What does this MR do?
      
      Fixes a JS error which was caused by an ID of the form not matching what was returned by the JSON. Instead of checking that, it gets the current form from the ajax success event.
      
      This would only happen on outdated discussions because the ID of the discussion form ends with `-false` because it isn't active. However, the note is added to an active discussion so the ID returned actually ends in `-true` & therefore the JS couldn't find the correct form.
      
      ## What are the relevant issue numbers?
      
      Closes #17778
      
      See merge request !4303
      24b24aff
    • Jacob Schatz's avatar
      Merge branch 'link-to-in-issues-index' into 'master' · 44cc765a
      Jacob Schatz authored
      Replace `link_to_gfm` with `link_to` in merge request and issue titles.
      
      ## What does this MR do?
      This removed GitLab Markdown Formatting from issue titles due to issues and confusion it caused as well as performance reasons.
      
      On the issue/MR page itself, the formatting is preserved. This only effects index pages. See:
      
      ![Screen_Shot_2016-05-24_at_3.31.17_PM](/uploads/8857ed7f3cc6a47ea41ca88134e5d17a/Screen_Shot_2016-05-24_at_3.31.17_PM.png)
      
      I think the trade-off here is worth it, otherwise we'd just be playing wack-a-mole.
      
      ## Are there points in the code the reviewer needs to double check?
      I don't think so.
      
      ## Why was this MR needed?
      Previously if an issue had an emoji for its name it would be unclickable. Similarly, links were rendered inline if the title was something like “Fixes a bug with https://google.com”. This confused a number of users, so it’s removed.
      
      This is also ever so slightly more performant :)
      
      ## What are the relevant issue numbers?
      This fixes #17614 and #17230.
      
      ## Screenshots (if relevant)
      
      Before:
      
      ![Screen_Shot_2016-05-24_at_3.19.52_PM](/uploads/25313af3d3995a096b7bad7c5a26d071/Screen_Shot_2016-05-24_at_3.19.52_PM.png)
      
      After:
      
      ![Screen_Shot_2016-05-24_at_3.20.13_PM](/uploads/f14f09918001bcbac2cd939b016479b2/Screen_Shot_2016-05-24_at_3.20.13_PM.png)
      
      Before:
      
      ![Screen_Shot_2016-05-24_at_3.20.48_PM](/uploads/c183ae2c491650c328eb5768f6a55fd9/Screen_Shot_2016-05-24_at_3.20.48_PM.png)
      
      After:
      
      ![Screen_Shot_2016-05-24_at_3.20.42_PM](/uploads/d3431a691768bae2c5244b9b632061b9/Screen_Shot_2016-05-24_at_3.20.42_PM.png)
      
      cc: @rspeicher @jschatz1 
      
      See merge request !4284
      44cc765a
    • Phil Hughes's avatar
      Fixed JS error when trying to remove discussion form · d7bd7a3e
      Phil Hughes authored
      Closes #17778
      d7bd7a3e
    • Jacob Schatz's avatar
      Merge branch 'sidebar-expand-collapse' into 'master' · f2caad24
      Jacob Schatz authored
      Fix right sidebar expand/collapse issue
      
      Fixed branch name of the !4117
      
      
      ------------------
      
      Fixes #15643 
      
      - Fixed a typo in `toggleSidebar` method of `Sidebar` class.
      - Fixed a minor styling issue to fix the sidebar to the top of the page.
      - Added tests for Sidebar.
      
      
      ## Before
      ![before](/uploads/c4efe9a64e0ae35f423302753caa6dfd/sFBwnVEpQB.gif)
      
      ## After
      ![after](/uploads/23e6b80888dae475a385912c8c40bdbd/rerKiYC4dk.gif)
      
      
      See merge request !4292
      f2caad24
    • Fatih Acet's avatar
    • Dmitriy Zaporozhets's avatar
  2. 25 May, 2016 34 commits