- 23 Aug, 2019 40 commits
-
-
Stan Hu authored
Projects that have a pipeline may need to check whether the user has permission to read the build (`can?(current_user, :read_build, project)`), which requires checking the `project_features` table. This would cause an N+1 SQL query for each project. This change also has a beneficial side effect that may avoid a race condition. When a user deletes a project, the project is queued for deletion and the user is redirected back to the dashboard page. However, the following may happen: 1. The dashboard page may load this deleted project in the list of 20 projects. 2. The view will load the project pipeline status from the cache and attempt to show each project. 3. When the view encounters the deleted project, it calls `can?(current_user, :read_build, project)` to determine whether to display the pipeline status. 4. Sidekiq deletes the project from the database. 5. However, since the deleted project is still loaded in memory, it will attempt to call `project.project_feature.access_level`. 6. Since `project_feature` was not eager loaded, a lazy `SELECT` call is made to the database. 7. This `SELECT` call returns nothing, and the user sees a 500 error. By eager loading `project_feature`, we can ensure that we have a consistent view and avoid records from being deleted later. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66482
-
Kamil Trzciński authored
Add label_id parameter to label API for PUT and DELETE Closes #62322 See merge request gitlab-org/gitlab-ce!31804
-
Patrick Derichs authored
Add specs for new parameter and updated documentation as well.
-
Lin Jen-Shin authored
Handle when server info doesn't have the storage in question See merge request gitlab-org/gitlab-ce!32023
-
GitLab Release Tools Bot authored
[ci skip]
-
Kamil Trzciński authored
Eliminate Gitaly N+1 queries with notes API See merge request gitlab-org/gitlab-ce!32089
-
Walmyr Lima e Silva Filho authored
Quarantine filter issue comments test See merge request gitlab-org/gitlab-ce!32152
-
John Cai authored
-
Achilleas Pipinellis authored
Docs health check failure examples Closes #64193 See merge request gitlab-org/gitlab-ce!31945
-
Sean Arnold authored
-
Jan Provaznik authored
CE: Update sort options for issues list See merge request gitlab-org/gitlab-ce!31849
-
Walmyr Lima e Silva Filho authored
Fail E2E tests early if template not found via API See merge request gitlab-org/gitlab-ce!31955
-
Mark Lapierre authored
-
Walmyr Lima authored
-
Achilleas Pipinellis authored
62514 - update prometheus metrics docs Closes #62514 See merge request gitlab-org/gitlab-ce!31987
-
David Wilkins authored
- Strikeout for metrics that aren't reported anymore - added
👍 for all the metrics that appear to be still available - Added🆕 for the new metrics. - Determine Release when the new metrics appeared - Add descriptions for the new metrics - remove the adornments🆕 and👍 - removce the lines with strikeout -
Stan Hu authored
Reduce dedup calls to gc only See merge request gitlab-org/gitlab-ce!32083
-
Kushal Pandya authored
Hide duplicate board list while dragging See merge request gitlab-org/gitlab-ce!32099
-
Winnie Hellmann authored
-
Achilleas Pipinellis authored
Update dependencies api doc See merge request gitlab-org/gitlab-ce!32061
-
Tetiana Chupryna authored
-
Nick Thomas authored
Document uploads development guidelines Closes #63097 See merge request gitlab-org/gitlab-ce!31290
-
Alessio Caiazza authored
Explain Workhorse acceleration features
-
Nick Thomas authored
Add frozen_string_literal to lib part 2 See merge request gitlab-org/gitlab-ce!32094
-
Annabel Dunstone Gray authored
Resolve "Git clone URL box on Wiki git access page is broken" Closes #66022 See merge request gitlab-org/gitlab-ce!31898
-
Himanshu Kapoor authored
Some CSS fixes to fix the position of the git clone box on the wiki git access page. This fix also includes fixes for various responsive states.
-
Filipa Lacerda authored
fix charts scroll handle icon See merge request gitlab-org/gitlab-ce!31825
-
Laura Montemayor authored
-
Nick Thomas authored
Add Redis interceptor tracing See merge request gitlab-org/gitlab-ce!30238
-
Andrew Newdigate authored
This change adds Distributed Tracing support for two new types of events 1. Redis Calls 1. ActiveSupport (Rails) Caching Operations The intention is to help application developers and infrastructure SREs to understand the pressure that caching operations can have on the application when running at scale. The Redis and Caching spans can be viewed in the Jaeger UI by clicking the "Trace" link in the performance bar when running on GDK.
-
Grzegorz Bizon authored
Optimise UpdateBuildQueueService Closes #66438 See merge request gitlab-org/gitlab-ce!32095
-
Achilleas Pipinellis authored
Update documentation screenshot See merge request gitlab-org/gitlab-ce!31995
-
Samantha Ming authored
-
Achilleas Pipinellis authored
Add version 12 upgrade recommendations Closes #63907 See merge request gitlab-org/gitlab-ce!30201
-
Greg Myers authored
Updates doc/policy/maintenance.md, adds upgrade path from 11 -> 12
-
Achilleas Pipinellis authored
Update capitalization in /administration, /api, others See merge request gitlab-org/gitlab-ce!32136
-
Marcel Amirault authored
Update capitalization in /administration, /api, /ci and /customization
-
Alexandru Croitor authored
Increase sort options for issues list from updated_at and create_at, to include more options close to what is required in actual issue list UI. This helps us to use REST API for issues list with sorting capabilities https://gitlab.com/gitlab-org/gitlab-ce/issues/57402
-
Jan Provaznik authored
Exempt `jwt/auth` for user `gitlab-ci-token` from rate limiting Closes #49392 See merge request gitlab-org/gitlab-ce!31909
-
Marius Bobin authored
-