- 26 Oct, 2021 31 commits
-
-
Bogdan Denkovych authored
Usually, developers run a single test locally. Disabling eager loading by default in test environment should increase productivity since it saves around 10 seconds: With `eager_load` as `true`: ```bash bogdanvlviv@lenovo:~/gitlab-development-kit/gitlab$ bin/rspec spec/models/users_statistics_spec.rb Run options: include {:focus=>true} All examples were filtered out; ignoring {:focus=>true} Test environment set up in 5.122837013 seconds ...... Finished in 8.51 seconds (files took 16.46 seconds to load) 6 examples, 0 failures ``` With `eager_load` as `false`: ```bash bogdanvlviv@lenovo:~/gitlab-development-kit/gitlab$ bin/rspec spec/models/users_statistics_spec.rb Run options: include {:focus=>true} All examples were filtered out; ignoring {:focus=>true} Test environment set up in 5.013345478 seconds ...... Finished in 8.24 seconds (files took 7.18 seconds to load) 6 examples, 0 failures ``` Inspired by https://github.com/rails/rails/pull/43508. It is important to eager load app before deploying it to catch any issues with constants loading. I see that we disable eager_loading on CI, https://gitlab.com/gitlab-org/gitlab/-/merge_requests/30368/diffs#c1e8bf49d38a49639de4f3b2f3cef9ebdbe50dd4_16_26 For mentioned reason above I thik we should enable eager loading on CI. @rymai What do you think about that? I also found that we 'Speed up backend tests in Gitpod environment', https://gitlab.com/gitlab-org/gitlab/-/merge_requests/68482. /cc @splattael Remove `GITLAB_TEST_EAGER_LOAD: "0"` for scripts/setup-test-env It doesn't make any difference for this script. See https://gitlab.com/gitlab-org/gitlab/-/merge_requests/72964#note_713013642 Document `GITLAB_TEST_EAGER_LOAD`. Closes https://gitlab.com/gitlab-org/gitlab/-/issues/343751
-
Marcel Amirault authored
Update Django CI/CD template See merge request gitlab-org/gitlab!73020
-
Matija Čupić authored
-
Fabio Pitino authored
Add runner_features column runtime_runner_features See merge request gitlab-org/gitlab!72378
-
Kati Paizee authored
Secure coding guidelines for dynamic method definition / metaprogramming See merge request gitlab-org/gitlab!72575
-
Nick Malcolm authored
-
Tiger Watson authored
Merge branch 'mwaw/fix-invalid-index_security_ci_builds_on_name_and_id_parser_features' into 'master' Fix invalid index on ci_builds table See merge request gitlab-org/gitlab!71990
-
Fiona Neill authored
Improve security report validation topic See merge request gitlab-org/gitlab!73029
-
Marcel Amirault authored
Put services keyword into new format See merge request gitlab-org/gitlab!73018
-
Suzanne Selhorn authored
-
Fiona Neill authored
Improve Vulnerability-Check docs See merge request gitlab-org/gitlab!72946
-
Russell Dickenson authored
-
Luke Duncalfe authored
Fix translation of title of ZenTao See merge request gitlab-org/gitlab!72960
-
Mark Chao authored
Card match to exclude holder name, but include network name See merge request gitlab-org/gitlab!72574
-
Dylan Griffith authored
Remove `action_mailer.default_url_options` override in development See merge request gitlab-org/gitlab!72817
-
Kushal Pandya authored
Switch to v-safe-html for notes in alert_details component See merge request gitlab-org/gitlab!72876
-
Dylan Griffith authored
Allowlist scope to remove spec-based list item See merge request gitlab-org/gitlab!73037
-
Mark Chao authored
List all card holder name in the table since they can be different. Changelog: changed EE: true
-
Mark Chao authored
-
Mark Chao authored
to include network, but not holder name. Admin requested to display record with different holder name because payment network may accept incorrectly entered holder name.
-
Luke Duncalfe authored
Revert "Merge branch 'yorick/clean-up-merge-request-diff-commits-migration' into 'master'" See merge request gitlab-org/gitlab!73035
-
Evan Read authored
Alphabetized artifacts reports keywords See merge request gitlab-org/gitlab!73022
-
Thong Kuah authored
-
Evan Read authored
Add a list of how account creation See merge request gitlab-org/gitlab!73014
-
Mark Lapierre authored
Fix `online_garbage_collection_spec.rb` QA failure See merge request gitlab-org/gitlab!72888
-
Coung Ngo authored
-
Dylan Griffith authored
Shrink cross-db spec allowlist See merge request gitlab-org/gitlab!73031
-
Baodong authored
Use namespace in the translation of the ZenTao title. Changelog: changed EE: true
-
Evan Read authored
Add mocha to javascript examples See merge request gitlab-org/gitlab!72963
-
Marcel van Remmerden authored
-
Luke Duncalfe authored
This reverts merge request !72219
-
- 25 Oct, 2021 9 commits
-
-
Ezekiel Kigbo authored
Polish wording of Pseudonymizer UI See merge request gitlab-org/gitlab!72613
-
Simon Knox authored
Feature page styling See merge request gitlab-org/gitlab!72976
-
Natalia Tepluhina authored
-
Thong Kuah authored
Final shrinkage of spec allowlist, the rest arises from specs somehow, with the exception of package specs which is known.
-
Amy Qualls authored
Reshape the text - what little there is - for the Pseudonymizer option in the UI. Add a 'learn more' link for users who don't know what this item is. Docs work is also needed, but that can happen in the documentation.
-
Russell Dickenson authored
-
Andrew Fontaine authored
Remove duplicate text from create group description See merge request gitlab-org/gitlab!72954
-
Andrew Fontaine authored
Show linked pipelines mini graph in the pipeline editor See merge request gitlab-org/gitlab!72967
-
Russell Dickenson authored
Do not promise additional language support for Dependency Scanning See merge request gitlab-org/gitlab!72966
-