[ci skip]

Gracefully handle malformed DNs in LDAP group sync

Customer reported an emergency because group sync was blowing up with 'Badly formed DN'. It turns out their LDAP system inserts a blank member entry at the beginning of each LDAP group. When we try to parse this DN, group sync explodes. Obviously we should handle this error gracefully. This merge request catches the error, logs it, and moves on (skipping that entry).

See merge request !392

Bugfix: Remote config URL was not updated when mirror credentials were updated

The `after_save` callback was looking for changes only in the URL
without credentials, this was happening because we store the credentials
in a separate field.

REF: #547 

See merge request !426

Fix fast-forward merge requests git hooks validations

Current implementations checks git hooks during merge request action issued by Web UI to prevent a git merge action failing and not reporting back to the UI (introduced by !326).
The problem is that we shouldn't make the check the merge commit when we are using a Fast Forward merge type.

Fixes gitlab-org/gitlab-ee#598

See merge request !427

The `after_save` callback was looking for changes only in the URL without credentials,
this was happening because we store the credentials in a separate field.

Make it clear the license overusage is visible only to admins

Also make the text describing the number of licensed users consistent.

Closes #607, #610 

Screenshot:

![image](/uploads/61be740a35a4d4c778233645934554b6/image.png)


See merge request !423

Add some debug info for error related to fetching tags.

This will help us to debug: https://sentry.gitlap.com/gitlab/gitlabcom/issues/4469/events

See merge request !419

Closes #610

Closes #607

Add link to Upload License page in broadcast alert message.

That way admins can have a quick link at hand to upload the license.

See merge request !418

Minor updates after release



See merge request !424

Reduce load on DB for license upgrade check

1. Only check if the user is an admin
2. Cache the active user count for an hour

Helps gitlab-com/operations#298

See merge request !421

Add standard web hook headers to Jenkins CI post

Closes #534

The Jenkins web hook was not sending the standard web hook headers.
Specifically, the `gitlab-plugin` for Jenkins needs to use the
`X-GitLab-Event` header. This makes our EE service unable to work with
the newer GitLab Plugin for Jenkins.

See https://github.com/jenkinsci/gitlab-plugin/issues/272

See merge request !374

[ci skip]

1. Only check if the user is an admin
2. Cache the active user count for an hour

Helps gitlab-com/operations#298

Added back total weight on milestone view

![Screen_Shot_2016-05-25_at_13.31.56](/uploads/8530d92c05b97f719b6e42377ffe7b24/Screen_Shot_2016-05-25_at_13.31.56.png)

Should this go into a patch release?

Closes #501

See merge request !420

Closes #501

Fix repository mirror updates for new imports stuck in started

We were calling `RepositoryUpdateMirrorWorker` that sets the import status to `finished` and then add the import job. Then `update_mirror` didn't do anything but set the `import_status` to started. This should be now getting called in the right order... 

Closes https://gitlab.com/gitlab-com/operations/issues/287 and https://gitlab.com/gitlab-org/gitlab-ce/issues/17747

See merge request !416

This will help us to debug: https://sentry.gitlap.com/gitlab/gitlabcom/issues/4469/events

That way admins can have a quick link at hand to upload the license.

CE upstream



See merge request !415

Search through the filenames



See merge request !409

Add one more ES note to 8.8 update guide



See merge request !406

Merge Rubocop changes introduced in CE

This MR merges rubocop changes introduced in EE in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4261 and also fixes offenses detected after enabling these cops.

See merge request !414

Enable multiple Rubocop cops that can be enabled

See https://gitlab.com/gitlab-org/gitlab-ce/issues/17406

This enabled following cops:

```text
Lint/CircularArgumentReference:
  Description: Default values in optional keyword arguments and optional ordinal arguments
----------------
Lint/ConditionPosition:
  Description: Checks for condition placed in a confusing position relative to the keyword.
  StyleGuide: https://github.com/bbatsov/ruby-style-guide#same-line-condition
----------------
Lint/Debugger:
  Description: Check for debugger calls.
----------------
Lint/DefEndAlignment:
  Description: Align ends corresponding to defs correctly.
----------------
Lint/DuplicateMethods:
  Description: Check for duplicate method definitions.
----------------
Lint/DuplicatedKey:
  Description: Check for duplicate keys in hash literals.
----------------
Lint/EachWithObjectArgument:
  Description: Check for immutable argument given to each_with_object.
----------------
Lint/ElseLayout:
  Description: Check for odd code arrangement in an else block.
----------------
Lint/EmptyEnsure:
  Description: Checks for empty ensure block.
----------------
Lint/EmptyInterpolation:
  Description: Checks for empty string interpolation.
----------------
Lint/EndAlignment:
  Description: Align ends correctly.
----------------
Lint/EndInMethod:
  Description: END blocks should not be placed inside method definitions.
----------------
Lint/EnsureReturn:
  Description: Do not use return in an ensure block.
  StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-return-ensure
----------------
Lint/Eval:
  Description: The use of eval represents a serious security risk.
----------------
Lint/FloatOutOfRange:
  Description: Catches floating-point literals too large or small for Ruby to represent.
----------------
Lint/FormatParameterMismatch:
  Description: The number of parameters to format/sprint must match the fields.
----------------
Lint/ImplicitStringConcatenation:
  Description: Checks for adjacent string literals on the same line, which could better
    be represented as a single string literal.
----------------
Lint/InvalidCharacterLiteral:
  Description: Checks for invalid character literals with a non-escaped whitespace character.
----------------
Lint/LiteralInInterpolation:
  Description: Checks for literals used in interpolation.
----------------
Lint/NestedMethodDefinition:
  Description: Do not use nested method definitions.
  StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-nested-methods
----------------
Lint/NextWithoutAccumulator:
  Description: Do not omit the accumulator when calling `next` in a `reduce`/`inject`
    block.
----------------
Lint/RandOne:
  Description: Checks for `rand(1)` calls. Such calls always return `0` and most likely
    a mistake.
----------------
Lint/RequireParentheses:
  Description: Use parentheses in the method call to avoid confusion about precedence.
----------------
Lint/UnreachableCode:
  Description: Unreachable code.
----------------
Lint/UselessComparison:
  Description: Checks for comparison of something with itself.
----------------
Lint/UselessElseWithoutRescue:
  Description: Checks for useless `else` in `begin..end` without `rescue`.
----------------
Lint/UselessSetterCall:
  Description: Checks for useless setter call to a local variable.
----------------
Lint/Void:
  Description: Possible use of operator/literal/variable in void context.
----------------
Performance/DoubleStartEndWith:
  Description: Use `str.{start,end}_with?(x, ..., y, ...)` instead of `str.{start,end}_with?(x,
    ...) || str.{start,end}_with?(y, ...)`.
----------------
Performance/RedundantSortBy:
  Description: Use `sort` instead of `sort_by { |x| x }`.
----------------
Rails/FindBy:
  Description: Prefer find_by over where.first.
  Include:
  - app/models/**/*.rb
----------------
Rails/FindEach:
  Description: Prefer all.find_each over all.find.
  Include:
  - app/models/**/*.rb
----------------
Rails/PluralizationGrammar:
  Description: Checks for incorrect grammar when using methods like `3.day.ago`.
----------------
Rails/ScopeArgs:
  Description: Checks the arguments of ActiveRecord scopes.
  Include:
  - app/models/**/*.rb
```

See merge request !4261

[ci skip]

Allow anonymous user to access pipelines

## What does this MR do?

It fixes an issue where the Pipelines is shown for the Anonymous users,
but they get 404 when clicked. Their session is then logged out.

Fixes #17717.

See merge request !4233