In `Elasticsearch::Git::Repository` we would define `path_to_repo` as
follows:

    unless defined?(path_to_repo)
      def path_to_repo
        @path_to_repo.presence || raise(NotImplementedError, ...)
      end
    end

Prior to this commit, this module would be included into `Repository`
before it defined its own `path_to_repo` method, meaning we would not
use the above definition as intended. However, this _only_ worked
because the module was included before our custom definition. The
`defined?(path_to_repo)` call would always return false, because
`defined?` here checks for _class methods_, and not instance methods. As
a result, when moving `prepend` in `Repository` to the end of the file,
the above code would redefine `Repository#path_to_repo`.

To resolve this, we use `method_defined?` instead of `defined?`, which
allows us to check for the presence of an instance method. This ensures
that `Repository#path_to_repo` does not get overwritten when we include
this module.

This test would expect pipelines to be returned in a particular order,
without actually ordering the rows. This could lead to the test
sometimes failing. To solve this, we use `to include` instead of `to
eq`.

Add a NullNotificationService

See merge request gitlab-org/gitlab-ee!8743

Add docs to help choose the best GitLab installation method

See merge request gitlab-org/gitlab-ee!8646

Make quick-action notes complete sentences

See merge request gitlab-org/gitlab-ee!8740

Docs: Enable gitlab-docs lint

See merge request gitlab-org/gitlab-ee!8803

Fix DiffCheck failing due to invalid string argument

See merge request gitlab-org/gitlab-ee!8779

CE upstream - 2018-12-11 16:21 UTC

Closes gitlab-com/gitlab-docs#260

See merge request gitlab-org/gitlab-ee!8799

Web IDE terminal documentation

See merge request gitlab-org/gitlab-ee!7780

Now that we use NullNotificationService for LDAP users, this attribute
is no longer necessary.

When a group member is an LDAP user, we use this service in place of
NotificationService in order to avoid sending them notifications about
group and project memberships.

Refactor StandardVulnerability to be less cryptic

See merge request gitlab-org/gitlab-ee!8794

Merge branch 'ee-55183-frozenerror-can-t-modify-frozen-string-in-app-mailers-notify-rb' into 'master'

[EE] Fix a potential frozen string error in app/mailers/notify.rb and add tests for Service desk emails

Closes gitlab-ce#55183

See merge request gitlab-org/gitlab-ee!8791

# Conflicts:
#	doc/api/README.md

[ci skip]

Generalise test compare service

See merge request gitlab-org/gitlab-ce!22833

Add note about allow_failure default value for manual jobs

See merge request gitlab-org/gitlab-ce!23685

Added docs for similar issues

Closes #55194

See merge request gitlab-org/gitlab-ce!23403

CE upstream - 2018-12-11 13:21 UTC

See merge request gitlab-org/gitlab-ee!8792

Patch 35

See merge request gitlab-org/gitlab-ce!23711

Add documentation note about not nesting storage paths

See merge request gitlab-org/gitlab-ce!23722

Remove boxes around code comments

Closes #54030 and #54058

See merge request gitlab-org/gitlab-ce!23092

Signed-off-by: Rémy Coutable <remy@rymai.me>

Signed-off-by: Rémy Coutable <remy@rymai.me>

Add missing links to resources

See merge request gitlab-org/gitlab-ce!23605

Add missing links to resources

See merge request gitlab-org/gitlab-ee!8720

Docs: how the global nav works

Closes gitlab-com/gitlab-docs#260

See merge request gitlab-org/gitlab-ce!23065

Docs: how the global nav works

See merge request gitlab-org/gitlab-ee!8771

CE upstream - 2018-12-11 12:21 UTC

Closes gitlab-ce#38524

See merge request gitlab-org/gitlab-ee!8789

Remove deprecated `vlink` class

See merge request gitlab-org/gitlab-ce!23588