- Over `validates_uniqueness_of`

- EE-specific protected branch access level code lives in this new module, while
  CE or CE/EE code lives in the existing `ProtectedBranchAccess` module. This
  allows us to make changes without introducing conflicts.

- The access level model classes first include `ProtectedBranchAccess`, followed
  by `ProtectedBranchAccessEe`, which preserves the inheritance chain:

  {Push,Merge}AccessLevel > ProtectedBranchAccessEe > ProtectedBranchAccess

[EE] Update API spec files to describe the correct class

Port of gitlab-org/gitlab-ce!7718 to EE.

See merge request !940

Include note about using user_filter syntax with special chars

Fixes https://gitlab.com/gitlab-org/gitlab-ee/issues/1201

See merge request !882

CE upstream merge

- [x] .gitlab-ci.yml
- [x] Gemfile.lock
- [x] app/assets/stylesheets/pages/issuable.scss
- [x] app/controllers/concerns/lfs_request.rb
- [x] app/controllers/projects/git_http_controller.rb
- [x] app/helpers/issuables_helper.rb
- [x] app/models/concerns/protected_branch_access.rb
- [x] app/models/protected_branch/merge_access_level.rb
- [x] app/models/protected_branch/push_access_level.rb
- [x] app/services/system_note_service.rb
- [x] app/views/shared/issuable/_filter.html.haml
- [x] app/views/shared/issuable/_form.html.haml
- [x] app/views/shared/issuable/form/_metadata.html.haml
- [x] db/schema.rb
- [x] doc/web_hooks/web_hooks.md
- [x]  features/steps/project/wiki.rb
- [x] lib/api/projects.rb
- [x] lib/gitlab/git_access.rb
- [x] spec/features/security/project/private_access_spec.rb
- [x] spec/features/security/project/public_access_spec.rb
- [x] spec/mailers/notify_spec.rb
- [x] spec/services/merge_requests/merge_service_spec.rb
- [x] spec/services/merge_requests/refresh_service_spec.rb
- [x] spec/services/projects/destroy_service_spec.rb

Merged changes https://gitlab.com/gitlab-org/gitlab-ce/compare/858602ea153056f6cbfeeb4114ea6e29aba03a7a...14046b9c734e5e6506d63276f39f3f9d770c3699

See merge request !937

Prevent remote mirrors from failing when project is in pending_delete

We noticed on GitLab.com that remote mirrors were not even running.
UpdateAllRemoteMirrorsWorker was failing on a project that was in
pending_delete, preventing any workers from running.

Closes gitlab-org/gitlab-ce#23650

See merge request !938

The models were incorrectly merged (this would have been avoided if !927
was merged in, but that MR is still review) leading to a few spec failures.

We noticed on GitLab.com that remote mirrors were not even running.
UpdateAllRemoteMirrorsWorker was failing on a project that was in
pending_delete, preventing any workers from running.

Closes gitlab-org/gitlab-ce#23650

Signed-off-by: Rémy Coutable <remy@rymai.me>

Restore changes for api spec files

Fix error in rspec Users

Delete extra space Repositories-spec

Speed up project snippet security request specs

Part of https://gitlab.com/gitlab-org/gitlab-ce/issues/24899

See https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7779 and
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7813

EE sibling of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7890

See merge request !939

Save some queries on issuable dashboard.

EE version of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7760.

See merge request !935

Signed-off-by: Rémy Coutable <remy@rymai.me>

Signed-off-by: Rémy Coutable <remy@rymai.me>

Instead of doing n queries for n states, do one query to get all the
counts grouped by state, and figure out what the count is for each state
is from that. We can still cache the individual counts (it can't hurt),
but this will help with initial load.

Note that the `opened` scope on `Issuable` includes the `opened` and
`reopened` states, which is why there's a special case.

`any?` on an AR relation performs a `SELECT COUNT`, which we don't need.

1. We are very likely to have issues or MRs, so the `SELECT COUNT` is
   often unnecessary.
2. Even where there are no items returned, the overhead of the
   `SELECT *` instead of `SELECT COUNT` is relatively small.

Calling `to_a` on the relation lets us use `Enumerable#any?`, which will
return immediately if there are objects returned.

Part of https://gitlab.com/gitlab-org/gitlab-ce/issues/24899

See https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7779 and
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7813

Don't allow to specify a repo or version when installing Workhorse

I've also updated the "patch version upgrade" doc since I did forget to update it in !6574.

See merge request !7879

Pass commit data to ProcessCommitWorker

This changes `ProcessCommitWorker` so that it takes a Hash containing commit data instead of a commit SHA. This means the worker doesn't have to access Git just to process a commit message (and other data it may use). This in turn should solve the problem of ending up with 15 000-something jobs in the `process_commit` queue that take forever to process.

See merge request !7744

Allow public access to some Project API endpoints

## What does this MR do?

This opens up a few endpoints in the Project API:

- `GET /projects/visible` (returns public projects only)
- `GET /projects/search/:query` (returns results only for public projects)
- `GET /projects/:id` (only if the project is public)
- `GET /projects/:id/events` (only if the project is public)
- `GET /projects/:id/users` (only if the project is public)

## Are there points in the code the reviewer needs to double check?

I've chosen to explicitly add `authenticate!` to GET methods that still need a current user.

## Does this MR meet the acceptance criteria?

- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [x] API support added
- Tests
  - [x] Added for this feature/bug
  - [ ] All builds are passing

Part of #4269

See merge request !7843

Expose add-ons associated to the license in /license endpoint.

Closes #1286

See merge request !907

Replace static fixture for notes_spec

## What does this MR do?

Replace `comments.html.haml` and `issue_note.html.haml` used in `notes_spec.js` by dynamically created fixture.

## What are the relevant issue numbers?

#24753

See merge request !7683

24726 Remove Across GitLab from side navigation

## What does this MR do?

Removes Across GitLab header from side navigation

## Screenshots (if relevant)
Before:
![Screen_Shot_2016-12-01_at_11.09.12_AM](/uploads/7a8c32a1736a55e0baedf071c21e98db/Screen_Shot_2016-12-01_at_11.09.12_AM.png)

After:
![Screen_Shot_2016-12-01_at_11.09.02_AM](/uploads/4d095ec6e4e756abf0301678bb40d59b/Screen_Shot_2016-12-01_at_11.09.02_AM.png)

## Does this MR meet the acceptance criteria?

- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
  - [ ] Added for this feature/bug
  - [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?


Closes #24726

See merge request !7883

Pipelines tabs

## What does this MR do?
Changes the URL when the builds tab is clicked making it possible to be shared.

1. Adds a standard way to handle linked tabs:
    *   This behaviour is already present in the merge requests, commit and user `show` page. 
    *    This MR introduces a reusable way to accomplish this behaviour for pages with static content.

2. Adds test:
    *   For the linked tabs reusable class
    *  For the pipelines tabs

## Why was this MR needed?
To allow having a sharable URL that represented the opened tab

![tabs](/uploads/91e663c12c6e9ac46a17aa3a9489dc72/tabs.gif)

## Does this MR meet the acceptance criteria?
- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
  - [x] Added for this feature/bug
  - [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?
Closes #24814

See merge request !7709

Replace static fixture for right_sidebar_spec

## What does this MR do?

Replace `right_sidebar.html.haml` for `right_sidebar_spec.js` by already existing dynamically generated fixture.

## What are the relevant issue numbers?

#24753

See merge request !7687

Resolve "User-generated permalink IDs collide with GitLab interface"

## What does this MR do?

Prevents ID values automatically generated by headers in [GitLab Flavored Markdown](https://github.com/gitlabhq/gitlabhq/blob/master/doc/user/markdown.md#header-ids-and-links) from colliding with IDs used elsewhere in the GitLab interface.  This can cause confusion when, for instance, a selector looks for a merge request tab with `id="pipelines"` and there is a header with the same ID earlier in the DOM.

How this works:
* All header IDs generated with GitLab Flavored Markdown are namespaced with `id="user-content_foo"`
* All anchor links which point to these IDs continue to use the non-namespaced hash `<a href="#foo">...</a>`
* When a page is loaded or when the `hashchange` event is triggered, javascript will automatically search for `#user-content_foo` if `#foo` cannot be found, and scroll to that position instead.

## Before

![2016-11-21-13.00.28](/uploads/e3be2cd6a9142dfd6e64db5462a6aa76/2016-11-21-13.00.28.gif)

## After:

![2016-11-21-13.12.45](/uploads/f7ae3f3a30c91325eaa3665591b6a850/2016-11-21-13.12.45.gif)  
![2016-11-21-13.03.00](/uploads/3a6a782c081ecaa05b8781548d794909/2016-11-21-13.03.00.gif)  

## Does this MR meet the acceptance criteria?

- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- Tests
  - [x] Added for this feature/bug
  - [ ] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?

Closes #22781 

See also prior attempts to address this issue:
#3908, !2023, !2024


See merge request !7631

Remove the help text under the sidebar subscribe button and style it inline

## What does this MR do?

Remove the help text under the sidebar subscribe button and style it inline

## Are there points in the code the reviewer needs to double check?


## Why was this MR needed?
Current help text is over obvious and pushes references too far down. Also the subscribe button is now consistently styled and not a complete block button anymore. approved by @awhildy 

## Screenshots (if relevant)

before:
![image](/uploads/0c9543d2bf184a73b65773caa5f9fc62/image.png)

after:
![image](/uploads/765338823376267427f4a16737e39998/image.png)


## Does this MR meet the acceptance criteria?

- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
  - [ ] Added for this feature/bug
  - [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?


Closes #24281

See merge request !7389