1. 02 Jul, 2021 6 commits
    • Eulyeon Ko's avatar
      Make expired_last a sort option · 3cfc27fc
      Eulyeon Ko authored
      expiredLast is more appropriate
      as a sort option since it is a specialized
      case of due date sorting.
      3cfc27fc
    • Eulyeon Ko's avatar
      Apply backend reviewer suggestions · 6387ad2c
      Eulyeon Ko authored
      - Annotate using :aggregate_failures over wrapping in blocks
      - DRY creating objects and specs
      6387ad2c
    • Eulyeon Ko's avatar
      Allow sort and expose expired field for milestones · 771d9576
      Eulyeon Ko authored
      These changes are made to milestone-related GraphQL APIs.
      
      - Milestone type gets a new 'expired' field indicating
      whether milestone's due date is past the current date.
      
      - When listing milstones, these arguments can be specified:
      
        - 'expiredLast' sorts milestones in layers:
        Current miletones are placed first, followed by
        milestones without due dates and expired milestones.
        Within layers, milestones are sorted by due date
        (asc by default) with ties being broken by id (desc).
        When 'expiredLast' is set, 'sort' argument other than
        due_date_desc or due_date_asc is ignored.
      
        - 'sort'
      
      Changelog: added
      771d9576
    • Eulyeon Ko's avatar
      Add a custom ordering option for milestones · 976dacef
      Eulyeon Ko authored
      A new method is added to the milestone model
      to support fetching milestones in this particular order:
      1. Current milestones (due date > current date)
      2. Milestones without due dates
      3. Milestones that are expired (due date <= current_date)
      
      The milestones are then sorted by due date (asc or desc)
      and ties are broken by id in descending order.
      
      The milestone finder is also updated to accept
      a new Boolean parameter 'expired_last' to utilize the
      newly added custom ordering to fetch milestones.
      
      When 'expired_last' is specified, order param must be
      one of 'due_date_asc' or 'due_date_desc'. For non-supported
      order param values (including when it's not provided),
      the default is 'due_date_asc'.
      976dacef
    • Eulyeon Ko's avatar
      Refactor milestone related specs for performance · cd2e298b
      Eulyeon Ko authored
      Refactor to use let_it_be and build wherever suitable
      to improve test performance.
      cd2e298b
    • Evan Read's avatar
      Merge branch 'doc_project_move_states' into 'master' · 5695800c
      Evan Read authored
      Give definitions to each of the repository storage move states
      
      See merge request gitlab-org/gitlab!65288
      5695800c
  2. 01 Jul, 2021 34 commits