- 10 Jul, 2020 7 commits
-
-
Tim Rizzi authored
-
James Fargher authored
Fix IndexStatus find_or_create race condition See merge request gitlab-org/gitlab!36266
-
Dylan Griffith authored
**TL;DR** Fix a race condition where `IndexStatus` is not created and does not raise error. Need to use `!` and get rid of problematic unique model validation. Looking at the code I notice a logical problem with using `find_or_create_by` alongside a unique model validation. The problem is a race condition which comes from `find_or_create` first checking to see if the record exists. If it does not it tries creating which then invokes the validation which checks again to see if the record exists which finally returns a validation error. But see here we are not using `!` version of `find_or_create` and so this validation error is silently ignored. Since we already have a [`safe_find_or_create_by!`]( https://gitlab.com/gitlab-org/gitlab/-/blob/2b01f1f3420d9177e27418df063aad2e1bda1216/app/models/application_record.rb#L37 ) which is designed for handling this race condition using unique indexes and rescue and seeing that this model already has the [unique index]( https://gitlab.com/gitlab-org/gitlab/-/blob/2b01f1f3420d9177e27418df063aad2e1bda1216/db/structure.sql#L19266 ) we should just get rid of the model validation since it just complicates the error handling. Since this is a pretty weird race condition it seems tricky/contrived to try to create a proper unit test for this case.
-
Amy Qualls authored
Move tracing page See merge request gitlab-org/gitlab!36511
-
Amy Qualls authored
As part of the reorganization, move the tracing file to the new home for Operations files.
-
Amy Qualls authored
Move the Create Dashboards and dashboard YAML pages See merge request gitlab-org/gitlab!36504
-
Amy Qualls authored
Create the bare stub for the dashboards page.
-
- 09 Jul, 2020 33 commits
-
-
Mayra Cabrera authored
Support markdown in user's bio attribute See merge request gitlab-org/gitlab!35604
-
Mayra Cabrera authored
Track wiki page views in Snowplow See merge request gitlab-org/gitlab!35784
-
Mayra Cabrera authored
Add additional sort values for Jira issue finder See merge request gitlab-org/gitlab!36364
-
Stan Hu authored
Convert serialized date times into UTC Closes #227487 See merge request gitlab-org/gitlab!36382
-
Stan Hu authored
Adds over_storage_limit? method to EE::Namespace See merge request gitlab-org/gitlab!36358
-
Mike Jang authored
Add a tip to chatops_on_gitlabcom.md step 1 to help in the process See merge request gitlab-org/gitlab!36477
-
Angelo Gulina authored
-
Craig Norris authored
Create new operations/metrics page See merge request gitlab-org/gitlab!36500
-
Amy Qualls authored
Mark both the new operations/metrics page and the operations/ page as belonging to Monitor.
-
Mayra Cabrera authored
Revert "Merge branch 'gitlab-json-multi' into 'master'" See merge request gitlab-org/gitlab!36498
-
Robert Speicher authored
Count health status only for opened issues See merge request gitlab-org/gitlab!36359
-
Robert Speicher authored
Geo Settings Form - Remove Old Code Closes #216134 See merge request gitlab-org/gitlab!35879
-
Stan Hu authored
Enable pagination for the Jira Issues controller See merge request gitlab-org/gitlab!36126
-
Brett Walker authored
for jira issue controller
-
Jose Ivan Vargas authored
Add Snowplow event for expanding security widget See merge request gitlab-org/gitlab!35909
-
Robert May authored
This reverts merge request !35527
-
Andrew Fontaine authored
Default Feature Flag Strategy Dropdown to All Users See merge request gitlab-org/gitlab!35883
-
Jason Goodman authored
Default to all users for new flags and existing flags
-
Clement Ho authored
Move the Operations and Feature Flags page See merge request gitlab-org/gitlab!36468
-
Amy Qualls authored
The /user/project/operations directory is moving to /operations, and I need to start the move by moving the index page to the new location.
-
Robert Speicher authored
Enable confidential_epics flag by default See merge request gitlab-org/gitlab!36271
-
Jan Provaznik authored
Defaults to on for confidential_epics feature flag.
-
Paul Slaughter authored
Make "show labels" toggle persist with localStorage See merge request gitlab-org/gitlab!34728
-
-
Douglas Barbosa Alexandre authored
Add system note for alert when creating issue See merge request gitlab-org/gitlab!36370
-
Sarah Yasonik authored
-
Paul Slaughter authored
Fix glob in stylelint task and subsequent errors See merge request gitlab-org/gitlab!32417
-
Alexander Turinske authored
- the new tests use vue/test-utils and it was confusing to mix those tests in with existing ones, so I separated them out into their own describe block
-
Alexander Turinske authored
-
Alexander Turinske authored
- fix test title to say it tests when something does not happen
-
Alexander Turinske authored
- the defend/secure team wants to track how many users view the security report widget in merge requests - added a new snowplow event to track the expansion of the widget - ensured that it only tracked one event per page load - add/update tests
-
Enrique Alcántara authored
Remove prepend-top-5 CSS class See merge request gitlab-org/gitlab!32882
-
Jan Beckmann authored
- by using stylelint autofix - by disabling certain rules for the affected lines
-