1. 20 Aug, 2016 6 commits
    • Timothy Andrew's avatar
      Only show users that have the `push_code` ability. · 4911f5af
      Timothy Andrew authored
      - While selecting user access for a protected branch.
      4911f5af
    • Timothy Andrew's avatar
      Update CHANGELOG · 683a0920
      Timothy Andrew authored
      683a0920
    • Timothy Andrew's avatar
      Remove branch permissions for users who have left the project. · 205581c5
      Timothy Andrew authored
      -  When a user leaves a project, any access levels that they were
         granted specifically are destroyed.
      
      -  When a user is removed from a project, any access levels that they
         were granted specifically are destroyed.
      205581c5
    • Timothy Andrew's avatar
      Fix protected branches feature spec. · 454c88ae
      Timothy Andrew authored
      To work with restricting access to a specific user.
      454c88ae
    • Timothy Andrew's avatar
      Implement frontend to allow specific people to access protected branches. · f7547d81
      Timothy Andrew authored
      1. While creating a protected branch, you can set a single user / role
        for each setting ("Allowed to Merge", "Allowed to Push").
      
      2. More users / roles can be set subsequently.
      
      3. Repurposed 'users_select.js.coffee` for the needs of this page.
      
      4. Move protected branch settings to the `show` page.
      
          - Too many settings on the single index page can be overwhelming. Also,
            if the number of users that can access a protected branch is large,
            the amount of space between protected branches in the table can be
            unwieldy.
      
          - This is the simplest design I can think of - we can use this
            until we have someone from the frontend/ux team take a look at
            this.
      
          - Move protected branches javascript under a `protected_branches`
            directory.
      
          - The dropdowns don't show access levels / users that have already been
            selected.
      
          - Allow deleting access levels using two new access level controllers.
      f7547d81
    • Timothy Andrew's avatar
      Implement model-level changes to allow branch protection for specific users. · d78ab154
      Timothy Andrew authored
      - A protected branch now `has_many` access levels (as opposed to
        `has_one`, which CE will continue to have). Each access level
        represents either a user or a role that is allowed to access the
        protected branch.
      
      - Update `git_access_spec` to test cases where a specific user is given
        access to a protected branch.
      
      - Remove the explicit `push_check` for protected branches. This is
        because a non-developer user (such as a reporter) should be able to
        push code if they are added to a protected branch specifically.
      
      - Fix specs (git_access_spec) that were implicitly depending on a
        master push access level being created (previously, a protected
        branch's default state was "masters can push + masters can merge").
        Since the current default is "none", the dependency needs to be
        explicitly declared.
      
      - Update `git_push_service` so default branch protection (for new repos)
        works as expected.
      d78ab154
  2. 19 Aug, 2016 1 commit
  3. 18 Aug, 2016 15 commits
  4. 17 Aug, 2016 14 commits
  5. 16 Aug, 2016 4 commits
    • Robert Speicher's avatar
      Update CHANGELOG-EE for 8.10.6, 8.9.7, and 8.8.8 · d503bc93
      Robert Speicher authored
      [ci skip]
      d503bc93
    • Patricio Cano's avatar
      Merge branch 'doc-update-akismet' into 'master' · 76aa85cc
      Patricio Cano authored
      Updated Akismet documentation
      
      Updated Akismet documentation
      
      See merge request !5821
      76aa85cc
    • Robert Speicher's avatar
      Update CHANGELOG for 8.10.6, 8.9.7, and 8.8.8 · 5a1eff71
      Robert Speicher authored
      [ci skip]
      5a1eff71
    • Jacob Schatz's avatar
      Merge branch 'todos-hover-state' into 'master' · 7c884636
      Jacob Schatz authored
      Add hover state to todos
      
      ## What does this MR do?
      
      - Add a hover state to todos like for repository files.
      - Fix button alignment in todos
      - Add link to avatar in todos
      
      ## Are there points in the code the reviewer needs to double check?
      
      The `border-collapse` part—is there any better way?
      
      ## Why was this MR needed?
      
      Make hover states consistent.
      
      ## What are the relevant issue numbers?
      
      fixes #19833 
      
      ## Screenshots
      
      ### Before
      
      ![before](/uploads/cd2e7b234bf08fac48aebb60cdfa26a9/before.png)
      
      ### After
      
      ![todos-list](/uploads/592457050cb3ff2c43dfcce78418c50b/todos-list.png)
      
      ![todos-list-last-hover](/uploads/532714333bc74d1656a5c767012b4cdd/todos-list-last-hover.png)
      
      ![todos-mobile](/uploads/d542b04ddebc9d4354d57151dd04c0d2/todos-mobile.png)
      
      See merge request !5361
      7c884636