CE upstream - Thursday

Closes #4325, gitlab-ce#36054, #4277, #10, gitlab-ce#33926, gitlab-qa#102, gitaly#793, and gitlab-ce#39608

See merge request gitlab-org/gitlab-ee!3787

Only try AWS instance profile creds if needed

See merge request gitlab-org/gitlab-ee!3798

EE:  Add cop to make sure we don't use ivar in a module

See merge request gitlab-org/gitlab-ee!3008

simplify git-annex to LFS migration guide

See merge request gitlab-org/gitlab-ee!2859

Add link to runner security

See merge request gitlab-org/gitlab-ee!3725

[EE] Replace factory_girl_rails with factory_bot_rails

See merge request gitlab-org/gitlab-ee!3783

This is a bad smell that we should fix

Don't use Markdown cache for stubbed settings in specs

See merge request gitlab-org/gitlab-ee!3793

Make help link open in new tab

See merge request gitlab-org/gitlab-ee!3759

Fix broken test mocking the wrong tool

Closes #4350

See merge request gitlab-org/gitlab-ee!3792

`Aws::InstanceProfileCredentials.new` actually performs an API request to AWS,
which can result in us hitting a rate limit.

Rewrite `Gitlab::Elastic::Client.resolve_aws_credentials` to the slightly more
verbose, but equally clear, variant, to ensure that we don't call this unless we
have to - i.e. the static credentials do not work.

* ee/master:
  Added Authorized Keys specific checks for Geo
  Simplify database replication instructions and make dryer
  Add SAST docs for EE
  Combine ssh docs and rename the doc
  Docs: update documentation guidelines
  Replace gl.utils.formatDate in place of exported function
  Add deprecated page back in
  Docs: add indexes for monitoring and performance monitoring
  Add docs for commit diff discussion in merge requests
  Import gitlab_projects.rb from gitlab-shell
  Show clear message when set-geo-primary-node was successful
  fix formatting of parameters for new group and transfer project to group

Documentation for SAST results in MR widget

Closes #4125

See merge request gitlab-org/gitlab-ee!3741

Added Authorized Keys specific checks for Geo

Closes #4090

See merge request gitlab-org/gitlab-ee!3728

Simplify database replication instructions and make dryer

Closes #4254 and #4265

See merge request gitlab-org/gitlab-ee!3682

The ApplicationSetting model uses the CacheMarkdownField concern, which updates
the cached HTML when the field is updated in the database. However, in specs,
when we want to test conditions using ApplicationSetting, we stub it, because
this is accessed in different ways throughout the application.

This means that if a spec runs that caches one of the Markdown fields, and a
later spec uses `stub_application_setting` to set the raw value of that field,
the cached value was still the original one. We can work around this by ignoring
the Markdown cache in contexts where we're using `stub_application_setting`.

We could be smarter, and only do this on the Markdown fields of the model, but
this is probably fine.

Combine ssh docs and rename the doc

Closes #4267

See merge request gitlab-org/gitlab-ee!3753

fix formatting of parameters for new group and transfer project to group

See merge request gitlab-org/gitlab-ee!3758

Add deprecated page back in

See merge request gitlab-org/gitlab-ee!3788

Replace gl.utils.formatDate in place of exported function

Closes #4347

See merge request gitlab-org/gitlab-ee!3789

Docs: update documentation guidelines

See merge request gitlab-org/gitlab-ee!3739

Import gitlab_projects.rb from gitlab-shell (EE version)

See merge request gitlab-org/gitlab-ee!3782

* ee/master: (1162 commits)
  Docs: add indexes for monitoring and performance monitoring
  Add docs for commit diff discussion in merge requests
  Add a security-review page for Geo
  Update flipper to 0.11.0 and take advantage of the new features
  Show clear message when set-geo-primary-node was successful
  EE port of ph-es-modules
  Fix typos and clear things up
  Add audit events to permissions table
  Clarify enterprise editions
  Clarify group sharing log events
  Add last updated date
  Refactor audit events docs
  Rename clair feature to sast_image
  Remove unnecessary newline in audit_event_presenter.rb
  Fix method name for pipeline spec
  Add missing link
  Clear BatchLoader after each spec to prevent holding onto records longer than necessary
  Include project in BatchLoader key to prevent returning blobs for the wrong project
  Add changelog for docker scan mr widget
  Fix conflict for app/assets/javascripts/lib/utils/datetime_utility.js
  ...

Closes #4347

Signed-off-by: Rémy Coutable <remy@rymai.me>