- 22 Oct, 2018 1 commit
-
-
Yorick Peterse authored
This moves the logic of Project#rename_repo and all methods _only_ used by this method into a new service class: Projects::AfterRenameService. By moving this code into a separate service class we can more easily refactor it, and we also get rid of some RuboCop "disable" statements automatically. During the refactoring of this code, I removed most of the explicit logging using Gitlab::AppLogger. The data that was logged would not be useful when debugging renaming issues, as it does not add any value on top of data provided by users. I also removed a variety of comments that either mentioned something the code does in literal form, or contained various grammatical errors. Instead we now resort to more clearly named methods, removing the need for code comments. This method was chosen based on analysis in https://gitlab.com/gitlab-org/release/framework/issues/28. In this issue we determined this method has seen a total of 293 lines being changed in it. We also noticed that RuboCop determined the ABC size (https://www.softwarerenovation.com/ABCMetric.pdf) was too great.
-
- 17 Oct, 2018 11 commits
-
-
Phil Hughes authored
Replace job with group in frontend components to be consistent with backend See merge request gitlab-org/gitlab-ce!22387
-
Winnie Hellmann authored
-
Marcia Ramos authored
Allow JIRA to login using email and API token Closes #49936 See merge request gitlab-org/gitlab-ce!21726
-
Felipe Artur authored
-
Marcia Ramos authored
Add documentation on using NFS v4.1 and disabling server delegations See merge request gitlab-org/gitlab-ce!22379
-
Phil Hughes authored
Resolve "Integrate new vue+vuex code base with new API and remove old haml code" Closes #50904 See merge request gitlab-org/gitlab-ce!22116
-
Filipa Lacerda authored
-
Rémy Coutable authored
Resolve "In web editor, when delete a file, should navigate to enclosing directory" Closes #37727 See merge request gitlab-org/gitlab-ce!21465
-
George Thomas authored
-
Mike Greiling authored
3. enable jasmine/new-line-before-expect See merge request gitlab-org/gitlab-ce!22234
-
Johann Hubert Sonntagbauer authored
-
- 16 Oct, 2018 28 commits
-
-
Fatih Acet authored
Prettify all the things (part 8) See merge request gitlab-org/gitlab-ce!22258
-
Fatih Acet authored
Prettify all the things (part 1) See merge request gitlab-org/gitlab-ce!22248
-
Clement Ho authored
Resolve "Share frontend configs between repos" Closes #49740 See merge request gitlab-org/gitlab-ce!22405
-
Mike Greiling authored
2. enable jasmine/no-promise-without-done-fail See merge request gitlab-org/gitlab-ce!22231
-
Mike Greiling authored
-
Stan Hu authored
For more info, see: * https://gitlab.com/gitlab-org/gitaly/issues/1339 * https://gitlab.com/gitlab-org/gitlab-ce/issues/52017
-
Johann Hubert Sonntagbauer authored
-
Douwe Maan authored
Fix "ready for review" link See merge request gitlab-org/gitlab-ce!22393
-
Douwe Maan authored
Fix commit signature error when project is disabled Closes #50903 See merge request gitlab-org/gitlab-ce!22344
-
Douwe Maan authored
Resolve "Webhook Image URLs Rewritten Incorrectly in Issues" Closes #52650 See merge request gitlab-org/gitlab-ce!22361
-
Fatih Acet authored
Prettify all the things (part 6) See merge request gitlab-org/gitlab-ce!22256
-
Mike Greiling authored
-
Mike Greiling authored
Fixes styling issues in test reports Closes #51386 and #52147 See merge request gitlab-org/gitlab-ce!22204
-
Mike Greiling authored
Resolve "Project slug does not auto populate in IE11" Closes #52686 See merge request gitlab-org/gitlab-ce!22367
-
Mike Greiling authored
-
Mike Greiling authored
-
Mike Greiling authored
-
Robert Speicher authored
Verify that usage ping works when all counts time out See merge request gitlab-org/gitlab-ce!22358
-
Nick Thomas authored
[QA] Handle sign-up when terms must be accepted See merge request gitlab-org/gitlab-ce!22374
-
Sean McGivern authored
Add IID headers to E-Mail notifications Closes #52477 See merge request gitlab-org/gitlab-ce!22263
-
Filipa Lacerda authored
Fixed file templates not clearing in Web IDE Closes #52487 See merge request gitlab-org/gitlab-ce!22357
-
Marcia Ramos authored
Document linguist overriding See merge request gitlab-org/gitlab-ce!22386
-
Filipa Lacerda authored
Fixes diff stats not being visible with performance bar See merge request gitlab-org/gitlab-ce!22390
-
Kamil Trzciński authored
Disable artifact validation for download action See merge request gitlab-org/gitlab-ce!22300
-
Matija Čupić authored
-
Rémy Coutable authored
Use grpc v1.15.x See merge request gitlab-org/gitlab-ce!22350
-
Lukas Eipert authored
These headers can be used to build URLs for API requests. Good examples would be Issues and Merge Requests
-
Rémy Coutable authored
Update git and install git-lfs QA docker image See merge request gitlab-org/gitlab-ce!22355
-