- 18 Nov, 2020 40 commits
-
-
Mark Florian authored
This creates a CE security_reports store that is a subset of the EE version. This subset is roughly the minimum necessary to render counts on the CE security MR widget. See this [epic][1] for more details about the overall direction. The majority of this change is just existing code that's been moved and/or refactored. The only _genuinely_ new piece of code is the new store's entry point: `app/assets/javascripts/vue_shared/security_reports/store/index.js`. Since the CE version only supports SAST and Secret Detection, this MR also refactored the getters to generalise over an array of report types, rather than hard code them all into every getter. This means that these getters can be shared as-is between CE and EE, and behave correctly due to the `reportTypes` field added to the state of both stores. These getters are tested in both CE and EE, to verify the different behaviour based on the available report types. The `noBaseInAllReports` getter turned out not to be used anywhere, so it was deleted. Two existing getters, `anyReportHasIssues` and `areAllReportsLoading` didn't have tests, so tests were added for them in both CE and EE. Since the getters now more explicitly depend on the report types installed in the store, constants were extracted to make their connection explicit, and reduce the chance that typos would lead to runtime errors. The vulnerability severity constants were moved to a common location in CE. The definitions of the `LOADING`, `SUCCESS` and `ERROR` constants were deleted from the `security_reports` directory, since their definitions already exist in the `~/reports/constants.js` file. These constants are intended to be used with/by the `ReportSection` component, so it makes sense not to redefine them elsewhere. Part of https://gitlab.com/gitlab-org/gitlab/-/issues/273423. [1]: https://gitlab.com/groups/gitlab-org/-/epics/4394
-
Amy Qualls authored
Remove use of present tense in ci docs (part 1) See merge request gitlab-org/gitlab!47983
-
Marcel Amirault authored
Part one of a ci doc cleanup
-
Mike Jang authored
Edit API landing page See merge request gitlab-org/gitlab!47989
-
Amy Qualls authored
Remove future tense from Gitaly documentation See merge request gitlab-org/gitlab!47982
-
Evan Read authored
Also update link that changed.
-
Craig Norris authored
Fix future tense issues in Monitor docset See merge request gitlab-org/gitlab!48036
-
Amy Qualls authored
This merge request begins to tackle the future-tense issues in the Monitor documentation. It doesn't completely clean out all instances, but it contains changes to enough pages that it's time to push the work into an MR to avoid merge conflicts.
-
Craig Norris authored
Fix more future-tense issues in Monitor docs See merge request gitlab-org/gitlab!48037
-
Grzegorz Bizon authored
Update build logs blueprint with status and new PM DRI See merge request gitlab-org/gitlab!47922
-
Enrique Alcántara authored
Add "skipped" status to deployments See merge request gitlab-org/gitlab!46614
-
Amy Qualls authored
This second merge request corrects more of the future-tense issues in the Monitor documentation. A few instances remain, but they can be dealt with on an individual basis. (Some discuss future deprecations, and future tense is appropriate in that case.)
-
Yannis Roussos authored
Fix project transfer corrupting shared runners state See merge request gitlab-org/gitlab!48032
-
Adrien Kohlbecker authored
-
Enrique Alcántara authored
Remove DOMContentLoaded Eventlistener See merge request gitlab-org/gitlab!47621
-
Jannik Lehmann authored
Removing DOMContentLoaded Eventlisteners from index files since the scripts are embedded using the defer tag.
-
Sarah Groff Hennigh-Palermo authored
Revert `merge_requests/47323` and `merge_requests/42877` See merge request gitlab-org/gitlab!48026
-
Enrique Alcántara authored
Fix missing padding in custody report dropdown See merge request gitlab-org/gitlab!47927
-
Jiaan Louw authored
-
Jan Provaznik authored
Fix `project` attribute of `StoreScanService` class See merge request gitlab-org/gitlab!48013
-
Sean McGivern authored
Move `extra_shared_runners_minutes_used?` to `Quota#minutes_used_up?` See merge request gitlab-org/gitlab!33793
-
Miguel Rincon authored
Revert "Merge branch 'jivanvl-runner-guided-install-frontend' into 'master'" See merge request gitlab-org/gitlab!48027
-
Miguel Rincon authored
This reverts merge request !42877
-
Miguel Rincon authored
This reverts merge request !47323
-
Mark Florian authored
Sort JavaScript imports by groups in EE specs See merge request gitlab-org/gitlab!47886
-
Vitaly Slobodin authored
Sort imports orders in ee/spec by groups and alphabetically to match our code style.
-
Shinya Maeda authored
Add type annotations for error tracking resolvers See merge request gitlab-org/gitlab!47682
-
Tim Zallmann authored
Only validate service form if active See merge request gitlab-org/gitlab!47201
-
Andy Soiron authored
-
Shinya Maeda authored
ayufan/openshift-cli is not available any more. now use openshift/origin-cli See merge request gitlab-org/gitlab!44933
-
Shinya Maeda authored
Use CS_ANALYZER_IMAGE in CS template See merge request gitlab-org/gitlab!47856
-
Adam Cohen authored
-
Alex Kalderimis authored
This also moves other metadata to the resolvers, rather than the field definitions. Includes updates to the generated GraphQL documentation.
-
Marcia Ramos authored
Add documentation for SSE image upload config See merge request gitlab-org/gitlab!47480
-
Chad Woolley authored
Adds documentation for Static Site Editor config file image_upload_path config entry. Also adds explicit section headers and info for different config files
-
Shinya Maeda authored
Run gitlab-terraform destroy from the correct directory See merge request gitlab-org/gitlab!47881
-
Heinrich Lee Yu authored
Resolve "GitLab API doesn't expose Cluster Managed state" See merge request gitlab-org/gitlab!47310
-
Denys Mishunov authored
Revert "Merge branch 'remove-DOMContentLoaded-clusters-Pages' into 'master'" See merge request gitlab-org/gitlab!47992
-
Kushal Pandya authored
Remove DOMContentLoaded Eventlisteners See merge request gitlab-org/gitlab!47802
-
🤖 GitLab Bot 🤖 authored
Update Gitaly version See merge request gitlab-org/gitlab!48016
-