- 07 May, 2021 2 commits
-
-
Andrew Fontaine authored
Provides a way to display alerts attached to files within the WebIDE. The first alert shows guidance to users who are editing their CI configuration about environments, if we are reasonably certain they don't know about environments. We need to request the parsed CI configuration while the user edits it, and accomplish this by watching the content. This watcher is conditionally created and destroyed when the config file is active.
-
Andrew Fontaine authored
The getAlert function searches through all available alerts (added previously), returning the first alert where its show function returns true, or null if none is found. Actions to fetch the CI configuration for its given current content (when it is being edited), as well as to dismiss the callout for environment guidance are added here. We parse the CI configuration during the mutation to only retain whether or not we have: - sucessfully parsed the CI config, and - found an environment within the config.
-
- 06 May, 2021 38 commits
-
-
Andrew Fontaine authored
An alert is a message to be displayed in a GlAlert in some conditional context of the WebIDE. The first alert added, for example, conditionally shows a message suggesting users investigate the use of environments in their CI configuration. An alert has a very specific interface to publicly conform to: interface Alert { key: Symbol; show: (state: WebIdeState, file: File) => boolean; props: GlAlertProps; dismiss: (store: WebIdeStore) => void; message: VueComponent; } - The key must be a unique value, so Symobl is used to ease uniqueness (two symbols made with the same key are still unique). - The show function takes the state of the WebIDE Vue store and the currently active file to compute a boolean indicating whether or not this alert should be currently shown. In this first alert, we only wish to show it if: - we are currently on the commit tab - we are viewing the root GitLab CI file - displaying this alert is enabled for the current user - the GitLab CI file has been successfully parsed, - and the CI configuration contains no environment configuration - The props must match the props used to configure a GlAlert - The dismiss function may optionally take the WebIDE store to execute further actions or mutations. - The message must be a Vue component definition. This is so that rich HTML content may be easily used within the message. Currently, it must not take any props or attributes, although it should have access to the WebIDE store. As only one alert may be shown at a time, any future alerts with overlapping conditions must keep in mind that these should be listed by priority. This is purposely simple to not expose the user to too many alerts at once. If this is ever converted to a notification system, it may make sense to alter this.
-
Andrew Fontaine authored
We will be using the callout mechanism to persist whether or not users need to be told about using environments with GitLab CI. This necessitates the ability to call graphql mutations. We also need to be able to query the graphql API for the fully parsed CI configuration. Fortunately, that query was already built by the pipeline editing team, so we can re-use it here. One thought is that it might be worth it to build our own query to only fetch a job's environment configuration, instead of the entirety of the pipeline, but for now re-use is better than new.
-
Matthias Käppler authored
Introduce DR mode for CI queueing [RUN ALL RSPEC] [RUN AS-IF-FOSS] See merge request gitlab-org/gitlab!56658
-
Savas Vedova authored
Subscription Activation Modal: Create Modal Component See merge request gitlab-org/gitlab!60819
-
Angelo Gulina authored
-
Savas Vedova authored
[Feature Flag] Remove merged YAML [RUN ALL RSPEC] [RUN AS-IF-FOSS] See merge request gitlab-org/gitlab!60659
-
Frédéric Caplette authored
-
Kamil Trzciński authored
Fix Structured Logger See merge request gitlab-org/gitlab!60632
-
Kushal Pandya authored
Added new award picker to epics See merge request gitlab-org/gitlab!61007
-
Max Woolf authored
Documentation: Adds access token endpoints to OpenAPI See merge request gitlab-org/gitlab!58620
-
Jim Cser authored
-
Kamil Trzciński authored
There's a known set of deficiencies in a CI queueing that might impact our ability to process builds. As a way to temporarily mitigate them we allow to disable them for a very limited period. Use one feature flag for two related optimizations and rename defcon to disaster recovery.
-
Nick Thomas authored
Limit commit diffs highlighting [RUN ALL RSPEC] [RUN AS-IF-FOSS] See merge request gitlab-org/gitlab!53768
-
Phil Hughes authored
updating hover state to match other pipeline graph buttons See merge request gitlab-org/gitlab!60801
-
Thong Kuah authored
Merge branch 'philipcunningham-eagerly-associate-dast-site-profile-with-validation-if-it-exists-300740' into 'master' Associate DastSiteProfile and validation on create See merge request gitlab-org/gitlab!53800
-
Philip Cunningham authored
-
🤖 GitLab Bot 🤖 authored
Update Gitaly version See merge request gitlab-org/gitlab!61121
-
Heinrich Lee Yu authored
Merge branch '325339-invite-members-modal-old-form-is-shown-when-member-lock-is-enabled' into 'master' Fix invite group form being shown when member locked See merge request gitlab-org/gitlab!60245
-
Jackie Fraser authored
-
Mark Chao authored
Merge branch '329695-add-read_commit_status-field-authorization-to-pipeline-fields-that-can-return-jobs' into 'master' Resolve "Add `:read_commit_status` field authorization to Pipeline fields that can return jobs" [RUN ALL RSPEC] [RUN AS-IF-FOSS] See merge request gitlab-org/gitlab!60754
-
Alex Kalderimis authored
Resolve "Add `:read_commit_status` field authorization to Pipeline fields that can return jobs" [RUN ALL RSPEC] [RUN AS-IF-FOSS]
-
Phil Hughes authored
Initial fix to "all threads must be resolved" See merge request gitlab-org/gitlab!59689
-
Amy Qualls authored
-
Sean McGivern authored
DevOps Report: Convert Score empty state to Vue See merge request gitlab-org/gitlab!60715
-
Rémy Coutable authored
Fix Openshift template to run on main branch See merge request gitlab-org/gitlab!60811
-
Mark Chao authored
Merge branch '329204-packages-registries-settings-refactor-to-use-show-action-instead-of-index' into 'master' Packages & Registries settings: use `show` instead of `index` See merge request gitlab-org/gitlab!60621
-
Nicolò Maria Mezzopera authored
-
Natalia Tepluhina authored
Fix: Apply VSA filters to records endpoint See merge request gitlab-org/gitlab!60991
-
Ezekiel Kigbo authored
-
GitLab Release Tools Bot authored
-
Marcia Ramos authored
Make instruction clearer for configuring AWS credentials See merge request gitlab-org/gitlab!60717
-
David Wainaina authored
-
Igor Drozdov authored
Feature flag: limited_diff_highlighting When a huge file changes, its whole content highlighted as a plain text anyway: https://gitlab.com/gitlab-org/gitlab/-/issues/300228
-
Nick Thomas authored
Cached binary detection [RUN ALL RSPEC] [RUN AS-IF-FOSS] See merge request gitlab-org/gitlab!60128
-
Robert May authored
-
Adam Hegyi authored
Resolve "Inverse index on namespaces parent_id, id" See merge request gitlab-org/gitlab!61098
-
Alex Pooley authored
-
Shinya Maeda authored
Fix codequality mr diff report See merge request gitlab-org/gitlab!59421
-