[ci skip]

Accept more paths as Git HTTP

Closes gitlab#294007

See merge request gitlab-org/gitlab-workhorse!670

With the introduction of group wikis we also need to support repository
paths on the toplevel.

We can also make the matching for info refs requests a bit stricter,
by checking for valid `service` parameters in the query string.

Allow blank S3 regions to be used

See merge request gitlab-org/gitlab-workhorse!677

Update GoCloud to v0.21.1+

See merge request gitlab-org/gitlab-workhorse!675

This dependency update is the first step to supporting Azure Managed
Identities (https://gitlab.com/gitlab-org/gitlab/-/issues/242245) so
that static credentials are not needed. This is equivalent to Amazon's
IAM instance profile.

This GoCloud update also requires a newer gprc-go version. v1.34.1
fixes a UNIX socket dialing issue that was broken in v1.34.0:
https://github.com/grpc/grpc-go/issues/3990

Part of https://gitlab.com/gitlab-org/gitlab/-/issues/242245

If consolidated object storage is used without a region, Workhorse will
fall back to making a direct HTTP PUT call to the S3 endpoint because
GitLab Rails does not send the multipart upload URLs in this mode.

However, this will result a 411 Length Required error because multipart
upload URLs must be used when the Content-Length header is not
available.

An S3 region is not strictly required, particularly with Minio. With
Amazon S3, the region will default to US East (`us-east-1`). If the
bucket does not exist in the region, S3 will return with a more
informative error.

Relates to https://gitlab.com/gitlab-org/gitlab/-/issues/297227

[ci skip]

Add missing testcase for DELETE NO CHANGELOG

Closes #342

See merge request gitlab-org/gitlab-workhorse!676

PNG decoder proxy that skips iCCP chunks

Closes #341

See merge request gitlab-org/gitlab-workhorse!673

This is pretty terrible but I wanted to see how it might work.

Reject unknown HTTP methods

See merge request gitlab-org/security/gitlab-workhorse!17

Run CI against Go 1.15 NO CHANGELOG

See merge request gitlab-org/gitlab-workhorse!674

too long method name results in too long
prometheus label name, which can crash prometheus

Makefile: remove find NO CHANGELOG

See merge request gitlab-org/gitlab-workhorse!669

Refactor logging helpers to reduce signature creep

See merge request gitlab-org/gitlab-workhorse!662

Document scripts/update-workhorse for releasing NO CHANGELOG

See merge request gitlab-org/gitlab-workhorse!668

[ci skip]

Add notice about canonical source NO CHANGELOG

See merge request gitlab-org/gitlab-workhorse!667

Support alternate document root directory

See merge request gitlab-org/gitlab-workhorse!626

Do not resize when image is less than 8 bytes, add comments

See merge request gitlab-org/gitlab-workhorse!666

Auto-register Prometheus metrics

Closes #326

See merge request gitlab-org/gitlab-workhorse!660

* Update to latest upstream Prometheus library.
* Update to latest upstream Prometheus gRPC library.
* Switch to `promauto` package to avoid missing metrics.

Closes: https://gitlab.com/gitlab-org/gitlab-workhorse/-/issues/326Signed-off-by: Ben Kochie <bjk@gitlab.com>

This will be useful for supporting no-downtime upgrades. Admins
attempting to upgrade GitLab via our no-downtime upgrade procedure have
found that CSS and JavaScript often don't load while the upgrade is in
progress. This is because in a mixed deployment scenario with a load
balancer, this can happen:

1. User accesses node version N+1, which then makes a CSS/JS request on
version N.
2. User accesses node version N, which then makes a CSS/JS requests on
version N+1.

In both scenarios, the user gets a 404 since only one version of the
assets exist on a given server.

To fix this, we provide an alternate path where previous and future
assets can be stored.

Relates to https://gitlab.com/gitlab-org/gitlab-workhorse/-/issues/304

Fix uploader not returning 413 when artifact too large

Closes #328

See merge request gitlab-org/gitlab-workhorse!663

[ci skip]

Add upload acceleration for Requirements import

See merge request gitlab-org/gitlab-workhorse!664

- Add spec

When an upload exceeds the maximum limit, `ErrEntityTooLarge` gets
returned but is wrapped in multiple layers of errors when it is
checked. As a result, when Google Cloud Storage were used to upload
files, artifacts exceeding the maximum size would report a "500 Internal
Server Error" instead of the correct "413 Request Entity Too Large"
error message.

To fix this, we check the state of `hardLimitReader` and set the error
to `ErrEntityTooLarge` at the end of the `SaveFileFromReader` to ensure
that this error will be returned.

Closes https://gitlab.com/gitlab-org/gitlab-workhorse/-/issues/328