- 09 Apr, 2018 11 commits
-
-
Sean McGivern authored
Goldiloader is great, but has several issues with has_many :through relations: * https://github.com/salsify/goldiloader/issues/12 * https://github.com/salsify/goldiloader/issues/14 * https://github.com/salsify/goldiloader/issues/18 Rather than try to figure out which applies in each case, we should just do the drudge work of manually disabling autoloading for all relations of this type. We can always use regular preloading for specific cases, but this way we avoid generating invalid queries through Goldiloader's magic.
-
Yorick Peterse authored
Goldiloader (https://github.com/salsify/goldiloader) can eager load associations automatically. This removes the need for adding "includes" calls in a variety of different places. This also comes with the added benefit of not having to eager load data if it's not used.
-
Sean McGivern authored
Make email handler clearer Closes #37403 See merge request gitlab-org/gitlab-ce!17501
-
Riccardo Padovani authored
-
Grzegorz Bizon authored
Move FindLicense RPC to OPT OUT status See merge request gitlab-org/gitlab-ce!18228
-
Rémy Coutable authored
[Rails5] Add `rails-controller-testing` gem See merge request gitlab-org/gitlab-ce!18242
-
Grzegorz Bizon authored
Fix undefined method `one?` when pushing to an existing merge request Closes #45152 See merge request gitlab-org/gitlab-ce!18243
-
Phil Hughes authored
Remove modal boards code from global namepsace See merge request gitlab-org/gitlab-ce!18222
-
Sean McGivern authored
[Rails5] Add FALSE_VALUES constant to Service#boolean_accessor See merge request gitlab-org/gitlab-ce!18240
-
Phil Hughes authored
Resolve "Template selectors menu title mistakenly shown after toggling previewed changes" Closes #32617 See merge request gitlab-org/gitlab-ce!18118
-
Douwe Maan authored
Handle legacy repository archive requests with no ref given Closes #45154 See merge request gitlab-org/gitlab-ce!18246
-
- 08 Apr, 2018 8 commits
-
-
Stan Hu authored
The legacy endpoint requires no reference and defaults to the root ref. Closes #45154
-
Douwe Maan authored
Add user documentation for badges Closes #41174 and #41176 See merge request gitlab-org/gitlab-ce!18200
-
Winnie Hellmann authored
-
Douwe Maan authored
Projects and groups badges settings UI Closes #41174 and #41176 See merge request gitlab-org/gitlab-ce!17114
-
Francisco Javier López authored
-
Fabian Schneider authored
-
Stan Hu authored
An untested code path was triggering an Exception because Fixnum doesn't have `one?` implemented in Rails, while arrays and collections do. Closes #45152
-
blackst0ne authored
In Rails 5.0 `assert_template` and `assigns()` have been extracted to the `rails-controller-testing` gem. https://github.com/rails/rails/pull/20138/files This commit adds this gem for rails5.
-
- 07 Apr, 2018 21 commits
-
-
blackst0ne authored
In Rails 5.0 the `ActiveRecord::ConnectionAdapters::Column::TRUE_VALUES` constant has been removed [1] and the remaining `FALSE_VALUES` constant has been moved to `ActiveModel::Type::Boolean` [2] [1]: https://github.com/rails/rails/commit/a502703c3d2151d4d3b421b29fefdac5ad05df61 [2]: https://github.com/rails/rails/commit/9cc8c6f3730df3d94c81a55be9ee1b7b4ffd29f6
-
Kamil Trzciński authored
Create Project Deploy Tokens to allow permanent access to repo and registry Closes #31591 See merge request gitlab-org/gitlab-ce!17894
-
Kamil Trzciński authored
-
Stan Hu authored
Bump `parser` gem to 2.5.0.5 See merge request gitlab-org/gitlab-ce!18237
-
Mayra Cabrera authored
The TIMESTAMP data type is used for values that contain both date and time parts. TIMESTAMP has a range of '1970-01-01 00:00:01' UTC to '2038-01-19 03:14:07' UTC. A Forever lib class was included to handle future dates for PostgreSQL and MySQL, also changes were made to DeployToken to enforce Forever.date Also removes extra conditional from JwtController
-
Mayra Cabrera authored
-
Mayra Cabrera authored
-
Mayra Cabrera authored
-
Mayra Cabrera authored
- Adds a default on expires_at datetime - Modifies deploy tokens views to handle default expires at value - Use datetime_with_timezone where possible - Remove unused scopes
-
Kamil Trzciński authored
-
Mayra Cabrera authored
Also, fixes broken specs
-
Mayra Cabrera authored
-
Kamil Trzciński authored
We use controller actions to pass a newly created token and errors
-
Kamil Trzciński authored
-
Mayra Cabrera authored
Also: - Changes scopes from serializer to use boolean columns - Fixes broken specs
-
Kamil Trzciński authored
-
Mayra Cabrera authored
- Remove extra method for authorize_admin_project - Ensure project presence - Rename 'read_repo' to 'read_repository' to be more verbose
-
Mayra Cabrera authored
- When using 'read_repo' password and project are sent, so we used both of them to fetch for the token - When using 'read_registry' only the password is sent, so we only use that for fetching the token
-
Mayra Cabrera authored
-
Mayra Cabrera authored
Also fixes spec failures on presenter and docs
-
Mayra Cabrera authored
-