- 19 Mar, 2020 40 commits
-
-
Alex Kalderimis authored
This ensures that events are created when wiki pages are created/updated/destroyed in the app. This does not add events for wiki pages edited off-line and then published using git-access. The wiki page base service is the place where WikiPageMeta objects are constructed, leaving the logic in `EventCreateService#wiki_event` very thin. For this reason the two related changes are contained in a transaction. We also refactor wiki services to avoid passing statically known parameters. This is a more OOO conformant design, with fewer branches and if statements. The different kinds of actions are distinguished, with three actions: - external_action (used in the webhook) - usage_counter_action (used in the counter) - event_action (stored in events) These have (potentially) different values and different types. This interface in WikiPages::BaseService is enforced by implementing the three methods inheriting classes must override. We also place feature flag checks around more use sites. This ensures that we do not create wiki page events if the flag is turned off, and that we do not filter for them either. Includes suggested changes from reviewer (@.luke) Co-authored-by: @.luke Incidental chang: Less dynamic queries This passes class names for polymorphic types as constant strings. We do this because these strings are persisted to the database, and changes to the application need to keep previously stored values in mind. Any updates to the WikiPage::Meta class name need to ensure that values stored with `"WikiPage::Meta"` as target_type will still be around.
-
Alex Kalderimis authored
This exposes the wiki page in the REST API, rendered with WikiPageBasic Includes suggested changes from reviewer (@.luke) Co-authored-by: @.luke
-
Alex Kalderimis authored
This ensures that the methods we use for retrieving events respect the :wiki_events feature flag. This flag must be applied in two places - both in the event_collection and in the events_finder, since there exist places in the code base where the event_collection is used without the finder (for example in the projects or the groups controllers) so it must be applied there, but in the events_finder there is a branch that by-passes the event_collection, so we also need it in the finder. To support this flag, we have a new scope `Event.not_wiki_page`, which only returns events that are not wiki page events. This flag is off by default. This includes improvements to the event collection spec by asserting identity rather than length of results. Includes suggested changes from reviewer (@.luke) Co-authored-by: @.luke
-
Alex Kalderimis authored
Includes suggested changes from reviewer (@.luke) Co-authored-by: @.luke
-
Mark Florian authored
Remove d3 module (not used anymore) and upgrade d3-scale See merge request gitlab-org/gitlab!27502
-
Andrew Fontaine authored
Resolve "Reorganise Security Dashboard frontend files" See merge request gitlab-org/gitlab!23879
-
Achilleas Pipinellis authored
Edits to SAST intro See merge request gitlab-org/gitlab!26711
-
Nick Gaskill authored
-
Dmytro Zaporozhets authored
First part of transition from ghost boolean column to user_type See merge request gitlab-org/gitlab!27387
-
Dmytro Zaporozhets authored
Extract unique_internal to a module See merge request gitlab-org/gitlab!27386
-
Martin Wortschack authored
Remove action buttons for special users See merge request gitlab-org/gitlab!27162
-
Mark Florian authored
This is a conflict that occurred after https://gitlab.com/gitlab-org/gitlab/-/merge_requests/27136 got merged.
-
Marcel Amirault authored
Docs: Fix foss-links See merge request gitlab-org/gitlab!27573
-
Bob Van Landuyt authored
Enable new packages list by removing feature flag Closes #55220 and #33905 See merge request gitlab-org/gitlab!18860
-
Nicolò Maria Mezzopera authored
Removed feature flag Removed unncessary controller methods Updated packages_helper Updated tests Added tests for sorting
-
Mark Florian authored
-
Mark Florian authored
The general idea is to move related things closer together, make related directory structures more similar to each other, and name components a bit more consistent. Specifically: - Move all four Security Dashboard types' init functions to `ee/app/assets/security_dashboard/${TYPE}_init.js`. - By bringing all of these together in one place, it'll make it easier to see what's common between them, and will make future refactoring a bit easier. - Simplify "pages" entry points for each dashboard type. - Move Jest store specs so that the directory structures align with the implementation directory structures. - No Karma specs are touched, since touching/moving them generates Danger bot warnings/errors. It's best if they're migrated to Jest anyway in another MR. - Move/rename the `CardSecurityReportsApp` component to `ProjectSecurityDashboard`, under the `ee/app/assets/security_dashboard` hierarchy. - Rename the base `SecurityDashboard` from `app.vue` to `security_dashboard.vue`. - Strip any `App` suffixes used on imported dashboard components.
-
Douglas Barbosa Alexandre authored
Turn off ci_variables_ui ff See merge request gitlab-org/gitlab!27599
-
Imre Farkas authored
Add forking_access_level to projects API See merge request gitlab-org/gitlab!27514
-
Peter Leitzen authored
Add test covering multiple prometheus alerts in single payload See merge request gitlab-org/gitlab!16360
-
Imre Farkas authored
Refactor admin/groups/show view to make less db calls See merge request gitlab-org/gitlab!27462
-
Natalia Tepluhina authored
Always show copyable container registry build / push commands See merge request gitlab-org/gitlab!27492
-
Nicolò Maria Mezzopera authored
- add to getters - unit tests
-
Walmyr Lima e Silva Filho authored
Move logs ee spec to core See merge request gitlab-org/gitlab!27470
-
Dmytro Zaporozhets authored
Fix response format in Group activity API docs See merge request gitlab-org/gitlab!27580
-
Jan Provaznik authored
Optimize projects_with_tracing_enabled query See merge request gitlab-org/gitlab!27540
-
pburdette authored
Remove two changelog entries describing turning on ff.
-
Igor Drozdov authored
GraphQL: Refactor OffsetActiveRecordRelationConnection to use new GraphQL::Pagination class See merge request gitlab-org/gitlab!27459
-
pburdette authored
Turn off the ci_variables_ui feature flag due to a reported customer bug with env scope.
-
Pirate Praveen authored
-
Pirate Praveen authored
-
Mike Greiling authored
Cache Webpack assets in frontend assets compilation jobs See merge request gitlab-org/gitlab!26008
-
Rémy Coutable authored
Use StrongMemoize for Ci::Build#merge_request See merge request gitlab-org/gitlab!27577
-
Kushal Pandya authored
Update GitLab Packages See merge request gitlab-org/gitlab!27449
-
Rémy Coutable authored
Fix title and description from "JIRA" to "Bugzilla" See merge request gitlab-org/gitlab!22255
-
Vincent Privat authored
-
Mark Florian authored
New container registry disable pagination on loading See merge request gitlab-org/gitlab!27519
-
Nick Thomas authored
Enable workhorse upload acceleration for Project Import uploads via UI See merge request gitlab-org/gitlab!27332
-
Sean McGivern authored
Make the 'User comments on a snippet' system test more robust Closes #208775 See merge request gitlab-org/gitlab!27569
-
Imre Farkas authored
Disable lookup of other ActiveSessions to determine admin mode status Closes #35718 See merge request gitlab-org/gitlab!27318
-