- 15 Sep, 2020 4 commits
-
-
Nick Thomas authored
Use strict filetype checks when calling `gm` See merge request gitlab-org/gitlab-workhorse!564
-
Matthias Käppler authored
By default, `gm` will ignore file extensions and determine the correct decoder/encoder based on the file's magic bytes. This means that a file pretending to be something else based on its extension might get processed. According to http://www.graphicsmagick.org/security.html it is recommended to specify the reader based on the expected type instead by prefixing the input file with `jpg:` or `png:` respectively. Also started to add unit tests for the image resizer. Coverage still a bit spotty.
-
Nick Thomas authored
Add logging for local LSIF ZIP caching See merge request gitlab-org/gitlab-workhorse!579
-
Jacob Vosmaer authored
-
- 04 Sep, 2020 4 commits
-
-
Nick Thomas authored
-
Nick Thomas authored
[ci skip]
-
Nick Thomas authored
Support Azure custom storage domains See merge request gitlab-org/gitlab-workhorse!593
-
Stan Hu authored
Users of Azure Blob storage, particularly those using Azure China, Azure Germany, or Azure Government, may need to customize the Azure endpoint. To support this, we add a custom Azure URL opener that supports the `domain` query parameter. This work has been submitted upstream: https://github.com/google/go-cloud/pull/2851/files Documentation for using Azure Blob storage: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/40693.
-
- 03 Sep, 2020 3 commits
-
-
Nick Thomas authored
-
Nick Thomas authored
[ci skip]
-
Alessio Caiazza authored
Drop tests that check for log messages See merge request gitlab-org/gitlab-workhorse!591
-
- 02 Sep, 2020 4 commits
-
-
Stan Hu authored
logrus starts a Goroutine to write messages to the output buffer, but there is no way to flush these messages to ensure they are ready (https://github.com/sirupsen/logrus/issues/435). To avoid race conditions, drop these log checks from our tests.
-
Nick Thomas authored
Use maximum size to reject file upload as needed See merge request gitlab-org/gitlab-workhorse!554
-
Erick Bajao authored
-
Nick Thomas authored
Eliminate unnecessary code in GoCloud test stubs See merge request gitlab-org/gitlab-workhorse!590
-
- 01 Sep, 2020 4 commits
-
-
Stan Hu authored
This should eliminate a race condition that only occurred in the test where multiple Goroutines attempt to write to the same value when opening a bucket.
-
Nick Thomas authored
-
Nick Thomas authored
[ci skip]
-
Alessio Caiazza authored
Remove an in-memory buffer for LSIF transformation Closes #284 See merge request gitlab-org/gitlab-workhorse!586
-
- 31 Aug, 2020 3 commits
-
-
Nick Thomas authored
-
Nick Thomas authored
Support either local or remote upload but not both NO CHANGELOG See merge request gitlab-org/gitlab-workhorse!574
-
Jacob Vosmaer authored
-
- 28 Aug, 2020 8 commits
-
-
Nick Thomas authored
-
Jacob Vosmaer authored
Verify changelog file presence in CI NO CHANGELOG Closes #273 See merge request gitlab-org/gitlab-workhorse!580
-
Alessio Caiazza authored
-
Jacob Vosmaer authored
Fix race condition in httprs test See merge request gitlab-org/gitlab-workhorse!584
-
Nick Thomas authored
Silence errors when Azure objects have aleady been deleted See merge request gitlab-org/gitlab-workhorse!585
-
Nick Thomas authored
Fix objectstore.uploader.uploadError race See merge request gitlab-org/gitlab-workhorse!583
-
Jacob Vosmaer authored
-
Stan Hu authored
In an normal upload flow, GitLab Rails will move a file to its final destination and remove the temporary file. Workhorse issues a DELETE a request to ensure this is cleaned up. Previously this was generating log noise with every upload. Now only log an error message if there were some error other than a 404.
-
- 27 Aug, 2020 4 commits
-
-
Stan Hu authored
The `So(server, ShouldNotBeNil)` call in the httprs test attempts to print a string representation of the `server`, but this is racy because the reconnection state is initialized in a Goroutine. `httptest.NewServer()` always returns a valid value, so we can drop this test. Relates to https://gitlab.com/gitlab-org/gitlab-workhorse/-/issues/285
-
Alessio Caiazza authored
Tests: block until grpc server has stopped Closes #281 See merge request gitlab-org/gitlab-workhorse!576
-
Nick Thomas authored
-
Nick Thomas authored
[ci skip]
-
- 26 Aug, 2020 6 commits
-
-
Jacob Vosmaer authored
Add additional logging for dynamic img resizing See merge request gitlab-org/gitlab-workhorse!562
-
Aleksei Lipniagov authored
-
Nick Thomas authored
Fix semantical merge conflict (double import) Closes #282 See merge request gitlab-org/gitlab-workhorse!577
-
Jacob Vosmaer authored
Remove ProcessReferences flag See merge request gitlab-org/gitlab-workhorse!543
-
Jacob Vosmaer authored
-
Alessio Caiazza authored
Use testify/require in top level tests See merge request gitlab-org/gitlab-workhorse!570
-