- 20 Mar, 2019 1 commit
-
-
Luke Duncalfe authored
A project is needed in order to fetch data from gitaly. Projects can be absent from commits in certain rare situations (like when viewing a MR of a deleted fork). In these cases, assume that the enriched data is not needed. See this comment: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/26144#note_152191106 "It's led to a dilemma about where to "fix" this in code. I'm going to fix it by allowing CommitCollection#enrich! to just return unenriched commits when a project is missing, essentially "silently failing". I hope this is the right decision. It's going with the assumption that calls in these situations in the future are not needing the full data. The alternative would be to allow CommitCollection#enrich! to still error, but handle it in the methods that call #enrich!, however that might lead to brittleness in future when working with project-less MRs."
-
- 18 Mar, 2019 2 commits
-
-
Luke Duncalfe authored
Previously the code for excluding merge commits from the commit collection (CommitCollection#without_merge_commits) was not working when the commits had come from a merge request. Now that this has been fixed, these tests fails. They should always have been written to exclude merge commits when comparing.
-
Luke Duncalfe authored
Allow incomplete commit records to load their full data from gitaly. Commits can be based on a Hash of data retrieved from PostgreSQL, and this data can be intentionally incomplete in order to save space. A new method #gitaly? has been added to Gitlab::Git::Commit, which returns true if the underlying data source of the Commit is a Gitaly::GitCommit. CommitCollection now has a method #enrich which replaces non-gitaly commits in place with commits from gitaly. CommitCollection#without_merge_commits has been updated to call this method, as in order to determine a merge commit we need to have parent data. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/58805
-
- 13 Mar, 2019 37 commits
-
-
Mark Lapierre authored
Quarantine failing test See merge request gitlab-org/gitlab-ce!26119
-
Mike Greiling authored
Hide 404 errors in Karma locally See merge request gitlab-org/gitlab-ce!26073
-
Mark Lapierre authored
-
Marcia Ramos authored
Docs: Cleaning up the merge request workflow Closes #51355 See merge request gitlab-org/gitlab-ce!24559
-
Marcel Amirault authored
-
Marcia Ramos authored
Fix bug "Fatal: Could not parse object {COMMIT_HASH}" See merge request gitlab-org/gitlab-ce!25860
-
Stan Hu authored
Update rubocop target ruby version See merge request gitlab-org/gitlab-ce!24804
-
Marcia Ramos authored
Fix incorrect link format in docs See merge request gitlab-org/gitlab-ce!26103
-
Phil Hughes authored
Removes EE differences for folder_view Closes gitlab-ee#10026 See merge request gitlab-org/gitlab-ce!26053
-
Lin Jen-Shin authored
Fix false positive specs See merge request gitlab-org/gitlab-ce!26031
-
Kamil Trzciński authored
Add merge request pipeline flag to pipeline entity See merge request gitlab-org/gitlab-ce!25846
-
Dan Davison authored
CE port of "e2e test for creating a project from instance template" See merge request gitlab-org/gitlab-ce!25760
-
Phil Hughes authored
Allow modifying squash commit message for fast-forward only merge method Closes #48324, #58805, and #58631 See merge request gitlab-org/gitlab-ce!26017
-
Natalia Tepluhina authored
- fixed tests for edit components
-
Phil Hughes authored
Resolve differences in Webpack config between CE and EE See merge request gitlab-org/gitlab-ce!26100
-
Douwe Maan authored
Use project name and ID in Review App environment URLs instead of the project path slug Closes #52990 See merge request gitlab-org/gitlab-ce!25990
-
Marcia Ramos authored
Fix some 404ing links See merge request gitlab-org/gitlab-ce!25789
-
Evan Read authored
-
Rémy Coutable authored
Update recaptcha gem from 3.x to 4.11 See merge request gitlab-org/gitlab-ce!25921
-
Shinya Maeda authored
Add spec Fix Fix Add changelog Drop attached Remove attached Update changelog ok
-
Robert Speicher authored
Allow filtering labels by a single character Closes #58795 See merge request gitlab-org/gitlab-ce!26012
-
Marcia Ramos authored
Docs: Bring Javascript Style Guide in line with docs standards See merge request gitlab-org/gitlab-ce!25026
-
Marcel Amirault authored
-
Clement Ho authored
Resolve "Remove jquery-atwho-rails gem" Closes #58876 See merge request gitlab-org/gitlab-ce!26058
-
Mike Greiling authored
Remove references to the vendored copies of At.js and jquery.carat as well as the legacy rails wrapper gem.
-
Kamil Trzciński authored
Refactor all_pipelines in Merge request in order to support all pipelines for merge request See merge request gitlab-org/gitlab-ce!25676
-
Nick Thomas authored
-
Rémy Coutable authored
Fix 500 error caused by CODEOWNERS with no matches Closes gitlab-ee#10282 See merge request gitlab-org/gitlab-ce!26072
-
Filipa Lacerda authored
Removes the CDN loading for emojis.json See merge request gitlab-org/gitlab-ce!26102
-
Tim Zallmann authored
-
Nick Thomas authored
-
Rémy Coutable authored
Update group policy to reflect all the requirements See merge request gitlab-org/gitlab-ce!25854
-
Małgorzata Ksionek authored
-
Shinya Maeda authored
Make it sane Include merge ref head Fix union Improve a bit Add spec remove add spec Add changelog fix coding offence Apply suggestion to spec/models/merge_request_spec.rb ok ok Fix Fix spec Fix spec fix Simplify the things Memoize OK a
-
Winnie Hellmann authored
-
James Ramsay authored
-
Mark Lapierre authored
Ignore user status emoji in assertion Closes gitlab-org/quality/staging#45 See merge request gitlab-org/gitlab-ce!26085
-