- 11 Oct, 2019 1 commit
-
-
Sean McGivern authored
There were three sources of N+1 queries here: the license check, the path and namespace information, and the root namespace. The license check was the worst. We were checking the license information on each project individually. This meant we couldn't paginate in SQL, but did so in Ruby, so it was not only an N+1, it was loading too many records. To fix this, we use the fact that this API endpoint can only return projects in a particular namespace. License checks end up at one of two places: for most instances, it's the instance's license itself. For GitLab.com, where individual namespaces have their own plan, it's the root namespace (subgroups can't have plans; they inherit their plan from the root). This means that we only ever need a single check. If it passes, every project returned has the feature available. If it fails, we return a 404, like the other endpoints here. That way we can paginate in SQL, as we should. The path and namespace information N+1 was simple to fix: just preload that information. The final N+1 was on the root namespace, which we return as the `owner` field for compatibility with GitHub. Again, this was always the same for all items in the response, but we can't preload it easily because different projects will be at different levels of the hierarchy. Instead, we just calculate the root namespace once, and pass that as an option to the entity. The entity uses that value if it's given, and falls back to calculating it if it's not (in case this entity is used elsewhere without that option).
-
- 09 Oct, 2019 19 commits
-
-
Bob Van Landuyt authored
Remove “to clipboard” from all copy buttons See merge request gitlab-org/gitlab!17700
-
Pedro Moreira da Silva authored
-
Tim Zallmann authored
Add license list to nav - Bootstrap Vue app for project license list See merge request gitlab-org/gitlab!17867
-
Kushal Pandya authored
Merge branch '12891-use-a-single-badge-to-show-number-of-active-alerts-on-metrics-dashboards' into 'master' Use a single badge to show number of alerts on metrics dashboards Closes #12891 See merge request gitlab-org/gitlab!15789
-
Dhiraj Bodicherla authored
Converted alert label to gitlab ui badge. Moved the alert badge next to chart title
-
Sean McGivern authored
Migrate namespace exist to repository exist calls See merge request gitlab-org/gitlab!18146
-
Kushal Pandya authored
Resolve "Implement a date picker for cycle analytics" Closes #13216 See merge request gitlab-org/gitlab!16510
-
Rémy Coutable authored
Set active insights dashboard tab from hash fragment Closes #11097 See merge request gitlab-org/gitlab!16904
-
James Lopez authored
Update dependency list parser to use license scanning parser See merge request gitlab-org/gitlab!18103
-
mo khan authored
This change updates the dependency list parser to delegate to the license report parser to parse the license report json. This ensures that upgrades to the license report schema do not break the functionality in the dependency list.
-
Evan Read authored
Docs: Add commands to delete a merge request Closes #33657 See merge request gitlab-org/gitlab!18291
-
Diana Stanley authored
-
Evan Read authored
Update details about only:changes See merge request gitlab-org/gitlab!17981
-
Marcel Amirault authored
Clarify possible unwanted behavior when using only:changes in ci
-
Evan Read authored
Add Group SAML troubleshooting documentation See merge request gitlab-org/gitlab!17998
-
James Edwards-Jones authored
-
Stan Hu authored
Do not load uri types if there are no linkable attributes Closes #33407 See merge request gitlab-org/gitlab!18241
-
Mark Lapierre authored
Simplify API fabrication of epics See merge request gitlab-org/gitlab!18297
-
Paul Slaughter authored
Display error for invalid insights config Closes #32644 See merge request gitlab-org/gitlab!17589
-
- 08 Oct, 2019 20 commits
-
-
Russell Dickenson authored
Docs: Update jira.md - clarified that Jira issues are closed for MR on the projects... See merge request gitlab-org/gitlab!18259
-
John Cai authored
-
Russell Dickenson authored
Clarify the relationship between external and free guest users Closes gitlab-com/support/feedback#663 and #32128 See merge request gitlab-org/gitlab!17745
-
Achilleas Pipinellis authored
Clean up the external users section, use lists to make it more readable.
-
Paul Slaughter authored
Frontend Implementation of Code Owner Approval Closes #13251 See merge request gitlab-org/gitlab!15862
-
Samantha Ming authored
- Removes project wide setting from UI
-
Walmyr Lima authored
Now that epics expose a web_url the deleted workaround is not needed anymore.
-
Michael Kozono authored
Refactor checksum code on uploads Closes #12764 See merge request gitlab-org/gitlab!18065
-
Brian Kabiro authored
- create the checksummable concern file
-
Thong Kuah authored
Add backend support for selecting custom templates by ID See merge request gitlab-org/gitlab!18178
-
Dan Davison authored
Add test for configurable issue board See merge request gitlab-org/gitlab!18228
-
Walmyr Lima e Silva Filho authored
-
Nick Thomas authored
Resolve "Flaky spec/finders/members_finder_spec.rb:85" Closes #31427 See merge request gitlab-org/gitlab!18257
-
🙈 jacopo beschi 🙉 authored
-
Michael Kozono authored
Geo: Handle race condition on design update Closes #13052 See merge request gitlab-org/gitlab!17814
-
Fernando authored
* Add feature flag and permissions check * Add controller, route, and nav entries Fix typo Refactor routes and feature flag * Change from license_list to licenses_list * Change from /security/license-list to /licenses Fix pipeline errors * remove controller file whitesspace * regenerate pot file Fix specs and linter Update project_nav_tab? call Add missing new line Fix haml linter Code review changes Update to License Compliance Update page header Remove unecessary before action Remove database.yml.example Remove license list QA action
-
Michael Kozono authored
Geo: Handle race condition for container synchronization Closes #32899 See merge request gitlab-org/gitlab!17823
-
Rémy Coutable authored
Revert com code segregation See merge request gitlab-org/gitlab!18212
-
Aishwarya Subramanian authored
This reverts commit 9ff8b86e, reversing changes made to 2c163449.
-
Filipa Lacerda authored
Productivity Analytics: Add transformScatterData utility method See merge request gitlab-org/gitlab!18249
-