An error occurred fetching the project authors.
- 28 Aug, 2019 1 commit
-
-
Andrew Newdigate authored
The original name has been deprecated
-
- 23 Aug, 2019 1 commit
-
-
John Cai authored
-
- 09 Aug, 2019 1 commit
-
-
Stan Hu authored
This will help identify Sidekiq jobs that invoke excessive number of filesystem access. The timing data is stored in `RequestStore`, but this is only active within the middleware and is not directly accessible to the Sidekiq logger. However, it is possible for the middleware to modify the job hash to pass this data along to the logger.
-
- 30 Jul, 2019 1 commit
-
-
Stan Hu authored
In SELinux, the file cannot be written, and `Errno::EACCES`, not `Errno::ACCESS` is thrown. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/65328
-
- 19 Jul, 2019 1 commit
-
-
Stan Hu authored
If `GitalyClient#can_use_disk?` returned `false`, it was never cached properly and led to excessive number of Gitaly calls. Instead of using `cached_value.present?`, we need to check `cached_value.nil?`. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/64802
-
- 16 Jul, 2019 1 commit
-
-
John Cai authored
Whenever we use the rugged implementation, we are going straight to disk so we want to bypass the disk access check.
-
- 15 Jul, 2019 1 commit
-
-
John Cai authored
-
- 10 Jul, 2019 1 commit
-
-
Mayra Cabrera authored
Suggests to use a JSON structured log instead Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/54102
-
- 09 Jul, 2019 1 commit
-
-
John Cai authored
-
- 05 Jul, 2019 2 commits
-
-
John Cai authored
Add a module we use as a singleton to determine whether or not rails is able to access the disk
-
Zeger-Jan van de Weg authored
The metric was used to correlate Gitaly requests to the Rails controller and action combination. However, Kibana provides better observability in this specific metric, and can handle hig cardinality much better. There's no dashboard in Grafana that currently depends on this metric being exposed.
-
- 18 Jun, 2019 2 commits
-
-
Zeger-Jan van de Weg authored
The feature flag has been introduced an was turned off by default, now the it will default to be turned on. That change would still allow users to turn this feature off by leveraging the Rails console by running: `Feature.disable("gitaly_catfile-cache")` Another option is to manage the number of items the LRU cache will contain, by updating the `config.toml` for Gitaly. This would be the `catfile_cache_size`: https://gitlab.com/gitlab-org/gitaly/blob/0dcb5c579e63754f557aef91a4fa7a00e5b8b127/config.toml.example#L27 Closes: https://gitlab.com/gitlab-org/gitaly/issues/1712
-
Zeger-Jan van de Weg authored
The GitalyClient held a lot of logic which was all very tightly coupled. In this instance the feature logic was extracted to make it do just a little less and create a bit more focus in the GitalyClient's responsibilies.
-
- 03 Jun, 2019 1 commit
-
-
Zeger-Jan van de Weg authored
Delta islands were implemented last released in: https://gitlab.com/gitlab-org/gitaly/merge_requests/1110. It's been enabled on production and works as expected.
-
- 07 May, 2019 1 commit
-
-
Jacob Vosmaer authored
-
- 05 May, 2019 1 commit
-
-
Stan Hu authored
-
- 29 Apr, 2019 1 commit
-
-
John Cai authored
-
- 18 Apr, 2019 1 commit
-
-
Andrew Newdigate authored
This change is a fairly straightforward refactor to extract the tracing and correlation-id code from the gitlab rails codebase into the new LabKit-Ruby project. The corresponding import into LabKit-Ruby was in https://gitlab.com/gitlab-org/labkit-ruby/merge_requests/1 The code itself remains very similar for now. Extracting it allows us to reuse it in other projects, such as Gitaly-Ruby. This will give us the advantages of correlation-ids and distributed tracing in that project too.
-
- 17 Apr, 2019 1 commit
-
-
Stan Hu authored
This adds the backtrace to a table to show exactly where the Gitaly call was made to make it easier to understand where the call originated. This change also collapses the details in the same row to improve the usability when there is a backtrace.
-
- 28 Mar, 2019 1 commit
-
-
John Cai authored
-
- 27 Mar, 2019 3 commits
-
-
Stan Hu authored
This avoids the case: ``` allow_ref_name_caching do allow_ref_name_caching do # using-feature end end ```
-
Stan Hu authored
For a given merge request, it's quite common to see duplicate FindCommit Gitaly requests because the Gitaly CommitService caches the request by the commit SHA, not by the ref name. However, most of the duplicate requests use the ref name, so the cache is never actually used in practice. This leads to unnecessary requests that slow performance. This commit allows certain callers to bypass the ref name to OID conversion in the cache. We don't do this by default because it's possible the tip of the branch changes during the commit, which would cause the caller to get stale data. This commit also forces the Ci::Pipeline to use the full ref name so that caching can work for merge requests. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/57083
-
Stan Hu authored
This makes it easier to debug Gitaly performance issues in the field. This commit also makes the tracking of query time thread-safe via RequestStore.
-
- 13 Mar, 2019 1 commit
-
-
Nick Thomas authored
-
- 11 Mar, 2019 1 commit
-
-
Mark Lapierre authored
We typically don't want to enforce request limits in production However, we have some production-like test environments, i.e., ones where `Rails.env.production?` returns `true`. We do want to be able to check if the limit is being exceeded while testing in those environments.
-
- 06 Mar, 2019 2 commits
-
-
John Cai authored
-
Andrew Newdigate authored
This style change enforces `return if ...` instead of `return nil if ...` to save maintainers a few minor review points
-
- 05 Mar, 2019 1 commit
-
-
John Cai authored
-
- 28 Feb, 2019 1 commit
-
-
Nick Thomas authored
This reverts commit 00675311.
-
- 22 Feb, 2019 1 commit
-
-
Zeger-Jan van de Weg authored
Prior to this change, 35 Gitaly RPCs were allowed. But recently there's been a renewed interest in performance. By lowering the number of calls new N + 1's will pop up. Later commits will add blocks to ignore the raised errors, followed by an issue for each to be fixed.
-
- 25 Jan, 2019 1 commit
-
-
Valery Sizov authored
Backport of https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/7434
-
- 22 Jan, 2019 1 commit
-
-
Andrew Newdigate authored
This change allows the GitLab rails and sidekiq components to receive tracing spans from upstream services such as Workhorse and pass these spans on to downstream services including Gitaly and Sidekiq. This change will also emit traces for incoming and outgoing requests using the propagated trace information. This will allow operators and engineers to view traces across the Workhorse, GitLab Rails, Sidekiq and Gitaly components. Additional intra-service instrumentation will be added in future changes.
-
- 20 Dec, 2018 1 commit
-
-
Ahmad Hassan authored
-
- 19 Dec, 2018 1 commit
-
-
Ahmad Hassan authored
-
- 17 Dec, 2018 1 commit
-
-
Ahmad Hassan authored
-
- 11 Dec, 2018 1 commit
-
-
Ahmad Hassan authored
-
- 07 Dec, 2018 1 commit
-
-
Andrew Newdigate authored
-
- 06 Dec, 2018 3 commits
-
-
Kamil Trzciński authored
This reverts commit 3560b119.
-
Kamil Trzciński authored
This changes `correlation_id` to be `correlation-id` when passed via jobs
-
Kamil Trzciński authored
The Correlation ID is taken or generated from received X-Request-ID. Then it is being passed to all executed services (sidekiq workers or gitaly calls). The Correlation ID is logged in all structured logs as `correlation_id`.
-