An error occurred fetching the project authors.
  1. 28 Aug, 2019 1 commit
  2. 23 Aug, 2019 1 commit
  3. 09 Aug, 2019 1 commit
    • Stan Hu's avatar
      Add Gitaly and Rugged call timing in Sidekiq logs · a74396dc
      Stan Hu authored
      This will help identify Sidekiq jobs that invoke excessive number of
      filesystem access.
      
      The timing data is stored in `RequestStore`, but this is only active
      within the middleware and is not directly accessible to the Sidekiq
      logger. However, it is possible for the middleware to modify the job
      hash to pass this data along to the logger.
      a74396dc
  4. 30 Jul, 2019 1 commit
  5. 19 Jul, 2019 1 commit
  6. 16 Jul, 2019 1 commit
  7. 15 Jul, 2019 1 commit
  8. 10 Jul, 2019 1 commit
  9. 09 Jul, 2019 1 commit
  10. 05 Jul, 2019 2 commits
  11. 18 Jun, 2019 2 commits
  12. 03 Jun, 2019 1 commit
  13. 07 May, 2019 1 commit
  14. 05 May, 2019 1 commit
  15. 29 Apr, 2019 1 commit
  16. 18 Apr, 2019 1 commit
  17. 17 Apr, 2019 1 commit
    • Stan Hu's avatar
      Add backtrace to Gitaly performance bar · fbb3fd13
      Stan Hu authored
      This adds the backtrace to a table to show exactly where the Gitaly call
      was made to make it easier to understand where the call originated.
      
      This change also collapses the details in the same row to improve the
      usability when there is a backtrace.
      fbb3fd13
  18. 28 Mar, 2019 1 commit
  19. 27 Mar, 2019 3 commits
    • Stan Hu's avatar
      Guard against nested allows with ref name caching · 7a2325e4
      Stan Hu authored
      This avoids the case:
      
      ```
      allow_ref_name_caching do
        allow_ref_name_caching do
          # using-feature
        end
      end
      ```
      7a2325e4
    • Stan Hu's avatar
      Allow ref name caching CommitService#find_commit · db759c5d
      Stan Hu authored
      For a given merge request, it's quite common to see duplicate FindCommit
      Gitaly requests because the Gitaly CommitService caches the request by
      the commit SHA, not by the ref name. However, most of the duplicate
      requests use the ref name, so the cache is never actually used in
      practice. This leads to unnecessary requests that slow performance.
      
      This commit allows certain callers to bypass the ref name to
      OID conversion in the cache. We don't do this by default because it's
      possible the tip of the branch changes during the commit, which
      would cause the caller to get stale data.
      
      This commit also forces the Ci::Pipeline to use the full ref name
      so that caching can work for merge requests.
      
      Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/57083
      db759c5d
    • Stan Hu's avatar
      Log Gitaly RPC duration to api_json.log and production_json.log · 74ff33a3
      Stan Hu authored
      This makes it easier to debug Gitaly performance issues in the field.
      
      This commit also makes the tracking of query time thread-safe via
      RequestStore.
      74ff33a3
  20. 13 Mar, 2019 1 commit
  21. 11 Mar, 2019 1 commit
    • Mark Lapierre's avatar
      Add feature flag to enforce gitaly request limits · b3f54b3d
      Mark Lapierre authored
      We typically don't want to enforce request limits in production
      However, we have some production-like test environments, i.e., ones
      where `Rails.env.production?` returns `true`. We do want to be able
      to check if the limit is being exceeded while testing in those
      environments.
      b3f54b3d
  22. 06 Mar, 2019 2 commits
  23. 05 Mar, 2019 1 commit
  24. 28 Feb, 2019 1 commit
  25. 22 Feb, 2019 1 commit
    • Zeger-Jan van de Weg's avatar
      Only allow 30 RPCs per test case to Gitaly · c00a1ec0
      Zeger-Jan van de Weg authored
      Prior to this change, 35 Gitaly RPCs were allowed. But recently there's
      been a renewed interest in performance. By lowering the number of
      calls new N + 1's will pop up.
      
      Later commits will add blocks to ignore the raised errors, followed by
      an issue for each to be fixed.
      c00a1ec0
  26. 25 Jan, 2019 1 commit
  27. 22 Jan, 2019 1 commit
    • Andrew Newdigate's avatar
      Adds inter-service OpenTracing propagation · ca464b60
      Andrew Newdigate authored
      This change allows the GitLab rails and sidekiq components to receive
      tracing spans from upstream services such as Workhorse and pass these
      spans on to downstream services including Gitaly and Sidekiq.
      
      This change will also emit traces for incoming and outgoing requests
      using the propagated trace information. This will allow operators and
      engineers to view traces across the Workhorse, GitLab Rails, Sidekiq and
      Gitaly components.
      
      Additional intra-service instrumentation will be added in future
      changes.
      ca464b60
  28. 20 Dec, 2018 1 commit
  29. 19 Dec, 2018 1 commit
  30. 17 Dec, 2018 1 commit
  31. 11 Dec, 2018 1 commit
  32. 07 Dec, 2018 1 commit
  33. 06 Dec, 2018 3 commits