An error occurred fetching the project authors.
  1. 22 May, 2017 1 commit
  2. 20 May, 2017 1 commit
  3. 19 May, 2017 1 commit
  4. 18 May, 2017 1 commit
  5. 17 May, 2017 1 commit
    • Yorick Peterse's avatar
      Use CTEs for nested groups and authorizations · ac382b56
      Yorick Peterse authored
      This commit introduces the usage of Common Table Expressions (CTEs) to
      efficiently retrieve nested group hierarchies, without having to rely on
      the "routes" table (which is an _incredibly_ inefficient way of getting
      the data). This requires a patch to ActiveRecord (found in the added
      initializer) to work properly as ActiveRecord doesn't support WITH
      statements properly out of the box.
      
      Unfortunately MySQL provides no efficient way of getting nested groups.
      For example, the old routes setup could easily take 5-10 seconds
      depending on the amount of "routes" in a database. Providing vastly
      different logic for both MySQL and PostgreSQL will negatively impact the
      development process. Because of this the various nested groups related
      methods return empty relations when used in combination with MySQL.
      
      For project authorizations the logic is split up into two classes:
      
      * Gitlab::ProjectAuthorizations::WithNestedGroups
      * Gitlab::ProjectAuthorizations::WithoutNestedGroups
      
      Both classes get the fresh project authorizations (= as they should be
      in the "project_authorizations" table), including nested groups if
      PostgreSQL is used. The logic of these two classes is quite different
      apart from their public interface. This complicates development a bit,
      but unfortunately there is no way around this.
      
      This commit also introduces Gitlab::GroupHierarchy. This class can be
      used to get the ancestors and descendants of a base relation, or both by
      using a UNION. This in turn is used by methods such as:
      
      * Namespace#ancestors
      * Namespace#descendants
      * User#all_expanded_groups
      
      Again this class relies on CTEs and thus only works on PostgreSQL. The
      Namespace methods will return an empty relation when MySQL is used,
      while User#all_expanded_groups will return only the groups a user is a
      direct member of.
      
      Performance wise the impact is quite large. For example, on GitLab.com
      Namespace#descendants used to take around 580 ms to retrieve data for a
      particular user. Using CTEs we are able to reduce this down to roughly 1
      millisecond, returning the exact same data.
      
      == On The Fly Refreshing
      
      Refreshing of authorizations on the fly (= when
      users.authorized_projects_populated was not set) is removed with this
      commit. This simplifies the code, and ensures any queries used for
      authorizations are not mutated because they are executed in a Rails
      scope (e.g. Project.visible_to_user).
      
      This commit includes a migration to schedule refreshing authorizations
      for all users, ensuring all of them have their authorizations in place.
      Said migration schedules users in batches of 5000, with 5 minutes
      between every batch to smear the load around a bit.
      
      == Spec Changes
      
      This commit also introduces some changes to various specs. For example,
      some specs for ProjectTeam assumed that creating a personal project
      would _not_ lead to the owner having access, which is incorrect. Because
      we also no longer refresh authorizations on the fly for new users some
      code had to be added to the "empty_project" factory. This chunk of code
      ensures that the owner's permissions are refreshed after creating the
      project, something that is normally done in Projects::CreateService.
      ac382b56
  6. 12 May, 2017 1 commit
    • Sean McGivern's avatar
      Fix conflict resolution from corrupted upstream · ad2bfeb8
      Sean McGivern authored
      I don't know why this happens exactly, but given an upstream and fork repository
      from a customer, both of which required GC, resolving conflicts would corrupt
      the fork so badly that it couldn't be cloned.
      
      This isn't a perfect fix for that case, because the MR may still need to be
      merged manually, but it does ensure that the repository is at least usable.
      
      My best guess is that when we generate the index for the conflict
      resolution (which we previously did in the target project), we obtain a
      reference to an OID that doesn't exist in the source, even though we already
      fetch the refs from the target into the source.
      
      Explicitly setting the source project as the place to get the merge index from
      seems to prevent repository corruption in this way.
      ad2bfeb8
  7. 09 May, 2017 1 commit
  8. 08 May, 2017 2 commits
  9. 04 May, 2017 1 commit
  10. 21 Apr, 2017 1 commit
  11. 17 Apr, 2017 1 commit
  12. 13 Apr, 2017 1 commit
  13. 06 Apr, 2017 1 commit
  14. 05 Apr, 2017 2 commits
  15. 23 Mar, 2017 7 commits
  16. 21 Mar, 2017 1 commit
  17. 01 Mar, 2017 1 commit
    • James Lopez's avatar
      Update occurrences of MWBS to MWPS · a0101ebf
      James Lopez authored
       Rename column in the database
       Rename fields related to import/export feature
       Rename API endpoints
       Rename documentation links
       Rename the rest of occurrences in the code
       Replace the images that contain the words "build succeeds" and docs referencing to them
       Make sure pipeline is green and nothing is missing.
      
      updated doc images
      
      renamed only_allow_merge_if_build_succeeds in projects and fixed references
      
      more updates
      
      fix some spec failures
      
      fix rubocop offences
      
      fix v3 api spec
      
      fix MR  specs
      
      fixed issues with partials
      
      fix MR spec
      
      fix alignment
      
      add missing v3 to v4 doc
      
      wip - refactor v3 endpoints
      
      fix specs
      
      fix a few typos
      
      fix project specs
      
      copy entities fully to V3
      
      fix  entity error
      
      more fixes
      
      fix failing specs
      
      fixed missing entities in V3 API
      
      remove comment
      
      updated code based on feedback
      
      typo
      
      fix spec
      a0101ebf
  18. 28 Feb, 2017 1 commit
  19. 24 Feb, 2017 1 commit
  20. 23 Feb, 2017 7 commits
  21. 16 Feb, 2017 1 commit
  22. 09 Feb, 2017 1 commit
  23. 07 Feb, 2017 1 commit
  24. 03 Feb, 2017 2 commits
  25. 30 Jan, 2017 1 commit