Improve GitHub import performance

Closes #36288, #36292, and #38467

See merge request gitlab-org/gitlab-ce!14445

Resolve "Protected branch form should have sane defaults for dropdowns"

Closes #32163

See merge request gitlab-org/gitlab-ce!14278

Save a query on the todos index page

See merge request gitlab-org/gitlab-ce!14686

Minor backport from EE

See merge request gitlab-org/gitlab-ce!14705

Signed-off-by: Rémy Coutable <remy@rymai.me>

Send a confirmation email when the user adds a secondary email address

Closes #37385, #28621, and #36959

See merge request gitlab-org/gitlab-ce!14703

Only add identities to a user if we find one in Gitlab::OAuth::User.

Closes #38801

See merge request gitlab-org/gitlab-ce!14702

Update github.md importer docs to clarify branches from forks get created in GL

See merge request gitlab-org/gitlab-ce!14670

Signed-off-by: Rémy Coutable <remy@rymai.me>

# Conflicts:
#	app/controllers/admin/users_controller.rb
#	app/controllers/confirmations_controller.rb
#	app/controllers/profiles/emails_controller.rb
#	app/models/user.rb
#	app/services/emails/base_service.rb
#	app/services/emails/destroy_service.rb
#	app/views/devise/mailer/confirmation_instructions.html.haml
#	lib/api/users.rb
#	spec/services/emails/destroy_service_spec.rb

Resolve "Monitoring hover info is clipped"

Closes #38031

See merge request gitlab-org/gitlab-ce!14514

Fixes group milestones breadcrumb links

Closes #38781

See merge request gitlab-org/gitlab-ce!14689

Signed-off-by: Rémy Coutable <remy@rymai.me>

Use the default password from the GDK's root user

Closes gitlab-qa#73

See merge request gitlab-org/gitlab-ce!14701

Use simple path for tmp ref, avoiding extra directory

See merge request gitlab-org/gitlab-ce!14698

[ci skip]

Speed up DeclarativePolicy::Runner#steps_by_score

See merge request gitlab-org/gitlab-ce!14679

Update QA Nokogiri to 1.8.1

See merge request gitlab-org/gitlab-ce!14700

Resolve "Prometheus graphs occasionally have incorrect Y scale"

Closes #38789

See merge request gitlab-org/gitlab-ce!14693

Resolves three security advisories from bundle-audit

Remove 'Repo' prefix from API entities

Closes #28417

See merge request gitlab-org/gitlab-ce!14694

So that we don't have to worry about cleaning empty
directories later. This was brought up at:

https://gitlab.com/gitlab-org/gitlab-ce/issues/38689#note_42242988

Both `Or` and `And` would evaluate whether each rule passed, then calculate a
value based on the results of all of those. We can actually return early in many
cases, without running the rule at all.

Signed-off-by: Rémy Coutable <remy@rymai.me>

Resolve "Hover and legend data should be linked"

Closes #38036

See merge request gitlab-org/gitlab-ce!14400

The point of this task is to run the import in the foreground, so it
shouldn't schedule an import job!
Signed-off-by: Rémy Coutable <remy@rymai.me>

Signed-off-by: Rémy Coutable <remy@rymai.me>

Signed-off-by: Rémy Coutable <remy@rymai.me>

Signed-off-by: Rémy Coutable <remy@rymai.me>

Signed-off-by: Rémy Coutable <remy@rymai.me>

Since we fetch all the refs we need at the beginning of the import
process, we can safely set this attribute.
Signed-off-by: Rémy Coutable <remy@rymai.me>

MergeRequest#create_merge_request_diff and MergeRequest#reload_diff are
the only places where we generate a new MR diff so that's where we
should fetch the ref.

This also ensures that the ref is not fetched when we call
merge_request.merge_request_diffs.create in
Github::Import#fetch_pull_requests.
Signed-off-by: Rémy Coutable <remy@rymai.me>

The benefit is that we don't even have to create temp source/target
branches.

Also, when the source branch of the imported MR is from a fork, name it
"user:branch" to mimic how we display it for MR when forks actually
exists.
Signed-off-by: Rémy Coutable <remy@rymai.me>

We don't need to check if the existing branch contains a specific SHA
since we only use the branch's name, the SHA is taken from the pull
request raw `sha` data.
Signed-off-by: Rémy Coutable <remy@rymai.me>

Also, improved a bit the method names in
Github::Representation::PullRequest.

Last but not least, ensure temp branch names doesn't contain a `/` as
this would create the ref in a subfolder in `refs/heads` (e.g.
`refs/heads/gh-123/456/rymai/foo`), and would leave empty directories
upon branch deletion (e.g. `refs/heads/gh-123/456/rymai/`.
Signed-off-by: Rémy Coutable <remy@rymai.me>