- 12 Aug, 2021 33 commits
-
-
Patrick Steinhardt authored
The function `#commits_for()` has been introduced via 156ce433 (checks: Implement infrastructure for bulk diff checks, 2021-07-29) in order to allow bulk-loading of commits. What this function does is given a set of new commits and a specific object ID, it will do a graph walk of these new commits starting from this ID in order to extract only those commits which have been newly introduced via this object ID. As it turns out though, the implementation has a bug which causes combinatorial explosion: if a commit is reachable via multiple commits, then it will be walked and returned multiple times. This can happen if there are merge commits, where we'll now repeatedly walk all common ancestors of both commits. In case these again contain merge commits, the common ancestors again get walked multiple times. The result is that commits get walked exponentially many times. For the following graph with criss-cross merges, this causes us to return 768 commits instead of the expected 18: o---o---o---o---o---o---o---o / \ / \ / \ / \ / \ / \ / \ / \ o X X X X X X X o \ / \ / \ / \ / \ / \ / \ / \ / o---o---o---o---o---o---o---o Fix the bug by removing seen commit IDs from the hash tracking commits by their object ID. Furthermore, the pending queue is converted to a set such that we don't re-add IDs which we have already seen before such that it doesn't exhibit exponential growth. Changelog: fixed
-
Patrick Steinhardt authored
`#commits_for()` has a bug where commits are returned multiple times in case they're reachable via multiple commits, leading to combinatorial explosion. Add a testcase which demonstrates this bug.
-
Tetiana Chupryna authored
Filter suggested users by saml provider in invite modal dropdown list [RUN ALL RSPEC] [RUN AS-IF-FOSS] See merge request gitlab-org/gitlab!63565
-
Jackie Fraser authored
Filter suggested users by saml provider in invite modal dropdown list [RUN ALL RSPEC] [RUN AS-IF-FOSS]
-
Max Woolf authored
Integrate instance-level with group-level MR approval settings See merge request gitlab-org/gitlab!67316
-
Natalia Tepluhina authored
Remove sec_dependency_scanning_ui_enable Feature Flag See merge request gitlab-org/gitlab!67585
-
Natalia Tepluhina authored
Render emojis in the Content Editor See merge request gitlab-org/gitlab!67986
-
Natalia Tepluhina authored
Move validation logic from Vue component to resolvers See merge request gitlab-org/gitlab!67836
-
Illya Klymov authored
-
Jan Provaznik authored
Bump factory_bot_rails for Ruby3 support [RUN ALL RSPEC] See merge request gitlab-org/gitlab!67866
-
Jacques Erasmus authored
Move value to constants See merge request gitlab-org/gitlab!68011
-
Matthias Käppler authored
Include Puma worker PID in structured log [RUN AS-IF-FOSS] See merge request gitlab-org/gitlab!66694
-
Changzheng Liu authored
Changelog: other
-
Etienne Baqué authored
Additional namespace validation for AdditionalPack See merge request gitlab-org/gitlab!67848
-
Mark Lapierre authored
Update quarantine reason See merge request gitlab-org/gitlab!67871
-
Russell Dickenson authored
Document how DS handles multiple lockfiles See merge request gitlab-org/gitlab!66886
-
Adam Cohen authored
-
Luke Duncalfe authored
Use http read total timeout by default See merge request gitlab-org/gitlab!66487
-
Thong Kuah authored
Add the four primary work item types to DB - issue, incident, test_case, and requirement See merge request gitlab-org/gitlab!67434
-
Brett Walker authored
in preparation for moving issue_type column. Add the default work item types to the work item type table. Changelog: changed
-
Kushal Pandya authored
Enabled diff virtual scrolling by default See merge request gitlab-org/gitlab!67983
-
Patrick Bajao authored
Count epics against issue creation rate limit See merge request gitlab-org/gitlab!67179
-
Dylan Griffith authored
DB testing: Refactor to have stateful observers per migration See merge request gitlab-org/gitlab!65777
-
Luke Duncalfe authored
Fix Rubocop Graphql/Description offenses [RUN AS-IF-FOSS] See merge request gitlab-org/gitlab!67912
-
Dylan Griffith authored
Modify CSP when Sentry is configured See merge request gitlab-org/gitlab!67791
-
Dylan Griffith authored
Add rules support for CI pipeline include See merge request gitlab-org/gitlab!67409
-
Furkan Ayhan authored
-
Mark Lapierre authored
E2E: Update bulk group import via api spec See merge request gitlab-org/gitlab!67946
-
Andrejs Cunskis authored
-
Jake Lear authored
-
Jake Lear authored
Changelog: changed MR: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/67179 EE: true
-
Evan Read authored
Updated nav to match standards See merge request gitlab-org/gitlab!68019
-
Matija Čupić authored
Update Ruby.gitlab-ci.yml for new vendor path See merge request gitlab-org/gitlab!67919
-
- 11 Aug, 2021 7 commits
-
-
Suzanne Selhorn authored
Related to: https://gitlab.com/gitlab-org/technical-writing/-/issues/454
-
-
Mayra Cabrera authored
Make Gitlab::BackgroundMigration.remaining work across queues See merge request gitlab-org/gitlab!67432
-
Andrew Fontaine authored
Render artifact download buttonas for all security report types See merge request gitlab-org/gitlab!67701
-
Mayra Cabrera authored
Resolve "Linear Project#ancestors" See merge request gitlab-org/gitlab!67565
-
Andrew Fontaine authored
Fix policies drawer header height for list page See merge request gitlab-org/gitlab!67905
-
Nick Gaskill authored
A few more edits for clarity and style See merge request gitlab-org/gitlab!68008
-